change start of day shift presentation

Author: Razeeman

features/feature_settings/src/main/java/com/example/util/simpletimetracker/feature_settings/interactor/SettingsAdditionalViewDataInteractor.kt

@@ -232,9 +232,14 @@ class SettingsAdditionalViewDataInteractor @Inject constructor(
                 showSeconds = false,
             ),
         )
+        val value = if (shift == 0L) {
+            resourceRepo.getString(R.string.change_record_type_goal_time_disabled)
+        } else {
+            timeMapper.formatDuration(shift / 1000)
+        }
 
         return SettingsStartOfDayViewData(
-            startOfDayValue = settingsMapper.toStartOfDayText(shift, useMilitaryTime = true),
+            startOfDayValue = value,
             startOfDaySign = settingsMapper.toStartOfDaySign(shift),
             hint = hint,
         )

features/feature_settings/src/main/java/com/example/util/simpletimetracker/feature_settings/viewModel/SettingsViewModel.kt

@@ -122,7 +122,6 @@ class SettingsViewModel @Inject constructor(
     fun onDateTimeSet(timestamp: Long, tag: String?) {
         notificationsDelegate.onDateTimeSet(timestamp, tag)
         displayDelegate.onDateTimeSet(timestamp, tag)
-        additionalDelegate.onDateTimeSet(timestamp, tag)
         backupDelegate.onDateTimeSet(timestamp, tag)
     }
 

features/feature_settings/src/main/java/com/example/util/simpletimetracker/feature_settings/viewModel/delegate/SettingsAdditionalViewModelDelegate.kt

@@ -100,10 +100,6 @@ class SettingsAdditionalViewModelDelegate @Inject constructor(
         onDurationDisabledDelegate(tag)
     }
 
-    fun onDateTimeSet(timestamp: Long, tag: String?) {
-        onDateTimeSetDelegate(timestamp, tag)
-    }
-
     fun onTypesSelected(typeIds: List<Long>, tag: String?) {
         onTypesSelectedDelegate(typeIds, tag)
     }
@@ -139,11 +135,13 @@ class SettingsAdditionalViewModelDelegate @Inject constructor(
 
     private fun onStartOfDayClicked() {
         delegateScope.launch {
-            parent?.openDateTimeDialog(
+            DurationDialogParams(
                 tag = SettingsViewModel.START_OF_DAY_DIALOG_TAG,
-                timestamp = prefsInteractor.getStartOfDayShift(),
-                useMilitaryTime = true,
-            )
+                value = DurationDialogParams.Value.DurationSeconds(
+                    duration = prefsInteractor.getStartOfDayShift() / 1000,
+                ),
+                showSeconds = false,
+            ).let(router::navigate)
         }
     }
 
@@ -296,30 +294,30 @@ class SettingsAdditionalViewModelDelegate @Inject constructor(
         }
     }
 
-    private fun onDurationSetDelegate(tag: String?, duration: Long) {
+    private fun onDurationSetDelegate(tag: String?, duration: Long) = delegateScope.launch {
         when (tag) {
-            SettingsViewModel.IGNORE_SHORT_RECORDS_DIALOG_TAG -> delegateScope.launch {
+            SettingsViewModel.IGNORE_SHORT_RECORDS_DIALOG_TAG -> {
                 prefsInteractor.setIgnoreShortRecordsDuration(duration)
                 parent?.updateContent()
             }
+            SettingsViewModel.START_OF_DAY_DIALOG_TAG -> {
+                val wasPositive = prefsInteractor.getStartOfDayShift() >= 0
+                val newValue = if (wasPositive) duration else duration * -1
+                prefsInteractor.setStartOfDayShift(newValue * 1000)
+                externalViewsInteractor.onStartOfDayChange()
+                parent?.updateContent()
+            }
         }
     }
 
-    private fun onDurationDisabledDelegate(tag: String?) {
+    private fun onDurationDisabledDelegate(tag: String?) = delegateScope.launch {
         when (tag) {
-            SettingsViewModel.IGNORE_SHORT_RECORDS_DIALOG_TAG -> delegateScope.launch {
+            SettingsViewModel.IGNORE_SHORT_RECORDS_DIALOG_TAG -> {
                 prefsInteractor.setIgnoreShortRecordsDuration(0)
                 parent?.updateContent()
             }
-        }
-    }
-
-    private fun onDateTimeSetDelegate(timestamp: Long, tag: String?) = delegateScope.launch {
-        when (tag) {
             SettingsViewModel.START_OF_DAY_DIALOG_TAG -> {
-                val wasPositive = prefsInteractor.getStartOfDayShift() >= 0
-                val newValue = settingsMapper.toStartOfDayShift(timestamp, wasPositive)
-                prefsInteractor.setStartOfDayShift(newValue)
+                prefsInteractor.setStartOfDayShift(0)
                 externalViewsInteractor.onStartOfDayChange()
                 parent?.updateContent()
             }