fix tag selection save button not visible

Author: Razeeman

core/src/main/java/com/example/util/simpletimetracker/core/extension/BottomSheetDialogExtensions.kt

@@ -3,9 +3,11 @@ package com.example.util.simpletimetracker.core.extension
 import android.view.View
 import android.widget.FrameLayout
 import androidx.coordinatorlayout.widget.CoordinatorLayout
+import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
 import com.example.util.simpletimetracker.core.R
 import com.example.util.simpletimetracker.feature_views.extension.addOnScrollListenerAdapter
+import com.google.android.flexbox.FlexboxLayoutManager
 import com.google.android.material.bottomsheet.BottomSheetBehavior
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
 
@@ -45,4 +47,21 @@ fun BottomSheetDialogFragment.blockContentScroll(recyclerView: RecyclerView) {
             if (newState == RecyclerView.SCROLL_STATE_IDLE) behavior?.isDraggable = true
         },
     )
+}
+
+// Disable sheet swipe on content scroll to avoid accidentally closing the sheet when scrolling items.
+fun BottomSheetDialogFragment.blockContentScrollByPosition(recyclerView: RecyclerView) {
+    fun doBlock() {
+        val layoutManager = recyclerView.layoutManager
+        val firstPosition = when (layoutManager) {
+            is LinearLayoutManager -> layoutManager.findFirstCompletelyVisibleItemPosition()
+            is FlexboxLayoutManager -> layoutManager.findFirstCompletelyVisibleItemPosition()
+            else -> 0
+        }
+        behavior?.isDraggable = firstPosition == 0
+    }
+    recyclerView.addOnScrollListenerAdapter(
+        onScrolled = { _, _, _ -> doBlock() },
+        onScrollStateChanged = { _, _ -> doBlock() },
+    )
 }

features/feature_dialogs/src/main/java/com/example/util/simpletimetracker/feature_dialogs/recordTagSelection/RecordTagSelectionDialogFragment.kt

@@ -1,6 +1,5 @@
 package com.example.util.simpletimetracker.feature_dialogs.recordTagSelection
 
-import com.example.util.simpletimetracker.feature_dialogs.databinding.RecordTagSelectionDialogFragmentBinding as Binding
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.ViewGroup
@@ -9,7 +8,7 @@ import androidx.fragment.app.commit
 import androidx.recyclerview.widget.RecyclerView
 import com.example.util.simpletimetracker.core.base.BaseBottomSheetFragment
 import com.example.util.simpletimetracker.core.dialog.OnTagSelectedListener
-import com.example.util.simpletimetracker.core.extension.blockContentScroll
+import com.example.util.simpletimetracker.core.extension.blockContentScrollByPosition
 import com.example.util.simpletimetracker.core.extension.setFullScreen
 import com.example.util.simpletimetracker.core.extension.setSkipCollapsed
 import com.example.util.simpletimetracker.core.manager.KeyboardVisibilityManager
@@ -19,6 +18,7 @@ import com.example.util.simpletimetracker.navigation.ScreenFactory
 import com.example.util.simpletimetracker.navigation.params.screen.RecordTagSelectionParams
 import dagger.hilt.android.AndroidEntryPoint
 import javax.inject.Inject
+import com.example.util.simpletimetracker.feature_dialogs.databinding.RecordTagSelectionDialogFragmentBinding as Binding
 
 @AndroidEntryPoint
 class RecordTagSelectionDialogFragment :
@@ -41,10 +41,13 @@ class RecordTagSelectionDialogFragment :
 
     override fun initDialog() {
         setSkipCollapsed()
+        // Usual blockContentScroll doesn't work,
+        // also need to block here, because long comment input wouldn't scroll otherwise
+        // and would close the sheet instead.
         binding.containerRecordTagSelection.post {
             binding.root.descendants
                 .filterIsInstance<RecyclerView>().firstOrNull()
-                ?.let(::blockContentScroll)
+                ?.let(::blockContentScrollByPosition)
         }
     }
 

features/feature_dialogs/src/main/res/layout/record_tag_selection_dialog_fragment.xml

@@ -13,17 +13,11 @@
         android:src="@drawable/dialog_arrow"
         android:tint="?appContrastColor" />
 
-    <androidx.core.widget.NestedScrollView
+    <FrameLayout
+        android:id="@+id/containerRecordTagSelection"
         android:layout_width="match_parent"
         android:layout_height="0dp"
         android:layout_marginTop="16dp"
-        android:layout_weight="1">
-
-        <FrameLayout
-            android:id="@+id/containerRecordTagSelection"
-            android:layout_width="match_parent"
-            android:layout_height="match_parent" />
-
-    </androidx.core.widget.NestedScrollView>
+        android:layout_weight="1" />
 
 </androidx.appcompat.widget.LinearLayoutCompat>