Skip to content

Commit 102c8d9

Browse files
aksOpsclaude
andcommitted
ci: drop paths filter from go-ci + perf-gate
Same trap that hit ci-java.yml during phase 5 (PR #131). When a workflow's job name is a required check on branch protection AND the workflow has a `paths:` filter, PRs that don't match the filter cause the workflow to be SKIPPED. Skipped workflows never report a status, so the required check sits in "Waiting for status to be reported" indefinitely and blocks merge. The cutover PR (#132) deletes Java but doesn't touch `go/**`, so both `go-ci` and `perf-gate` were skipping with the old filter. Removing the filter makes the jobs always run. Cost: ~2 min go-ci, ~1 min perf-gate on docs-only PRs. Cheap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 8a05f29 commit 102c8d9

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

.github/workflows/go-ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,14 @@ name: go-ci
33
on:
44
push:
55
branches: [main]
6-
paths: ['go/**', '.github/workflows/go-ci.yml']
76
pull_request:
87
branches: [main]
9-
paths: ['go/**', '.github/workflows/go-ci.yml']
8+
# No `paths:` filter — branch protection requires this job name. A
9+
# path filter would cause skip-on-no-go-changes, which never reports
10+
# a status and deadlocks "Waiting for status to be reported" (same
11+
# trap that hit ci-java.yml before its filter was dropped, and that
12+
# blocked PR #131). Go build + test is ~2 minutes with the module
13+
# cache; cheap enough to always run.
1014

1115
permissions:
1216
contents: read

.github/workflows/perf-gate.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,12 @@ name: perf-gate
1313
on:
1414
push:
1515
branches: [main]
16-
paths:
17-
- 'go/**'
18-
- '.github/workflows/perf-gate.yml'
1916
pull_request:
2017
branches: [main]
21-
paths:
22-
- 'go/**'
23-
- '.github/workflows/perf-gate.yml'
18+
# No `paths:` filter — same reason as go-ci.yml. If branch protection
19+
# ever marks this required, a path filter would deadlock "Waiting for
20+
# status to be reported" on non-Go PRs. Wall-clock is ~1 minute; the
21+
# signal is worth the cost.
2422
workflow_dispatch:
2523

2624
permissions:

0 commit comments

Comments
 (0)