From be8eb53d864a37b23e2def635546e0e969a2d781 Mon Sep 17 00:00:00 2001 From: Ilia Date: Tue, 28 Jul 2026 15:05:46 +0300 Subject: [PATCH 1/5] fix: don't use paramsSave --- Libs/Dronecan | 2 +- Libs/libparams | 2 +- Src/modules/application/application.cpp | 8 ++++++-- Src/modules/system/main.cpp | 3 +++ 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/Libs/Dronecan b/Libs/Dronecan index 6be0f6c4..f3f84cf4 160000 --- a/Libs/Dronecan +++ b/Libs/Dronecan @@ -1 +1 @@ -Subproject commit 6be0f6c482e134002ff66454ab9f1733f2f7e00f +Subproject commit f3f84cf4460a1432cfef9450698532d0e681ba91 diff --git a/Libs/libparams b/Libs/libparams index 57daab94..badc4b32 160000 --- a/Libs/libparams +++ b/Libs/libparams @@ -1 +1 @@ -Subproject commit 57daab9431889df2c12645f3b1b0d0ec7b3a472d +Subproject commit badc4b320ed9ebb58c1a00b8b8408c725414432f diff --git a/Src/modules/application/application.cpp b/Src/modules/application/application.cpp index c219b352..cfaa6ec7 100644 --- a/Src/modules/application/application.cpp +++ b/Src/modules/application/application.cpp @@ -73,10 +73,14 @@ static int8_t init_board_periphery() { if (paramsLoad() != 0) { return -1; } - if (!paramsIsCrcValid()) { - (void)paramsSave(); + bool is_erased = false; + (void)is_params_erased(&is_erased); + + if (!paramsIsCrcValid() && is_erased) { + (void)paramsResetToDefault(); } + #if defined(CAN1_TERMINATOR_Pin) && defined(CAN2_TERMINATOR_Pin) auto teminator_param = paramsGetIntegerValue(IntParamsIndexes::PARAM_SYSTEM_CAN_TEMINATOR); diff --git a/Src/modules/system/main.cpp b/Src/modules/system/main.cpp index 011d12e0..00014435 100644 --- a/Src/modules/system/main.cpp +++ b/Src/modules/system/main.cpp @@ -12,6 +12,9 @@ REGISTER_MODULE(SystemModule) void SystemModule::init() { need_notification = paramsGetIntegerValue(IntParamsIndexes::PARAM_LOG_LEVEL) <= 1; + if (!paramsIsCrcValid()) { + set_health(Status::MINOR_FAILURE); + } set_health(Status::OK); set_mode(Mode::STANDBY); } From fbece92829c8b8eea779a43a32caaed60effb050 Mon Sep 17 00:00:00 2001 From: Ilia Date: Tue, 28 Jul 2026 15:26:19 +0300 Subject: [PATCH 2/5] fix: don't overwrite health --- Libs/libparams | 2 +- Src/modules/system/main.cpp | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Libs/libparams b/Libs/libparams index badc4b32..5cc81f5f 160000 --- a/Libs/libparams +++ b/Libs/libparams @@ -1 +1 @@ -Subproject commit badc4b320ed9ebb58c1a00b8b8408c725414432f +Subproject commit 5cc81f5f8cb035c5ab313d431170b004f3380a0c diff --git a/Src/modules/system/main.cpp b/Src/modules/system/main.cpp index 00014435..7c88c9fb 100644 --- a/Src/modules/system/main.cpp +++ b/Src/modules/system/main.cpp @@ -12,10 +12,9 @@ REGISTER_MODULE(SystemModule) void SystemModule::init() { need_notification = paramsGetIntegerValue(IntParamsIndexes::PARAM_LOG_LEVEL) <= 1; - if (!paramsIsCrcValid()) { - set_health(Status::MINOR_FAILURE); - } - set_health(Status::OK); + set_health(paramsIsCrcValid() + ? Status::OK + : Status::MINOR_FAILURE); set_mode(Mode::STANDBY); } From 50064a55b1fe69faa95c17b12a753e8518dc8fed Mon Sep 17 00:00:00 2001 From: Ilia Date: Tue, 28 Jul 2026 15:55:16 +0300 Subject: [PATCH 3/5] last libprarams --- Libs/libparams | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libs/libparams b/Libs/libparams index 5cc81f5f..ef062255 160000 --- a/Libs/libparams +++ b/Libs/libparams @@ -1 +1 @@ -Subproject commit 5cc81f5f8cb035c5ab313d431170b004f3380a0c +Subproject commit ef062255c517653da0f704ff8de6d3caeaf98658 From 920927d9d78566f74d8ebdf8c16bb3f1d25da1f6 Mon Sep 17 00:00:00 2001 From: Ilia Date: Wed, 29 Jul 2026 11:37:52 +0300 Subject: [PATCH 4/5] chore: libparam update --- Libs/libparams | 2 +- Src/modules/application/application.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Libs/libparams b/Libs/libparams index ef062255..e8b6e571 160000 --- a/Libs/libparams +++ b/Libs/libparams @@ -1 +1 @@ -Subproject commit ef062255c517653da0f704ff8de6d3caeaf98658 +Subproject commit e8b6e5715b2f91b18bf28c8c1e7a594e9981a124 diff --git a/Src/modules/application/application.cpp b/Src/modules/application/application.cpp index cfaa6ec7..6edf69af 100644 --- a/Src/modules/application/application.cpp +++ b/Src/modules/application/application.cpp @@ -74,7 +74,7 @@ static int8_t init_board_periphery() { return -1; } bool is_erased = false; - (void)is_params_erased(&is_erased); + (void)paramsIsErased(&is_erased); if (!paramsIsCrcValid() && is_erased) { (void)paramsResetToDefault(); From 6c5c989d9309336e0e1a67152db0ef126c65de25 Mon Sep 17 00:00:00 2001 From: Ilia Date: Thu, 20 Aug 2026 11:58:13 +0300 Subject: [PATCH 5/5] chore: update libs --- Libs/Dronecan | 2 +- Libs/libparams | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Libs/Dronecan b/Libs/Dronecan index f3f84cf4..c4db8c75 160000 --- a/Libs/Dronecan +++ b/Libs/Dronecan @@ -1 +1 @@ -Subproject commit f3f84cf4460a1432cfef9450698532d0e681ba91 +Subproject commit c4db8c755d30188dc088ab96d7183e5817139dea diff --git a/Libs/libparams b/Libs/libparams index e8b6e571..fe7d62ba 160000 --- a/Libs/libparams +++ b/Libs/libparams @@ -1 +1 @@ -Subproject commit e8b6e5715b2f91b18bf28c8c1e7a594e9981a124 +Subproject commit fe7d62ba117679c4ed519e6f6f294b36c350a411