Skip to content

Strict overflow in /Libs/Dronecan/platform_specific/socketcan/socketcan.c during sitl_dronecan target build #125

Description

@AsiiaPine

Problem:
The errors occurs because of too strict compilation flag -Wstrict-overflow=5 in cmake/toolchain-ubuntu.cmake

/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c: In function ‘getErrorCode’:
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
  180 | }
      | ^
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c: In function ‘socketcanInit’:
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c: In function ‘socketcanClose’:
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c: In function ‘socketcanTransmit’:
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c: In function ‘socketcanReceive’:
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
/home/asiia/Documents/work/nodes/mini_v2_node/Libs/Dronecan/platform_specific/socketcan/socketcan.c:180:1: error: assuming signed overflow does not occur when determining that expression is always non-negative [-Werror=strict-overflow]
cc1: all warnings being treated as errors

Solution:
Set strict-overflow value less aggressive: -Wstrict-overflow=3
The build becomes successful

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions