Skip to content

The documentation's examples call public-but-unexported names unqualified — 29 sites #18

Description

@sotashimozono

Only @experimental is exported. Everything else — record, entered, audit, mark, experimental, compare, isbreaking, stamp, assert_clean, … — is public and not exported.

julia> Base.isexported(ExperimentalAPI, :record), Base.ispublic(ExperimentalAPI, :record)
(false, true)

The documentation calls them unqualified in 29 places across adopting.md, analysing.md, checking.md, declaring.md, observing.md and releases.md:

r = record() do            # UndefVarError: `record` not defined
    
end

A reader who writes using ExperimentalAPI — which is what every example above them shows — gets UndefVarError on the first line of each.

The package states the convention itself, in api.md:

experimental is public, not exported, so it is qualified — which is the visibility convention this package leans on rather than duplicates.

The README follows it (ExperimentalAPI.entered()); the documentation pages do not.

Fix

Qualify them, and add a check so it cannot recur: for every julia block under docs/src, no name that is public && !exported may appear unqualified.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions