Skip to content

Commit d9c65d8

Browse files
zzylolclaude
andcommitted
Fix misleading WindowManager struct comment
The original comment said "Manages tumbling window boundaries" which implied it only handled tumbling windows. Updated to reflect that it handles both tumbling and sliding windows, and clarified the slide_interval_ms field comment to distinguish the two cases. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent d7c7837 commit d9c65d8

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

asap-query-engine/src/precompute_engine/window_manager.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1-
/// Manages tumbling window boundaries and detects which windows have closed
2-
/// based on watermark advancement.
1+
/// Manages tumbling and sliding window boundaries and detects which windows
2+
/// have closed based on watermark advancement.
3+
///
4+
/// Tumbling windows are a special case where `slide_interval == window_size`.
5+
/// The same logic handles both — no separate code paths.
36
pub struct WindowManager {
47
/// Window size in milliseconds.
58
window_size_ms: i64,
6-
/// Slide interval in milliseconds (== window_size_ms for tumbling windows).
9+
/// Slide interval in milliseconds. Equal to `window_size_ms` for tumbling
10+
/// windows; strictly less than `window_size_ms` for sliding windows.
711
slide_interval_ms: i64,
812
}
913

0 commit comments

Comments
 (0)