Skip to content

Commit b7dd3cd

Browse files
zzylolclaude
andauthored
Revert sketchlib-rust path dependency workarounds now that repo is public (#160)
- Add sketchlib-rust git dependency to asap-query-engine/Cargo.toml - Remove workspace exclude for sketchlib-rust from root Cargo.toml - Remove sketchlib-rust/ from .gitignore - Remove sketchlib-rust rsync entry from asap-tools/components.conf - Uncomment series.rs and query.rs in promsketch_store - Remove stale commented-out private-repo CI steps from rust.yml - Remove stale commented-out secret-based build from Dockerfile - Regenerate Cargo.lock Closes #154 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 8da56b5 commit b7dd3cd

9 files changed

Lines changed: 631 additions & 577 deletions

File tree

.github/workflows/rust.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@ jobs:
2828
steps:
2929
- uses: actions/checkout@v4
3030

31-
# - name: Configure git for private dependencies
32-
# run: git config --global url."https://x-access-token:${{ secrets.PRIVATE_REPO_TOKEN }}@github.com/".insteadOf "https://github.com/"
33-
34-
# - name: Clone sketchlib-rust
35-
# run: git clone https://github.com/ProjectASAP/sketchlib-rust.git
36-
3731
- name: Install Rust
3832
uses: dtolnay/rust-toolchain@stable
3933
with:
@@ -81,12 +75,6 @@ jobs:
8175
steps:
8276
- uses: actions/checkout@v4
8377

84-
# - name: Configure git for private dependencies
85-
# run: git config --global url."https://x-access-token:${{ secrets.PRIVATE_REPO_TOKEN }}@github.com/".insteadOf "https://github.com/"
86-
87-
# - name: Clone sketchlib-rust
88-
# run: git clone https://github.com/ProjectASAP/sketchlib-rust.git
89-
9078
- name: Install Rust
9179
uses: dtolnay/rust-toolchain@stable
9280
with:
@@ -145,7 +133,3 @@ jobs:
145133

146134
- name: Build Docker image
147135
run: docker build -f asap-query-engine/Dockerfile -t sketchdb-queryengine-rust:latest .
148-
# run: |
149-
# echo "${{ secrets.PRIVATE_REPO_TOKEN }}" > /tmp/git_token
150-
# docker build --secret id=git_token,src=/tmp/git_token -f QueryEngineRust/Dockerfile -t sketchdb-queryengine-rust:latest .
151-
# rm -f /tmp/git_token

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
target/
22
experiment_outputs/
33

4-
# Private repo, vendored locally until open sourced (see GitHub issue)
5-
sketchlib-rust/
6-
74
# Runtime and generated files
85
metadata/
96
preprocessed_configs/

0 commit comments

Comments
 (0)