Fix packaging and test infrastructure for portable distribution

- Fix CPack packaging to include HDF5 and Irrlicht DLLs
- Fix data directory install path (trailing slash issue)
- Include test input data (YAML, H5, geometry) in package
- Set HYDROCHRONO_DATA_DIR in RUN-TESTS.ps1 for portable execution
- Remove deprecated Chrono API calls (GetTypeAsString) in regression tests

Author: dav-og

CMakeLists.txt

@@ -162,8 +162,8 @@ endif()
 file(COPY ${CMAKE_SOURCE_DIR}/data/ DESTINATION ${HC_BUILD_DATA})
 message(STATUS "  copied to: ${HC_BUILD_DATA}/")
 
-# Install data directory
-install(DIRECTORY ${HC_BUILD_DATA} DESTINATION ${HC_INSTALL_DATA})
+# Install data directory (trailing slash copies contents, not the directory itself)
+install(DIRECTORY ${HC_BUILD_DATA}/ DESTINATION ${HC_INSTALL_DATA})
 message(STATUS "  installed to: ${CMAKE_INSTALL_PREFIX}/${HC_INSTALL_DATA}/")
 
 # -- Output Directory Structure --
@@ -663,14 +663,45 @@ if(${CMAKE_SYSTEM_NAME} MATCHES "Windows")
         endif()
     endforeach()
 
-    # HDF5 DLLs
+    # HDF5 DLLs - use glob to find all DLLs in HDF5 bin directory
+    if(DEFINED HDF5_ROOT OR DEFINED HDF5_DIR)
+        # Determine HDF5 root from various possible variables
+        if(DEFINED HDF5_ROOT)
+            set(_hdf5_root "${HDF5_ROOT}")
+        elseif(DEFINED HDF5_DIR)
+            # HDF5_DIR might point to share/cmake/hdf5 or similar
+            get_filename_component(_hdf5_root "${HDF5_DIR}" DIRECTORY)
+            get_filename_component(_hdf5_root "${_hdf5_root}" DIRECTORY)
+            get_filename_component(_hdf5_root "${_hdf5_root}" DIRECTORY)
+        endif()
+        
+        set(_hdf5_bin "${_hdf5_root}/bin")
+        if(EXISTS "${_hdf5_bin}")
+            file(GLOB _hdf5_dlls "${_hdf5_bin}/*.dll")
+            if(_hdf5_dlls)
+                message(STATUS "Installing HDF5 DLLs from: ${_hdf5_bin}")
+                install(FILES ${_hdf5_dlls} DESTINATION bin COMPONENT runtime)
+            endif()
+        endif()
+    endif()
+    
+    # Also try target-based approach as fallback
     foreach(tgt ${HDF5_TARGETS})
         get_target_property(tgt_DLL ${tgt} IMPORTED_LOCATION_RELEASE)
         if(EXISTS ${tgt_DLL})
             install(FILES ${tgt_DLL} DESTINATION bin COMPONENT runtime)
         endif()
     endforeach()
 
+    # Irrlicht DLL
+    if(HYDROCHRONO_ENABLE_IRRLICHT AND DEFINED Irrlicht_ROOT)
+        set(_irr_dll "${Irrlicht_ROOT}/bin/Win64-VisualStudio/Irrlicht.dll")
+        if(EXISTS "${_irr_dll}")
+            message(STATUS "Installing Irrlicht.dll from: ${_irr_dll}")
+            install(FILES "${_irr_dll}" DESTINATION bin COMPONENT runtime)
+        endif()
+    endif()
+    
     # Python DLLs, if Chrono::Parsers depends on it
     if(CHRONO_PARSERS_PYTHON)
         find_package(Python3 QUIET COMPONENTS Interpreter Development)
@@ -694,6 +725,13 @@ install(DIRECTORY ${PROJECT_SOURCE_DIR}/tests/regression/run_hydrochrono
         PATTERN "__pycache__" EXCLUDE
         PATTERN "*.pyc" EXCLUDE)
 
+# Install test input data (YAML configs, hydro data, geometry) into tests/run_hydrochrono
+# The Python scripts expect test case folders (iea_sphere/, oswec/, rm3/, f3of/) to be siblings
+install(DIRECTORY ${PROJECT_SOURCE_DIR}/data/demos/run_hydrochrono/
+        DESTINATION tests/run_hydrochrono COMPONENT python-tests
+        PATTERN "__pycache__" EXCLUDE
+        PATTERN "*.pyc" EXCLUDE)
+
 # Simple runner script to execute tests from the installed tree
 install(PROGRAMS ${PROJECT_SOURCE_DIR}/scripts/RUN-TESTS.ps1
         DESTINATION tests COMPONENT python-tests)

build.ps1

@@ -744,12 +744,25 @@ function Package-Artifacts {
         }
         $hdf5Bin = Join-Path $hdf5Root "bin"
         if (Test-Path $hdf5Bin) {
+            Write-Info "Copying HDF5 DLLs from: $hdf5Bin"
+            $hdf5Count = 0
             Get-ChildItem -Path $hdf5Bin -Filter "*.dll" -ErrorAction SilentlyContinue | ForEach-Object {
                 $dest = Join-Path $installBin $_.Name
-                if (-not (Test-Path $dest)) {
-                    Copy-Item -Path $_.FullName -Destination $dest -Force -ErrorAction SilentlyContinue
-                }
+                Copy-Item -Path $_.FullName -Destination $dest -Force -ErrorAction SilentlyContinue
+                $hdf5Count++
             }
+            Write-Info "Copied $hdf5Count HDF5 DLL(s)"
+        } else {
+            Write-Warning "HDF5 bin directory not found: $hdf5Bin"
+        }
+        
+        # Copy Irrlicht DLL
+        $irrlichtDll = Join-Path $Config.IrrlichtDir "bin\Win64-VisualStudio\Irrlicht.dll"
+        if (Test-Path $irrlichtDll) {
+            Copy-Item -Path $irrlichtDll -Destination $installBin -Force -ErrorAction SilentlyContinue
+            Write-Info "Copied Irrlicht.dll"
+        } else {
+            Write-Warning "Irrlicht.dll not found at: $irrlichtDll"
         }
         # Also copy DLLs from this project's build bin (Release/Debug) into install\bin
         $hcDllSource = Join-Path (Get-Location) "bin\$BuildType"

scripts/RUN-TESTS.ps1

@@ -21,6 +21,11 @@ if (!(Test-Path $exe)) {
 $oldPath = $env:PATH
 $env:PATH = "$bin;$env:PATH"
 
+# Set data directory for the installed package
+# The executable has hardcoded build-time paths, so we override via environment
+$dataDir = Join-Path $installRoot "data"
+$env:HYDROCHRONO_DATA_DIR = $dataDir
+
 Push-Location $tests
 
 $reqs = @()

tests/regression/f3of/test_f3of_dt2.cpp

@@ -173,8 +173,6 @@ int main(int argc, char* argv[]) {
     }
 
     std::cout << "Start simulation" << std::endl;
-    std::cout << "  Integrator: " << system.GetTimestepper()->GetTypeAsString() << std::endl;
-    std::cout << "  Solver:     " << system.GetSolver()->GetTypeAsString() << std::endl;
     std::cout << "  Step size:  " << timestep << std::endl;
     std::cout << "  Duration:   " << simulationDuration << std::endl;
 

tests/regression/oswec/test_oswec_decay.cpp

@@ -202,8 +202,6 @@ int main(int argc, char* argv[]) {
     }
 
     std::cout << "Start simulation"<< std::endl;
-    std::cout << "  Integrator: " << system.GetTimestepper()->GetTypeAsString() << std::endl;
-    std::cout << "  Solver:     " << system.GetSolver()->GetTypeAsString() << std::endl;
     std::cout << "  Step size:  " << timestep << std::endl;
     std::cout << "  Duration:   " << simulationDuration << std::endl;