Centralise M_PI into hydroc/math_constants.h

M_PI was defined independently in multiple files. Consolidate into a single header that's shared.

Author: dav-og

include/hydroc/helper.h

@@ -11,11 +11,7 @@
 #include <Eigen/Dense>  // Need for the container function
 
 #include <hydroc/logging.h>
-
-//// RADU - why not use constants from Chrono?
-#ifndef M_PI
-    #define M_PI 3.14159265358979323846
-#endif
+#include <hydroc/math_constants.h>
 
 /**@brief Base namespace for HydroChrono library
  *

include/hydroc/math_constants.h

@@ -0,0 +1,20 @@
+/*********************************************************************
+ * @file  math_constants.h
+ * @brief Project-wide mathematical constants.
+ *
+ * Include this header instead of defining M_PI locally or relying on
+ * _USE_MATH_DEFINES.
+ *********************************************************************/
+
+#ifndef HYDROC_MATH_CONSTANTS_H
+#define HYDROC_MATH_CONSTANTS_H
+
+#ifndef M_PI
+#define M_PI 3.14159265358979323846
+#endif
+
+#ifndef M_PI_2
+#define M_PI_2 1.57079632679489661923
+#endif
+
+#endif  // HYDROC_MATH_CONSTANTS_H

src/gui/vsg_config.h

@@ -1,11 +1,9 @@
 // HydroChrono VSG Configuration Constants
 #pragma once
 
-#include <cmath>
+#include <hydroc/math_constants.h>
 
-#ifndef M_PI
-#define M_PI 3.14159265358979323846
-#endif
+#include <cmath>
 
 namespace hydroc {
 namespace gui {

src/hydro/waves/wave_utilities.cpp

@@ -3,11 +3,8 @@
  * @brief Helper routines shared by wave models.
  *********************************************************************/
 
-#ifndef _USE_MATH_DEFINES
-#define _USE_MATH_DEFINES
-#endif
-
 #include "wave_utilities.h"
+#include <hydroc/math_constants.h>
 
 #include <cmath>
 #include <algorithm>