Fix miscellaneous compilation warnings

Author: rserban

demos/oswec/demo_oswec_decay.cpp

@@ -41,7 +41,7 @@ std::array<double, 3> rotate_vector_3d(std::array<double, 3> vector,
                                        std::array<double, 3> axis,
                                        double angle_in_degrees) {
     // Convert the angle from degrees to radians
-    double angle_in_radians = angle_in_degrees * M_PI / 180.0;
+    double angle_in_radians = angle_in_degrees * CH_DEG_TO_RAD;
 
     // Normalize the axis vector
     axis = normalize(axis);

demos/oswec/demo_oswec_reg_waves.cpp

@@ -41,7 +41,7 @@ std::array<double, 3> rotate_vector_3d(std::array<double, 3> vector,
                                        std::array<double, 3> axis,
                                        double angle_in_degrees) {
     // Convert the angle from degrees to radians
-    double angle_in_radians = angle_in_degrees * M_PI / 180.0;
+    double angle_in_radians = angle_in_degrees * CH_DEG_TO_RAD;
 
     // Normalize the axis vector
     axis = normalize(axis);
@@ -64,7 +64,7 @@ std::array<double, 3> add_vectors(std::array<double, 3> v1, std::array<double, 3
 int main(int argc, char* argv[]) {
     std::vector<double> periods = {4.0,  6.0,  8.0,   10.0, 12.0, 14.0, 16.0, 18.0,
                                    18.5, 19.0, 19.25, 19.5, 20.0, 21.0, 22.0, 24.0};
-    int reg_wave_num_max        = periods.size();
+    int reg_wave_num_max        = (int)periods.size();
 
     for (int reg_wave_num = 1; reg_wave_num <= reg_wave_num_max; ++reg_wave_num) {
         std::cout << "Chrono version: " << CHRONO_VERSION << "\n\n";
@@ -111,9 +111,8 @@ int main(int argc, char* argv[]) {
         std::array<double, 3> origin_to_hinge = {0, 0, -8.9};
         std::array<double, 3> hinge_to_cg     = {0, 0, 5};
         std::array<double, 3> axis            = {0, 1, 0};
-        double angle_in_degrees               = 0.0;
 
-        // std::array<double, 3> rotated_hinge_to_cg = rotate_vector_3d(hinge_to_cg, axis, angle_in_degrees);
+        // std::array<double, 3> rotated_hinge_to_cg = rotate_vector_3d(hinge_to_cg, axis, 0);
 
         // std::array<double, 3> new_cg = add_vectors(origin_to_hinge, rotated_hinge_to_cg);
 
@@ -142,10 +141,9 @@ int main(int argc, char* argv[]) {
         // define the float's initial conditions
         system.Add(flap_body);
         flap_body->SetName("body1");
-        auto ang_rad = CH_PI / 18.0;
         // flap_body->SetPos(ChVector3d(new_cg[0], new_cg[1], new_cg[2]));
         flap_body->SetPos(ChVector3d(0.0, 0.0, -3.9));
-        // flap_body->SetRot(QuatFromAngleY(ang_rad));
+        // flap_body->SetRot(QuatFromAngleY(CH_PI / 18.0));
         flap_body->SetMass(127000.0);
         flap_body->SetInertiaXX(ChVector3d(1.85e6, 1.85e6, 1.85e6));
         // notes: mass and inertia added to added mass and system mass correctly.

demos/sphere/demo_sphere_irreg_waves.cpp

@@ -105,7 +105,7 @@ int main(int argc, char* argv[]) {
     bodies.push_back(sphereBody);
 
     IrregularWaveParams wave_inputs;
-    wave_inputs.num_bodies_          = bodies.size();
+    wave_inputs.num_bodies_          = (unsigned int)bodies.size();
     wave_inputs.simulation_dt_       = timestep;
     wave_inputs.simulation_duration_ = simulationDuration;
     wave_inputs.ramp_duration_       = 60.0;
@@ -153,7 +153,7 @@ int main(int argc, char* argv[]) {
     // Create a visualization material
     auto fse_texture = chrono_types::make_shared<ChVisualMaterial>();
     fse_texture->SetDiffuseColor(ChColor(0.026f, 0.084f, 0.168f));
-    fse_texture->SetOpacity(0.1);
+    fse_texture->SetOpacity(0.1f);
     fse_mesh->GetVisualShape(0)->SetMaterial(0, fse_texture);
 
     // for profiling

demos/sphere/demo_sphere_irreg_waves_eta_import.cpp

@@ -108,7 +108,7 @@ int main(int argc, char* argv[]) {
     std::cout << "Defining irregular wave input parameters..." << std::endl;
     IrregularWaveParams params;
     std::cout << "bodies.size() = " << bodies.size() << std::endl;
-    params.num_bodies_          = bodies.size();
+    params.num_bodies_          = (unsigned int)bodies.size();
     params.simulation_dt_       = timestep;
     params.simulation_duration_ = simulationDuration;
     params.ramp_duration_       = 0.0;

demos/sphere/demo_sphere_reg_waves.cpp

@@ -24,7 +24,7 @@ int main(int argc, char* argv[]) {
                                       0.897597901, 0.785398163, 0.698131701, 0.628318531, 0.571198664};
     double task10_damping_coeffs[] = {398736.034, 118149.758, 90080.857,  161048.558, 322292.419,
                                       479668.979, 633979.761, 784083.286, 932117.647, 1077123.445};
-    int reg_wave_num_max           = task10_wave_amps.size();
+    int reg_wave_num_max           = (int)task10_wave_amps.size();
 
     std::cout << "Num waves: " << reg_wave_num_max << std::endl;
 

src/hydro/config/setup_from_yaml.cpp

@@ -8,17 +8,17 @@
 
 #include "setup_from_yaml.h"
 #include "config_loader.h"
-#include <hydroc/hydro_system.h> // For HydroSystem
+#include <hydroc/hydro_system.h>
 #include <hydroc/waves/wave_base.h>
 #include <hydroc/waves/regular_wave.h>
 #include <hydroc/waves/irregular_wave.h>
-#include <hydroc/logging.h>         // For Logger
+#include <hydroc/logging.h>
 #include "../radiation/radiation_rirf_processing.h" // For TaperedDirectOptions (canonical type)
 #include "../force_components/radiation_component.h" // For RadiationConvolutionMode (canonical type)
 #include <filesystem>
 #include <iostream>
 #include <stdexcept>
-#include <cmath> // For M_PI
+#include <cmath>
 #include <unordered_map>
 
 #ifndef M_PI
@@ -49,14 +49,15 @@ std::shared_ptr<WaveBase> CreateWaveFromSettings(const WaveSettings& wave_settin
 
     if (type == "regular") {
         auto regular_wave = std::make_shared<RegularWave>(num_bodies);
-        
+
         // Set wave parameters
-        regular_wave->regular_wave_amplitude_ = wave_settings.height / 2.0;  // Convert height to amplitude
-        regular_wave->regular_wave_omega_ = 2.0 * M_PI / wave_settings.period;  // Convert period to angular frequency
-        regular_wave->regular_wave_phase_ = wave_settings.phase;
-        
-        hydroc::debug::LogDebug(std::string("Attached wave model: RegularWave, H=") + std::to_string(wave_settings.height) + 
-                            "m, T=" + std::to_string(wave_settings.period) + "s");
+        regular_wave->regular_wave_amplitude_ = wave_settings.height / 2;       // Convert height to amplitude
+        regular_wave->regular_wave_omega_     = CH_2PI / wave_settings.period;  // Convert period to angular frequency
+        regular_wave->regular_wave_phase_     = wave_settings.phase;
+
+        hydroc::debug::LogDebug(std::string("Attached wave model: RegularWave, H=") +
+                                std::to_string(wave_settings.height) + "m, T=" + std::to_string(wave_settings.period) +
+                                "s");
 
         return regular_wave;
 
@@ -163,7 +164,7 @@ std::unique_ptr<HydroSystem> SetupHydroFromYAML(
     }
 
     // Create wave object from settings (system-wide, not per-body)
-    auto wave = CreateWaveFromSettings(hydro_data.waves, matched_bodies.size(), 
+    auto wave = CreateWaveFromSettings(hydro_data.waves, (unsigned int) matched_bodies.size(), 
                                       timestep, sim_duration, ramp_duration);
 
     // Create and initialize HydroSystem (multibody: all matched bodies passed in)

src/hydro/force_components/radiation_component.cpp

@@ -84,7 +84,6 @@ double RadiationComponent::GetRIRFval(int row, int col, int st) {
     }
 
     int body_index = row / kDofPerBody;
-    int col_dof    = col % kDofPerBody;
     int row_dof    = row % kDofPerBody;
 
     if (convolution_mode_ == RadiationConvolutionMode::TaperedDirect) {

src/hydro/io/h5_reader.cpp

@@ -331,7 +331,7 @@ Eigen::VectorXd HydroData::GetRIRFTimeVector() const {
     // check if all time vectors are the same within tolerance
     auto& rirf_time_vector = body_data_[0].rirf_time_vector;
     for (size_t ii = 1; ii < body_data_.size(); ii++) {
-        for (size_t jj = 0; jj < body_data_[ii].rirf_time_vector.size(); jj++) {
+        for (Eigen::Index jj = 0; jj < body_data_[ii].rirf_time_vector.size(); jj++) {
             if (abs(body_data_[ii].rirf_time_vector[jj] - rirf_time_vector[jj]) > tol) {
                 throw std::runtime_error(
                     "RIRF time vectors have to be exactly the same for all bodies. Difference found in body " +

src/hydro/io/simulation_export.cpp

@@ -957,9 +957,9 @@ void SimulationExporter::Finalize() {
         }
     }
     // Final succinct info line in Quiet mode
-    int bodies = static_cast<int>(impl_->bodies.size());
-    int dampers = static_cast<int>(impl_->tsdas.size() + impl_->rsdas.size());
-    int samples = static_cast<int>(impl_->time.size());
+    ////int bodies = static_cast<int>(impl_->bodies.size());
+    ////int dampers = static_cast<int>(impl_->tsdas.size() + impl_->rsdas.size());
+    ////int samples = static_cast<int>(impl_->time.size());
     // meta/run runtime details (if provided via options)
     {
         auto g_run = impl_->writer.RequireGroup("/meta/run");

src/hydro/waves/irregular_wave.cpp

@@ -152,11 +152,11 @@ double IrregularWaves::GetElevation(const Eigen::Vector3d& position, double time
 Eigen::VectorXd IrregularWaves::GetForceAtTime(double t) {
     unsigned int total_dofs = params_.num_bodies_ * 6;
     Eigen::VectorXd f(total_dofs);
-    for (int i = 0; i < total_dofs; i++) {
+    for (unsigned int i = 0; i < total_dofs; i++) {
         f[i] = 0.0;
     }
 
-    for (int body = 0; body < params_.num_bodies_; body++) {
+    for (unsigned int body = 0; body < params_.num_bodies_; body++) {
         for (int dof = 0; dof < 6; ++dof) {
             double f_dof          = ExcitationConvolution(body, dof, t);
             unsigned int b_offset = body * 6;
@@ -281,7 +281,7 @@ void IrregularWaves::CreateFreeSurfaceElevation() {
 void IrregularWaves::ResampleIRF(double dt) {
     for (unsigned int b = 0; b < params_.num_bodies_; b++) {
         auto& time_array  = ex_irf_time_sampled_[b];
-        auto& width_array = ex_irf_width_sampled_[b];
+        ////auto& width_array = ex_irf_width_sampled_[b];
         auto& val_array   = ex_irf_sampled_[b];
 
         auto time_array_old = time_array;
@@ -331,12 +331,11 @@ double IrregularWaves::ExcitationConvolution(int body, int dof, double time) {
     } else if (t_tau >= tmax) {
         idx = static_cast<int>(free_surface_time_sampled_.size()) - 2;
     } else {
-        idx = get_lower_index(t_tau, free_surface_time_sampled_);
+        idx = (int)get_lower_index(t_tau, free_surface_time_sampled_);
     }
 
-    for (size_t j = 0; j < irf_time_array.size(); ++j) {
-        double tau   = irf_time_array[j];
-        double t_tau = time - tau;
+    for (Eigen::Index j = 0; j < irf_time_array.size(); ++j) {
+        t_tau = time - irf_time_array[j];
         if (tmin <= t_tau && t_tau <= tmax) {
             while (free_surface_time_sampled_[idx] > t_tau) {
                 idx -= 1;
@@ -357,8 +356,9 @@ double IrregularWaves::ExcitationConvolution(int body, int dof, double time) {
                 auto w2   = 1.0 - w1;
                 eta_val   = w1 * eta1 + w2 * eta2;
             } else {
-                throw std::runtime_error("Excitation convolution: wrong tau value " + std::to_string(tau) +
-                                         " not between " + std::to_string(t1) + " and " + std::to_string(t2) + ".");
+                throw std::runtime_error("Excitation convolution: wrong tau value " +
+                                         std::to_string(irf_time_array[j]) + " not between " + std::to_string(t1) +
+                                         " and " + std::to_string(t2) + ".");
             }
 
             f_ex += irf_val_mat(dof, j) * eta_val * irf_width_array[j];