Skip to content

Commit 5aeba2a

Browse files
committed
Correct documentation on ss method/theory in headers
1 parent a9a241f commit 5aeba2a

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/hydro/radiation/radiation_ss_fitter.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@
1616
* 3. Form discrete-time A, B, C, D matrices
1717
* 4. Convert discrete to continuous using bilinear (Tustin) transform
1818
* 5. Compute R² to assess fit quality
19-
* 6. Iterate on order until R² threshold is met or max_order is reached
19+
* 6. Try all orders up to max_order, keeping the best R²
20+
* (does not stop early -- higher orders can add fast-decaying poles
21+
* that improve initial transient accuracy)
2022
*
2123
* USAGE:
2224
* StateSpaceOptions opts;

src/hydro/radiation/radiation_ss_model.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,17 @@
44
*
55
* This class implements a state-space approximation of the radiation
66
* impulse response function (RIRF) supporting both:
7-
* - Pure exponential modes: K(t) = H * exp(-α * t)
7+
* - Pure exponential modes: K(t) = H * b * exp(-α*t)
88
* - Oscillatory modes: K(t) = exp(-α*t) * (H_c*cos(ω*t) + H_s*sin(ω*t))
9+
* (with b_c, b_s input gains folded into the response)
910
*
1011
* This enables O(1) per-timestep computation for any kernel, including those
1112
* with damped oscillations (complex conjugate poles), which are typical for
1213
* hydrodynamic radiation problems.
1314
*
1415
* THEORY:
1516
* Pure exponential mode (real eigenvalue λ = -α):
16-
* ż(t) = -α z(t) + v(t)
17+
* ż(t) = -α z(t) + b * v(t)
1718
* f_contribution = H * z
1819
*
1920
* Oscillatory mode (complex conjugate pair λ = -α ± jω):

0 commit comments

Comments
 (0)