chore: misc admin/profile UI improvements (Skeleton, UseQueryResult type, badge pagination, AdminStatsDisplay, developer seeder)

[coderabbitai]

A collection of smaller UI/DX TODOs:

File	Line	TODO
src/app/profile/components/connections/SocialConnectionList.tsx	33	Replace <LoadingSpinner> with a custom Skeleton component
src/app/profile/components/DeviceAndSocPreferences.tsx	17	Use UseQueryResult from @tanstack/react-query for the preferences query type
src/app/admin/users/components/UserBadgeModal.tsx	39	Evaluate whether pagination is needed for the badges query
src/app/admin/trust-logs/page.tsx	141	Check if AdminStatsDisplay can replace the inline TrustStatsOverview usage
prisma/seeders/usersSeeder.ts	39	Assign emulators to the Developer seed user
src/server/api/mobileContext.ts	288	Start enforcing API key usage once base rate limit is reached
src/server/utils/emulator-config/eden/eden.defaults.ts	169	Update RESOLUTION_MULTIPLIER_MAPPING with new Eden mappings (added 0.25x)
src/app/admin/performance/components/ReplacementSelectionModal.tsx	42	Implement performance scale replacement in backend

Action required:
Address each item in a follow-up PR.

---

Requested by @Producdevity — related to PR #375

[Producdevity]

@coderabbitai List the items/tasks that have not been completed yet in #426 and #431 or any other PR.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Fetch details of PR `#426`
echo "=== PR `#426` ==="
gh pr view 426 --repo Producdevity/EmuReady --json title,body,state,reviews,comments

echo ""
echo "=== PR `#431` ==="
gh pr view 431 --repo Producdevity/EmuReady --json title,body,state,reviews,comments

Length of output: 69371

---

🏁 Script executed:

#!/bin/bash
gh issue view 411 --repo Producdevity/EmuReady --json title,body,state,comments

Length of output: 2011

---

---

@Producdevity, here's what remains unresolved across #426, #431, and the original issue #411:

---

From issue #411 — not yet implemented

File	Task	Status
src/server/api/mobileContext.ts (line 288)	Enforce API key usage once base rate limit is reached	⏳ Intentionally deferred in #431 — flagged as needing a separate decision due to impact on public mobile API access
src/server/utils/emulator-config/eden/eden.defaults.ts (line 169)	Update RESOLUTION_MULTIPLIER_MAPPING with new 0.25x Eden mapping	⚠️ TODO comment removed as "stale" in #431 — unclear if the mapping itself is still needed or was intentionally dropped

---

Unresolved inline review comments (both PRs are now merged)

PR	File	Issue
#426	src/app/admin/cpus/page.tsx (line ~141–143)	Description prop still reads "Manage all CPU models for PC compatibility listings" — should be "PC Compatibility Report"
#431	src/server/repositories/performance-scales.repository.ts (line ~109–111)	AppError.badRequest(...) is called but not thrown, making the duplicate-ID guard ineffective — this is a functional bug

The performance-scales.repository.ts missing throw is the most impactful item. Would you like me to open a follow-up issue for any of these?

[Producdevity]

🧩 Analysis chain
🏁 Script executed:

#!/bin/bash

Fetch details of PR #426

echo "=== PR #426 ==="
gh pr view 426 --repo Producdevity/EmuReady --json title,body,state,reviews,comments

echo ""
echo "=== PR #431 ==="
gh pr view 431 --repo Producdevity/EmuReady --json title,body,state,reviews,comments
Length of output: 69371

🏁 Script executed:

#!/bin/bash
gh issue view 411 --repo Producdevity/EmuReady --json title,body,state,comments
Length of output: 2011

@Producdevity, here's what remains unresolved across #426, #431, and the original issue #411:

From issue #411 — not yet implemented

File Task Status
src/server/api/mobileContext.ts (line 288) Enforce API key usage once base rate limit is reached ⏳ Intentionally deferred in #431 — flagged as needing a separate decision due to impact on public mobile API access
src/server/utils/emulator-config/eden/eden.defaults.ts (line 169) Update RESOLUTION_MULTIPLIER_MAPPING with new 0.25x Eden mapping ⚠️ TODO comment removed as "stale" in #431 — unclear if the mapping itself is still needed or was intentionally dropped

Unresolved inline review comments (both PRs are now merged)

PR File Issue
#426 src/app/admin/cpus/page.tsx (line ~141–143) Description prop still reads "Manage all CPU models for PC compatibility listings" — should be "PC Compatibility Report"
#431 src/server/repositories/performance-scales.repository.ts (line ~109–111) AppError.badRequest(...) is called but not thrown, making the duplicate-ID guard ineffective — this is a functional bug
The performance-scales.repository.ts missing throw is the most impactful item. Would you like me to open a follow-up issue for any of these?

@coderabbitai make 2 PR's that fix the unresolved inline review comments. RESOLUTION_MULTIPLIER_MAPPING mapping is still needed, if that wasn't already present or isn't present right now create a new issue for that. for "Enforce API key usage once base rate limit is reached" there should be another issue if this doesn't already exist. once that is done this one can be closed.

[coderabbitai]

Coding Plan

Summary

• 5 of 8 TODO items are already fully implemented; verification confirms no changes needed
• UserBadgeModal pagination is unnecessary per established dropdown query patterns
• mobileContext rate limiting for anonymous requests is out of scope — recommend a separate ticket
• eden.defaults 0.25x mapping is correct given Eden's internal resolution enum constraints

Implementation Steps

Phase 1: Verify Already-Resolved Items

Confirm that 5 of the 8 TODO items are already fully implemented, requiring no code changes.

Task 1: Confirm SocialConnectionList Skeleton Usage

Verify that src/app/profile/components/connections/SocialConnectionList.tsx uses Skeleton (not LoadingSpinner).

• Review lines 1-40 to confirm Skeleton is imported from @/components/ui
• Confirm SocialConnectionListSkeleton renders Skeleton primitives for loading state
• No changes required — implementation already matches the ticket intent

Task 2: Confirm UseQueryResult Typing in DeviceAndSocPreferences

Verify that src/app/profile/components/DeviceAndSocPreferences.tsx correctly uses UseQueryResult.

• Confirm UseQueryResult is imported from @tanstack/react-query (line 3)
• Confirm preferencesQuery prop is typed as UseQueryResult<UserPreferencesData, unknown> (line 18)
• No changes required — typing already implemented correctly

Task 3: Confirm AdminStatsDisplay Usage in Trust Logs

Verify that src/app/admin/trust-logs/page.tsx uses AdminStatsDisplay (not TrustStatsOverview).

• Confirm page uses AdminStatsDisplay component at lines 143-162
• Confirm TrustStatsOverview does not exist in codebase
• No changes required — page already uses the generic stats component

Task 4: Confirm Developer Emulator Assignment in Seeder

Verify that prisma/seeders/usersSeeder.ts assigns emulators to the Developer user.

• Confirm assignDeveloperEmulators function exists (lines 110-158)
• Confirm it fetches all emulators and creates verifiedDeveloper records
• Confirm function is called in main seeder (line 234)
• No changes required — fully implemented with transaction-based upserts

Task 5: Confirm Performance Scale Replacement Backend

Verify that src/app/admin/performance/components/ReplacementSelectionModal.tsx has full backend support.

• Confirm performanceScales.delete mutation accepts { id, replacementId }
• Confirm repository method deleteByNumericIdWithReplacement handles listing migration
• No changes required — complete flow from modal through transactional DB update

🤖 Prompt for AI agents

This phase is verification-only — no code changes are required. Review the
following files to confirm existing implementations match the ticket intent:

- `src/app/profile/components/connections/SocialConnectionList.tsx` (lines
1-40): Confirm `Skeleton` is imported from `@/components/ui` and used in
`SocialConnectionListSkeleton`
- `src/app/profile/components/DeviceAndSocPreferences.tsx` (lines 3, 18):
Confirm `UseQueryResult` is imported from `@tanstack/react-query` and
`preferencesQuery` is typed as `UseQueryResult<UserPreferencesData, unknown>`
- `src/app/admin/trust-logs/page.tsx` (lines 143-162): Confirm
`AdminStatsDisplay` is used and `TrustStatsOverview` does not exist in the
codebase
- `prisma/seeders/usersSeeder.ts` (lines 110-158, 234): Confirm
`assignDeveloperEmulators` exists, fetches all emulators, creates
`verifiedDeveloper` records, and is called in the main seeder
- `src/app/admin/performance/components/ReplacementSelectionModal.tsx`: Confirm
`performanceScales.delete` mutation accepts `{ id, replacementId }` and
`deleteByNumericIdWithReplacement` handles listing migration

Phase 2: Evaluate and Address Remaining Items

Assess the 3 remaining TODO items and determine the appropriate action for each.

Task 1: Evaluate UserBadgeModal Pagination

Assess whether src/app/admin/users/components/UserBadgeModal.tsx needs pagination for badges.

• Review current implementation using limit: 100 for badge dropdown (lines 37-40)
• Compare with established pattern: dropdown/selector queries use high limits without pagination (e.g., socs.options uses limit: 1000)
• Decision: No pagination needed — 100 badges is well within reasonable limits for a select dropdown
• Optionally add a clarifying comment at the query site explaining the intentional high limit

Task 2: Assess Rate Limiting Scope for Mobile Context

Evaluate the rate limiting TODO in src/server/api/mobileContext.ts (line 288).

• Review current state: only API key requests are metered via ApiAccessService.consumeRequest
• The TODO references enforcing rate limits for unauthenticated/keyless requests
• This is a feature addition beyond misc cleanup scope — implementing IP-based rate limiting for anonymous requests requires:
  • IP extraction and storage mechanism
  • Rate limit configuration for anonymous tier
  • Redis or similar for distributed rate tracking
• Recommend: Create a separate ticket for the anonymous rate limiting feature; close this TODO item

Task 3: Verify Eden 0.25x Resolution Mapping

Review src/server/utils/emulator-config/eden/eden.defaults.ts RESOLUTION_MULTIPLIER_MAPPING.

• Confirm 0.25x and 0.25 keys exist in the mapping (line 169)
• Note: Both 0.25x and 0.5x map to ResolutionSetup = 0 — intentional because Eden's internal enum (0-10) doesn't distinguish sub-0.5x values
• Verify parseResolutionMultiplier fallback logic handles edge cases via if (multiplier <= 0.5) return 0
• No changes required unless Eden emulator adds distinct 0.25x support — add a clarifying comment if helpful

🤖 Prompt for AI agents

This phase evaluates 3 remaining TODO items and applies minimal changes where
appropriate.

**Task 1 — UserBadgeModal Pagination
(`src/app/admin/users/components/UserBadgeModal.tsx`):**
- Review the badge dropdown query at lines 37-40 (currently uses `limit: 100`)
- No pagination logic is needed; optionally add an inline comment explaining the
intentional high limit, consistent with patterns like `socs.options` using
`limit: 1000`

**Task 2 — Rate Limiting Scope (`src/server/api/mobileContext.ts`, line 288):**
- Review the TODO comment at line 288 referencing unauthenticated/keyless
request rate limiting
- No implementation required — this is out of scope for misc cleanup
- Remove or annotate the TODO comment to indicate a separate ticket should be
created for IP-based anonymous rate limiting

**Task 3 — Eden 0.25x Resolution Mapping
(`src/server/utils/emulator-config/eden/eden.defaults.ts`):**
- Confirm `0.25x` and `0.25` keys exist in `RESOLUTION_MULTIPLIER_MAPPING` at
line 169, both mapping to `ResolutionSetup = 0`
- Verify the `parseResolutionMultiplier` fallback: `if (multiplier <= 0.5)
return 0`
- No changes required; optionally add a clarifying comment noting that Eden's
internal enum (0-10) does not distinguish sub-0.5x values

Research

The codebase uses TanStack Query with tRPC for data fetching. Skeleton components from @/components/ui provide loading states. Admin pages use AdminStatsDisplay for stats grids with built-in loading. The usersSeeder.ts includes assignDeveloperEmulators which grants developer access to all emulators. Rate limiting in mobileContext.ts currently only tracks API key requests, with unauthenticated requests unmetered. Eden emulator config uses a ResolutionSetup type (0-10) mapping resolution multipliers.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

This phase is verification-only — no code changes are required. Review the
following files to confirm existing implementations match the ticket intent:

- `src/app/profile/components/connections/SocialConnectionList.tsx` (lines
1-40): Confirm `Skeleton` is imported from `@/components/ui` and used in
`SocialConnectionListSkeleton`
- `src/app/profile/components/DeviceAndSocPreferences.tsx` (lines 3, 18):
Confirm `UseQueryResult` is imported from `@tanstack/react-query` and
`preferencesQuery` is typed as `UseQueryResult<UserPreferencesData, unknown>`
- `src/app/admin/trust-logs/page.tsx` (lines 143-162): Confirm
`AdminStatsDisplay` is used and `TrustStatsOverview` does not exist in the
codebase
- `prisma/seeders/usersSeeder.ts` (lines 110-158, 234): Confirm
`assignDeveloperEmulators` exists, fetches all emulators, creates
`verifiedDeveloper` records, and is called in the main seeder
- `src/app/admin/performance/components/ReplacementSelectionModal.tsx`: Confirm
`performanceScales.delete` mutation accepts `{ id, replacementId }` and
`deleteByNumericIdWithReplacement` handles listing migration
===============================================================================

Task: 2

This phase evaluates 3 remaining TODO items and applies minimal changes where
appropriate.

**Task 1 — UserBadgeModal Pagination
(`src/app/admin/users/components/UserBadgeModal.tsx`):**
- Review the badge dropdown query at lines 37-40 (currently uses `limit: 100`)
- No pagination logic is needed; optionally add an inline comment explaining the
intentional high limit, consistent with patterns like `socs.options` using
`limit: 1000`

**Task 2 — Rate Limiting Scope (`src/server/api/mobileContext.ts`, line 288):**
- Review the TODO comment at line 288 referencing unauthenticated/keyless
request rate limiting
- No implementation required — this is out of scope for misc cleanup
- Remove or annotate the TODO comment to indicate a separate ticket should be
created for IP-based anonymous rate limiting

**Task 3 — Eden 0.25x Resolution Mapping
(`src/server/utils/emulator-config/eden/eden.defaults.ts`):**
- Confirm `0.25x` and `0.25` keys exist in `RESOLUTION_MULTIPLIER_MAPPING` at
line 169, both mapping to `ResolutionSetup = 0`
- Verify the `parseResolutionMultiplier` fallback: `if (multiplier <= 0.5)
return 0`
- No changes required; optionally add a clarifying comment noting that Eden's
internal enum (0-10) does not distinguish sub-0.5x values

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!