Skip to content

fix-pr-tooltip-contrast#710

Merged
Priyanshu-byte-coder merged 7 commits into
Priyanshu-byte-coder:mainfrom
tharunika-19:fix-pr-tooltip-contrast
May 23, 2026
Merged

fix-pr-tooltip-contrast#710
Priyanshu-byte-coder merged 7 commits into
Priyanshu-byte-coder:mainfrom
tharunika-19:fix-pr-tooltip-contrast

Conversation

@tharunika-19
Copy link
Copy Markdown
Contributor

Related Issue

Closes #605

Changes Made

  • Fixed tooltip text visibility in the PR Breakdown donut chart
  • Improved contrast for dark mode readability
  • Updated tooltip styling for better accessibility and UI consistency

Before

  • Tooltip text appeared dark on a dark background, making percentage values difficult to read

After

  • Tooltip text is clearly visible with improved contrast and readability in dark mode

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@tharunika-19 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels May 22, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues:

  1. Tooltip CSS vars broken: The tooltip was previously using getCSSVariable('--tooltip') and getCSSVariable('--tooltip-foreground') — the new code replaces these with hardcoded hex values (#111827, #374151, #ffffff). This breaks dark/light mode switching and our CSS variable system. Please restore the CSS var usage (or use getCSSVariable('--card') / getCSSVariable('--foreground') if --tooltip isn't defined).

  2. Scope: The custom /auth/signin page and auth.ts pages config are a separate feature from the tooltip contrast fix. If you want to add the custom signin page, please open a separate PR for it.

@tharunika-19
Copy link
Copy Markdown
Contributor Author

Hi @Priyanshu-byte-coder 👋

I’ve updated the PR by restoring the CSS variable usage and removing the unrelated auth changes.

I’m currently unable to fully verify the dashboard locally because the GitHub OAuth flow is not completing in my local environment, but the tooltip styling logic has been updated as requested and the hardcoded color values have been removed.

Please review the latest changes, and let me know if any further adjustments are needed. 🚀

Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip now uses getCSSVariable — thank you. One remaining blocker: the /auth/signin page and auth.ts pages: config change are still included in this PR. The previous review asked for these to be moved to a separate PR. Please remove them from this branch — the tooltip fix alone is ready to merge.

@tharunika-19
Copy link
Copy Markdown
Contributor Author

Thanks for the review @Priyanshu-byte-coder 👋
I’ve now removed the unrelated /auth/signin and auth.ts changes from this branch. The PR now only contains the tooltip contrast fix and CSS variable updates for proper theme support.

Please review the updated changes. 🚀

@Priyanshu-byte-coder Priyanshu-byte-coder added level:intermediate GSSoC: Intermediate difficulty (35 pts) gssoc:approved GSSoC: PR approved for scoring labels May 23, 2026
@Priyanshu-byte-coder Priyanshu-byte-coder merged commit c14cd6c into Priyanshu-byte-coder:main May 23, 2026
3 checks passed
@github-actions
Copy link
Copy Markdown

🎉 Merged! Thanks for contributing to DevTrack.

If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers.

Keep an eye on open issues for your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:intermediate GSSoC: Intermediate difficulty (35 pts) type:bug GSSoC type bonus: bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: PR Breakdown donut chart tooltip has black text on dark background

2 participants