fix-pr-tooltip-contrast#710
Conversation
|
@tharunika-19 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Two issues:
-
Tooltip CSS vars broken: The tooltip was previously using
getCSSVariable('--tooltip')andgetCSSVariable('--tooltip-foreground')— the new code replaces these with hardcoded hex values (#111827,#374151,#ffffff). This breaks dark/light mode switching and our CSS variable system. Please restore the CSS var usage (or usegetCSSVariable('--card')/getCSSVariable('--foreground')if --tooltip isn't defined). -
Scope: The custom
/auth/signinpage andauth.tspages config are a separate feature from the tooltip contrast fix. If you want to add the custom signin page, please open a separate PR for it.
|
I’ve updated the PR by restoring the CSS variable usage and removing the unrelated auth changes. I’m currently unable to fully verify the dashboard locally because the GitHub OAuth flow is not completing in my local environment, but the tooltip styling logic has been updated as requested and the hardcoded color values have been removed. Please review the latest changes, and let me know if any further adjustments are needed. 🚀 |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
The tooltip now uses getCSSVariable — thank you. One remaining blocker: the /auth/signin page and auth.ts pages: config change are still included in this PR. The previous review asked for these to be moved to a separate PR. Please remove them from this branch — the tooltip fix alone is ready to merge.
|
Thanks for the review @Priyanshu-byte-coder 👋 Please review the updated changes. 🚀 |
c14cd6c
into
Priyanshu-byte-coder:main
|
🎉 Merged! Thanks for contributing to DevTrack. If the project has been useful to you, a ⭐ star on the repo is the easiest way to support it — it helps DevTrack get discovered by more developers. Keep an eye on open issues for your next contribution! |
Related Issue
Closes #605
Changes Made
Before
After