Fix blank GitHub sign-in page UI and improve auth layout#705
Fix blank GitHub sign-in page UI and improve auth layout#705tharunika-19 wants to merge 8 commits into
Conversation
|
@tharunika-19 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Two issues:
- Missing EOF newline
- Hardcoded colors — the sign-in page uses hardcoded values:
bg-[#0b1120]→bg-[var(--background)]border-white/10,bg-white/5→border-[var(--border)],bg-[var(--card-muted)]text-white→text-[var(--foreground)]text-gray-400→text-[var(--muted-foreground)]bg-white text-black(GitHub button) — the GitHub sign-in button can keep a neutral style, but usebg-[var(--background)] text-[var(--foreground)]to respect theme
|
Thanks for the review! 🚀 I’ve updated the sign-in page to use theme variables instead of hardcoded colors, added the missing EOF newline, and improved the button hover interaction as well. |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
The /auth/signin/page.tsx now uses correct CSS vars — good. Blocker: PRBreakdownChart.tsx in this PR's diff still has hardcoded hex (backgroundColor: "#111827", border: "1px solid #374151", color: "#ffffff"). Replace with CSS vars: getCSSVariable('--card'), getCSSVariable('--border'), getCSSVariable('--foreground').
|
Hi @Priyanshu-byte-coder 👋
This should now properly support the existing dark/light mode system. 🚀 |
|
This PR has merge conflicts with current main. Please rebase on main to resolve before requesting review again. |
|
Subject: Fixed ESLint, TypeScript, and Build Errors - Ready for Review Thank you for your patience! I've successfully resolved all the build errors in the fix-pr-tooltip-contrast branch. Here's a summary of the changes made: Issues Fixed: Fixed all anchor tags in the Community and Contact sections Optimized images for better LCP and bandwidth usage Added missing sources: a.sources property to the merge callback Added missing cache endpoints: issues, discussions, coding-activity-insights, inactive-repos, streak_freeze ESLint: No warnings or errors Thank you again ! |

Related Issue
Closes #606
Changes Made
Before
After
Screenshots
Before :

After:
