Skip to content

handle errors on goal deletion and show user feedback #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Priyanshu-byte-coder merged 2 commits into from
May 24, 2026
+7 −26
Merged

handle errors on goal deletion and show user feedback #583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1711993
fix(ui): handle errors on goal deletion and show user feedback
mrdeyroy May 21, 2026
0f856b9
style: replace hardcoded red classes with css variables
mrdeyroy May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 7 additions & 26 deletions src/components/GoalTracker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,10 @@ export default function GoalTracker() {
if (!res.ok) {
setGoals(previousGoals);
setDeleteError("Failed to delete goal. Please try again.");
setTimeout(() => {
setDeleteError(null);
}, 5000);
}
} catch {
setGoals(previousGoals);
setDeleteError("Failed to delete goal. Please try again.");
setTimeout(() => {
setDeleteError(null);
}, 5000);
setDeleteError("Failed to delete goal. Please check your connection.");
} finally {
setDeletingId(null);
}
Expand Down Expand Up @@ -184,22 +178,9 @@ export default function GoalTracker() {
<h2 className="mb-4 text-lg font-semibold text-[var(--card-foreground)]">Weekly Goals</h2>

{deleteError && (
<div
role="alert"
className="mb-4 rounded-lg border border-[var(--destructive)]/30 bg-[var(--destructive)]/10 p-3 text-xs text-[var(--destructive)] flex items-center justify-between animate-in fade-in duration-200"
>
<div className="flex items-center gap-2">
<svg className="w-4 h-4 shrink-0" fill="none" stroke="currentColor" viewBox="0 0 24 24">
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M12 9v2m0 4h.01m-6.938 4h13.856c1.54 0 2.502-1.667 1.732-3L13.732 4c-.77-1.333-2.694-1.333-3.464 0L3.34 16c-.77 1.333.192 3 1.732 3z" />
</svg>
<span>{deleteError}</span>
</div>
<button
onClick={() => setDeleteError(null)}
className="text-[var(--destructive)] hover:opacity-80 font-semibold text-xs ml-2"
>
Dismiss
</button>
<div className="mb-4 rounded-lg border border-[var(--destructive)]/20 bg-[var(--destructive)]/10 p-3 text-sm text-[var(--destructive)] flex justify-between items-center">
<p>{deleteError}</p>
<button onClick={() => setDeleteError(null)} className="text-[var(--destructive)] hover:opacity-80 ml-2" aria-label="Dismiss error">✕</button>
</div>
)}

Expand Down Expand Up @@ -234,7 +215,7 @@ export default function GoalTracker() {
)}
</div>
{completed && (
<span className="text-xs font-medium text-[var(--success)]">
<span className="text-xs font-medium text-emerald-500">
{completionLabel}
</span>
)}
Expand Down Expand Up @@ -283,7 +264,7 @@ export default function GoalTracker() {
<button
onClick={() => handleDelete(goal.id)}
disabled={isDeleting}
className="text-[var(--destructive)] hover:text-[var(--destructive)] font-semibold transition-colors disabled:opacity-50"
className="text-[var(--destructive)] hover:opacity-80 font-semibold transition-colors disabled:opacity-50"
aria-label={`Confirm delete goal: ${goal.title}`}
>
Yes
Expand Down Expand Up @@ -315,7 +296,7 @@ export default function GoalTracker() {

<div className="h-2 overflow-hidden rounded-full bg-[var(--control)]">
<div
className={`h-full rounded-full transition-all ${completed ? "bg-[var(--success)]" : "bg-[var(--accent)]"}`}
className={`h-full rounded-full transition-all ${completed ? "bg-emerald-500" : "bg-[var(--accent)]"}`}
style={{ width: `${pct}%` }}
/>
</div>
Expand Down
Loading