From d0ff5870352b6ad09c5a6995c9d7d829b6a490d8 Mon Sep 17 00:00:00 2001 From: Avedis Date: Mon, 25 May 2026 18:36:56 +0300 Subject: [PATCH 1/3] Enhance BlocksDataGenerator to prioritize mineable material when multiple matches are found to fix problem of wrong dig time computation --- .../generators/BlocksDataGenerator.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mc/1.21.11/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.11/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index cc8b947b..80236a55 100644 --- a/mc/1.21.11/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.11/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { From 546c9effc1a060a46910e2dd0cdf91e8a612cd1d Mon Sep 17 00:00:00 2001 From: Avedis Date: Wed, 27 May 2026 21:05:44 +0300 Subject: [PATCH 2/3] Ported the changes from the previous commit to all versions that require this fix. --- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- .../generators/BlocksDataGenerator.java | 6 +++++- 8 files changed, 40 insertions(+), 8 deletions(-) diff --git a/mc/1.20.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.20.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 324b4d90..1de1bd52 100644 --- a/mc/1.20.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.20.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21.10/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.10/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 787fe432..7023cb49 100644 --- a/mc/1.21.10/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.10/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21.3/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.3/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 5e260d0e..dfb6a56e 100644 --- a/mc/1.21.3/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.3/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 787fe432..7023cb49 100644 --- a/mc/1.21.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.5/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21.6/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.6/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 787fe432..7023cb49 100644 --- a/mc/1.21.6/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.6/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21.7/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.7/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 787fe432..7023cb49 100644 --- a/mc/1.21.7/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.7/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21.8/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.8/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 787fe432..7023cb49 100644 --- a/mc/1.21.8/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.8/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { diff --git a/mc/1.21/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 324b4d90..1de1bd52 100644 --- a/mc/1.21/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) { From cd1141e5abef9fb2895f58edfa8928dc3629846f Mon Sep 17 00:00:00 2001 From: Avedis Date: Wed, 27 May 2026 21:33:23 +0300 Subject: [PATCH 3/3] Forgot to add 1.21.9 --- .../generators/BlocksDataGenerator.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mc/1.21.9/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java b/mc/1.21.9/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java index 787fe432..7023cb49 100644 --- a/mc/1.21.9/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java +++ b/mc/1.21.9/src/main/java/dev/u9g/minecraftdatagenerator/generators/BlocksDataGenerator.java @@ -115,7 +115,11 @@ private static String findMatchingBlockMaterial(BlockState blockState, List m.getMaterialName().startsWith("mineable/")) + .findFirst() + .map(MaterialsDataGenerator.MaterialInfo::getMaterialName) + .orElseGet(() -> matchingMaterials.getFirst().getMaterialName()); } public static JsonObject generateBlock(List materials, Block block) {