Fix placement validation and eliminate orphan bridge plans#37
Open
derekShaheen wants to merge 5 commits into
Open
Fix placement validation and eliminate orphan bridge plans#37derekShaheen wants to merge 5 commits into
derekShaheen wants to merge 5 commits into
Conversation
…rill placement logic for improved validation and commit handling across multiple drill types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem found where bridges and sometimes extractors would be placed on invalid tiles.
PR centralizes all placement checks into a single validation layer in
Util.javaand add a dry-run phase so plans are only submitted to the build queue after the full set is validated.Changes:
canPlaceBlock,canPlacePlan,canPlaceWithoutPlanCollision,footprintOverlapsPlanned,isWithinWorld, andcommitPlans. All callers now funnel through these instead of ad-hoc checks.mechanicalDrillwas reading"laser-drill-max-tiles").canPlaceWithoutPlanCollisionbefore a singlecommitPlanscall. Fixed potential infinite loop in connecting-tile traversal.Debug support:
Util.DEBUGflag logs rejection reasons (out of bounds, overlap, Build.validPlace failure) to the Mindustry console.Testing: