From 3e4345f67a0789b4e34c9648fa2eb2f67ef2c946 Mon Sep 17 00:00:00 2001 From: Sebastian Stehle Date: Wed, 26 Nov 2025 10:30:38 +0100 Subject: [PATCH 01/10] Dotnet 10 --- .github/workflows/dotnet-test.yml | 5 +- .github/workflows/release.yml | 5 + PhenX.EntityFrameworkCore.BulkInsert.sln | 92 ------------------- PhenX.EntityFrameworkCore.BulkInsert.slnx | 22 +++++ ...ntityFrameworkCore.BulkInsert.MySql.csproj | 1 + ...tityFrameworkCore.BulkInsert.Oracle.csproj | 1 + ...FrameworkCore.BulkInsert.PostgreSql.csproj | 1 + ...yFrameworkCore.BulkInsert.SqlServer.csproj | 1 + ...tityFrameworkCore.BulkInsert.Sqlite.csproj | 1 + ...henX.EntityFrameworkCore.BulkInsert.csproj | 1 + .../DbContext/TestSmartEnum.cs | 4 + 11 files changed, 40 insertions(+), 94 deletions(-) delete mode 100644 PhenX.EntityFrameworkCore.BulkInsert.sln create mode 100644 PhenX.EntityFrameworkCore.BulkInsert.slnx diff --git a/.github/workflows/dotnet-test.yml b/.github/workflows/dotnet-test.yml index 734923e..2505128 100644 --- a/.github/workflows/dotnet-test.yml +++ b/.github/workflows/dotnet-test.yml @@ -18,15 +18,16 @@ jobs: dotnet: [ { tfm: net8.0, version: 8.0.x }, { tfm: net9.0, version: 9.0.x }, + { tfm: net10.0, version: 10.0.x }, ] steps: - uses: actions/checkout@v4 - - name: Setup .NET 9.0 # Latest dotnet version supported + - name: Setup .NET 10.0 # Latest dotnet version supported uses: actions/setup-dotnet@v4 with: - dotnet-version: 9.0.x + dotnet-version: 10.0.x - name: Display dotnet version run: dotnet --version diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9372b13..2af571d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -35,6 +35,11 @@ jobs: with: dotnet-version: 9.0.x + - name: Setup .NET 10.0 + uses: actions/setup-dotnet@v4 + with: + dotnet-version: 10.0.x + - name: Restore dependencies run: dotnet restore diff --git a/PhenX.EntityFrameworkCore.BulkInsert.sln b/PhenX.EntityFrameworkCore.BulkInsert.sln deleted file mode 100644 index 37c50e6..0000000 --- a/PhenX.EntityFrameworkCore.BulkInsert.sln +++ /dev/null @@ -1,92 +0,0 @@ - -Microsoft Visual Studio Solution File, Format Version 12.00 -# Visual Studio Version 17 -VisualStudioVersion = 17.12.35707.178 d17.12 -MinimumVisualStudioVersion = 10.0.40219.1 -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert", "src\PhenX.EntityFrameworkCore.BulkInsert\PhenX.EntityFrameworkCore.BulkInsert.csproj", "{56CA0AE2-6EAB-4394-9E06-132558551251}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.PostgreSql", "src\PhenX.EntityFrameworkCore.BulkInsert.PostgreSql\PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj", "{F37308A8-1C3C-44D2-9440-670DF76A8C31}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.SqlServer", "src\PhenX.EntityFrameworkCore.BulkInsert.SqlServer\PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj", "{8098F37B-FA5E-4BDB-B64A-00FBDE2001C9}" -EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{CBEBA2A8-79E0-412E-93C1-C88F4473D78B}" - ProjectSection(SolutionItems) = preProject - src\Directory.Build.props = src\Directory.Build.props - EndProjectSection -EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{F8A83782-311C-454D-8B97-B3FB86478BF4}" - ProjectSection(SolutionItems) = preProject - tests\Directory.Build.props = tests\Directory.Build.props - EndProjectSection -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.Tests", "tests\PhenX.EntityFrameworkCore.BulkInsert.Tests\PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj", "{EDCCED5F-D456-45E2-81A6-1077977F042B}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.Benchmark", "tests\PhenX.EntityFrameworkCore.BulkInsert.Benchmark\PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj", "{E4EB1C53-575C-45F8-924A-93DC42E8ACCA}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.Sqlite", "src\PhenX.EntityFrameworkCore.BulkInsert.Sqlite\PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj", "{450E859C-411F-4D67-A0B4-4E02C3D30E14}" -EndProject -Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "root", "root", "{45366E91-4386-4DAC-9D09-226902EA6D9F}" - ProjectSection(SolutionItems) = preProject - .editorconfig = .editorconfig - .gitignore = .gitignore - LICENSE = LICENSE - README.md = README.md - EndProjectSection -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.MySql", "src\PhenX.EntityFrameworkCore.BulkInsert.MySql\PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj", "{17649766-EA68-4333-8DA8-47B014A8B2CC}" -EndProject -Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "PhenX.EntityFrameworkCore.BulkInsert.Oracle", "src\PhenX.EntityFrameworkCore.BulkInsert.Oracle\PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj", "{98CC5F0A-5739-4570-A384-A3A067D09755}" -EndProject -Global - GlobalSection(SolutionConfigurationPlatforms) = preSolution - Debug|Any CPU = Debug|Any CPU - Release|Any CPU = Release|Any CPU - EndGlobalSection - GlobalSection(ProjectConfigurationPlatforms) = postSolution - {56CA0AE2-6EAB-4394-9E06-132558551251}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {56CA0AE2-6EAB-4394-9E06-132558551251}.Debug|Any CPU.Build.0 = Debug|Any CPU - {56CA0AE2-6EAB-4394-9E06-132558551251}.Release|Any CPU.ActiveCfg = Release|Any CPU - {56CA0AE2-6EAB-4394-9E06-132558551251}.Release|Any CPU.Build.0 = Release|Any CPU - {F37308A8-1C3C-44D2-9440-670DF76A8C31}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {F37308A8-1C3C-44D2-9440-670DF76A8C31}.Debug|Any CPU.Build.0 = Debug|Any CPU - {F37308A8-1C3C-44D2-9440-670DF76A8C31}.Release|Any CPU.ActiveCfg = Release|Any CPU - {F37308A8-1C3C-44D2-9440-670DF76A8C31}.Release|Any CPU.Build.0 = Release|Any CPU - {8098F37B-FA5E-4BDB-B64A-00FBDE2001C9}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {8098F37B-FA5E-4BDB-B64A-00FBDE2001C9}.Debug|Any CPU.Build.0 = Debug|Any CPU - {8098F37B-FA5E-4BDB-B64A-00FBDE2001C9}.Release|Any CPU.ActiveCfg = Release|Any CPU - {8098F37B-FA5E-4BDB-B64A-00FBDE2001C9}.Release|Any CPU.Build.0 = Release|Any CPU - {EDCCED5F-D456-45E2-81A6-1077977F042B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {EDCCED5F-D456-45E2-81A6-1077977F042B}.Debug|Any CPU.Build.0 = Debug|Any CPU - {EDCCED5F-D456-45E2-81A6-1077977F042B}.Release|Any CPU.ActiveCfg = Release|Any CPU - {EDCCED5F-D456-45E2-81A6-1077977F042B}.Release|Any CPU.Build.0 = Release|Any CPU - {E4EB1C53-575C-45F8-924A-93DC42E8ACCA}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {E4EB1C53-575C-45F8-924A-93DC42E8ACCA}.Debug|Any CPU.Build.0 = Debug|Any CPU - {E4EB1C53-575C-45F8-924A-93DC42E8ACCA}.Release|Any CPU.ActiveCfg = Release|Any CPU - {E4EB1C53-575C-45F8-924A-93DC42E8ACCA}.Release|Any CPU.Build.0 = Release|Any CPU - {450E859C-411F-4D67-A0B4-4E02C3D30E14}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {450E859C-411F-4D67-A0B4-4E02C3D30E14}.Debug|Any CPU.Build.0 = Debug|Any CPU - {450E859C-411F-4D67-A0B4-4E02C3D30E14}.Release|Any CPU.ActiveCfg = Release|Any CPU - {450E859C-411F-4D67-A0B4-4E02C3D30E14}.Release|Any CPU.Build.0 = Release|Any CPU - {17649766-EA68-4333-8DA8-47B014A8B2CC}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {17649766-EA68-4333-8DA8-47B014A8B2CC}.Debug|Any CPU.Build.0 = Debug|Any CPU - {17649766-EA68-4333-8DA8-47B014A8B2CC}.Release|Any CPU.ActiveCfg = Release|Any CPU - {17649766-EA68-4333-8DA8-47B014A8B2CC}.Release|Any CPU.Build.0 = Release|Any CPU - {98CC5F0A-5739-4570-A384-A3A067D09755}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {98CC5F0A-5739-4570-A384-A3A067D09755}.Debug|Any CPU.Build.0 = Debug|Any CPU - {98CC5F0A-5739-4570-A384-A3A067D09755}.Release|Any CPU.ActiveCfg = Release|Any CPU - {98CC5F0A-5739-4570-A384-A3A067D09755}.Release|Any CPU.Build.0 = Release|Any CPU - EndGlobalSection - GlobalSection(SolutionProperties) = preSolution - HideSolutionNode = FALSE - EndGlobalSection - GlobalSection(NestedProjects) = preSolution - {56CA0AE2-6EAB-4394-9E06-132558551251} = {CBEBA2A8-79E0-412E-93C1-C88F4473D78B} - {F37308A8-1C3C-44D2-9440-670DF76A8C31} = {CBEBA2A8-79E0-412E-93C1-C88F4473D78B} - {8098F37B-FA5E-4BDB-B64A-00FBDE2001C9} = {CBEBA2A8-79E0-412E-93C1-C88F4473D78B} - {EDCCED5F-D456-45E2-81A6-1077977F042B} = {F8A83782-311C-454D-8B97-B3FB86478BF4} - {E4EB1C53-575C-45F8-924A-93DC42E8ACCA} = {F8A83782-311C-454D-8B97-B3FB86478BF4} - {450E859C-411F-4D67-A0B4-4E02C3D30E14} = {CBEBA2A8-79E0-412E-93C1-C88F4473D78B} - {17649766-EA68-4333-8DA8-47B014A8B2CC} = {CBEBA2A8-79E0-412E-93C1-C88F4473D78B} - {98CC5F0A-5739-4570-A384-A3A067D09755} = {CBEBA2A8-79E0-412E-93C1-C88F4473D78B} - EndGlobalSection -EndGlobal diff --git a/PhenX.EntityFrameworkCore.BulkInsert.slnx b/PhenX.EntityFrameworkCore.BulkInsert.slnx new file mode 100644 index 0000000..9c0aec8 --- /dev/null +++ b/PhenX.EntityFrameworkCore.BulkInsert.slnx @@ -0,0 +1,22 @@ + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj index 59cd250..b73cf4e 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj @@ -1,5 +1,6 @@  + net8.0;net9.0 $(NoWarn);NU5104 diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj index 0fe7376..dee67fe 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.Oracle/PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj @@ -7,6 +7,7 @@ + diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj index 2acabb3..b035d17 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj @@ -8,6 +8,7 @@ + diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj index 1d8e841..d9546af 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj @@ -9,6 +9,7 @@ + diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj index 110f0e2..07e54c5 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj @@ -7,6 +7,7 @@ + diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert/PhenX.EntityFrameworkCore.BulkInsert.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert/PhenX.EntityFrameworkCore.BulkInsert.csproj index 070d77a..ee389d9 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert/PhenX.EntityFrameworkCore.BulkInsert.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert/PhenX.EntityFrameworkCore.BulkInsert.csproj @@ -3,6 +3,7 @@ + diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs index 02aad51..4179316 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs @@ -8,5 +8,9 @@ private TestSmartEnum(string name, int value) : base(name, value) { } +#if NET10_OR_GREATER public static readonly TestSmartEnum Value = new TestSmartEnum("test", 1); +#else + public static readonly new TestSmartEnum Value = new TestSmartEnum("test", 1); +#endif } From 82780c9c5b7fcd22cbfc569b8ec1c9c1e9868b8e Mon Sep 17 00:00:00 2001 From: Sebastian Stehle Date: Wed, 26 Nov 2025 10:36:05 +0100 Subject: [PATCH 02/10] Another test for target framework. --- .../PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj index 9ffca17..973263c 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj @@ -1,9 +1,7 @@  - net8.0;net9.0 enable - false true From 016cca0d8daceb671b4035f2ded54f894a13de18 Mon Sep 17 00:00:00 2001 From: Sebastian Stehle Date: Wed, 26 Nov 2025 10:36:29 +0100 Subject: [PATCH 03/10] File was not saved --- src/Directory.Build.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 8ce036d..fef0276 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -1,7 +1,7 @@  - net8.0;net9.0 + net8.0;net9.0;net10.0 12 enable enable From b546aad323459c7590329d3b1b2a5d680f419a28 Mon Sep 17 00:00:00 2001 From: "fabien.menager" Date: Sat, 17 Jan 2026 11:39:18 +0100 Subject: [PATCH 04/10] Fix support for net 10, excluding MySQL and reorganize Directory.Build.props files --- Directory.Build.props | 33 +++++++++++++++++++ PhenX.EntityFrameworkCore.BulkInsert.slnx | 2 +- src/Directory.Build.props | 28 ++-------------- ...ntityFrameworkCore.BulkInsert.MySql.csproj | 3 +- tests/Directory.Build.props | 10 ------ ...yFrameworkCore.BulkInsert.Benchmark.csproj | 10 +++--- .../DbContext/TestSmartEnum.cs | 6 +--- ...ntityFrameworkCore.BulkInsert.Tests.csproj | 13 ++++++-- .../Tests/Basic/BasicTestsBase.cs | 5 +-- .../Tests/Various/VariousTestsBase.cs | 4 +-- 10 files changed, 61 insertions(+), 53 deletions(-) create mode 100644 Directory.Build.props delete mode 100644 tests/Directory.Build.props diff --git a/Directory.Build.props b/Directory.Build.props new file mode 100644 index 0000000..8b89490 --- /dev/null +++ b/Directory.Build.props @@ -0,0 +1,33 @@ + + + + net8.0;net9.0;net10.0 + 12 + enable + enable + en + true + + true + + + + Fabien Ménager + Super fast bulk insertion for Entity Framework Core on SQL Server, PostgreSQL and SQLite + Fabien Ménager © 2025 + https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert + https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert + git + MIT + sql sqlite postgresql entity-framework sqlbulkcopy efcore entity-framework-core sqlserver bulk-insert + README.md + icon.png + https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert/releases + + + + + true + false + + diff --git a/PhenX.EntityFrameworkCore.BulkInsert.slnx b/PhenX.EntityFrameworkCore.BulkInsert.slnx index 9c0aec8..4697239 100644 --- a/PhenX.EntityFrameworkCore.BulkInsert.slnx +++ b/PhenX.EntityFrameworkCore.BulkInsert.slnx @@ -2,6 +2,7 @@ + @@ -15,7 +16,6 @@ - diff --git a/src/Directory.Build.props b/src/Directory.Build.props index fef0276..ccf09ed 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -1,29 +1,7 @@  - - net8.0;net9.0;net10.0 - 12 - enable - enable - en - true - - true - - - - Fabien Ménager - Super fast bulk insertion for Entity Framework Core on SQL Server, PostgreSQL and SQLite - Fabien Ménager © 2025 - https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert - https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert - git - MIT - sql sqlite postgresql entity-framework sqlbulkcopy efcore entity-framework-core sqlserver bulk-insert - README.md - icon.png - https://github.com/PhenX/PhenX.EntityFrameworkCore.BulkInsert/releases - + + @@ -47,7 +25,7 @@ - + diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj index b73cf4e..04a8b01 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj @@ -1,6 +1,6 @@  - net8.0;net9.0 + net8.0;net9.0 $(NoWarn);NU5104 @@ -13,6 +13,7 @@ + diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props deleted file mode 100644 index f9f2c17..0000000 --- a/tests/Directory.Build.props +++ /dev/null @@ -1,10 +0,0 @@ - - - - net8.0;net9.0 - 12 - enable - enable - - - diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj index b359d6d..426e2bc 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj @@ -7,7 +7,7 @@ - + @@ -16,14 +16,14 @@ - - + + - - + + diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs index 4179316..4d3c4a8 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestSmartEnum.cs @@ -8,9 +8,5 @@ private TestSmartEnum(string name, int value) : base(name, value) { } -#if NET10_OR_GREATER - public static readonly TestSmartEnum Value = new TestSmartEnum("test", 1); -#else - public static readonly new TestSmartEnum Value = new TestSmartEnum("test", 1); -#endif + public static readonly TestSmartEnum Test = new TestSmartEnum("test", 1); } diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj index 973263c..27db913 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj @@ -1,7 +1,6 @@  - enable false true @@ -22,6 +21,10 @@ + + + + @@ -42,12 +45,18 @@ + + + + + + - + diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs index b09493c..b41e147 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs @@ -3,7 +3,6 @@ using PhenX.EntityFrameworkCore.BulkInsert.Enums; using PhenX.EntityFrameworkCore.BulkInsert.Extensions; -using PhenX.EntityFrameworkCore.BulkInsert.MySql; using PhenX.EntityFrameworkCore.BulkInsert.SqlServer; using PhenX.EntityFrameworkCore.BulkInsert.Tests.DbContainer; using PhenX.EntityFrameworkCore.BulkInsert.Tests.DbContext; @@ -277,13 +276,15 @@ public async Task ThrowsWhenUsingWrongConfigurationType() }; // Act & Assert +#if !NETCOREAPP1_0_OR_GREATER if (_context.IsProvider(ProviderType.SqlServer)) { await Assert.ThrowsAsync(async () => - await _context.ExecuteBulkInsertAsync(entities, (MySqlBulkInsertOptions _) => + await _context.ExecuteBulkInsertAsync(entities, (PhenX.EntityFrameworkCore.BulkInsert.MySql.MySqlBulkInsertOptions _) => { })); } +#endif if (_context.IsProvider(ProviderType.MySql)) { diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs index e3769f5..a5446fc 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Various/VariousTestsBase.cs @@ -31,8 +31,8 @@ public async Task InsertSmartEnumEntities(InsertStrategy strategy) // Arrange var entities = new List { - new TestEntityWithSmartEnum { TestRun = _run, Enum = TestSmartEnum.Value}, - new TestEntityWithSmartEnum { TestRun = _run, Enum = TestSmartEnum.Value} + new TestEntityWithSmartEnum { TestRun = _run, Enum = TestSmartEnum.Test}, + new TestEntityWithSmartEnum { TestRun = _run, Enum = TestSmartEnum.Test} }; // Act From cb538ea2c4b1a392706f9de44454a2eebd15077d Mon Sep 17 00:00:00 2001 From: "fabien.menager" Date: Sat, 17 Jan 2026 11:49:47 +0100 Subject: [PATCH 05/10] Setup all dotnet versions --- .github/workflows/dotnet-test.yml | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/dotnet-test.yml b/.github/workflows/dotnet-test.yml index 2505128..0482738 100644 --- a/.github/workflows/dotnet-test.yml +++ b/.github/workflows/dotnet-test.yml @@ -24,13 +24,20 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Setup .NET 10.0 # Latest dotnet version supported + - name: Setup .NET 8.0 uses: actions/setup-dotnet@v4 with: - dotnet-version: 10.0.x + dotnet-version: 8.0.x + + - name: Setup .NET 9.0 + uses: actions/setup-dotnet@v4 + with: + dotnet-version: 9.0.x - - name: Display dotnet version - run: dotnet --version + - name: Setup .NET 10.0 + uses: actions/setup-dotnet@v4 + with: + dotnet-version: 10.0.x - name: Restore dependencies run: dotnet restore From 2be93ce53544ae03eaee8225856d2ffb37569ff2 Mon Sep 17 00:00:00 2001 From: "fabien.menager" Date: Sat, 17 Jan 2026 11:52:29 +0100 Subject: [PATCH 06/10] Fix benchmark projet TFM --- .github/workflows/dotnet-test.yml | 15 ++++----------- ...ntityFrameworkCore.BulkInsert.Benchmark.csproj | 2 +- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/.github/workflows/dotnet-test.yml b/.github/workflows/dotnet-test.yml index 0482738..2505128 100644 --- a/.github/workflows/dotnet-test.yml +++ b/.github/workflows/dotnet-test.yml @@ -24,21 +24,14 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Setup .NET 8.0 - uses: actions/setup-dotnet@v4 - with: - dotnet-version: 8.0.x - - - name: Setup .NET 9.0 - uses: actions/setup-dotnet@v4 - with: - dotnet-version: 9.0.x - - - name: Setup .NET 10.0 + - name: Setup .NET 10.0 # Latest dotnet version supported uses: actions/setup-dotnet@v4 with: dotnet-version: 10.0.x + - name: Display dotnet version + run: dotnet --version + - name: Restore dependencies run: dotnet restore diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj index 426e2bc..844aacb 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj @@ -2,7 +2,7 @@ Exe - net9.0 + net9.0; false From d05477f443a84a154b873449800a85992bd85b10 Mon Sep 17 00:00:00 2001 From: "fabien.menager" Date: Sun, 18 Jan 2026 16:38:14 +0100 Subject: [PATCH 07/10] Bypass Mysql packages while Pomelo is not updated --- .github/workflows/release.yml | 3 +++ Directory.Build.props | 1 + PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf | 14 ++++++++++++++ ...enX.EntityFrameworkCore.BulkInsert.MySql.csproj | 3 +-- .../LibComparator.RawInsert.cs | 4 ++++ .../LibComparator.cs | 2 ++ ...EntityFrameworkCore.BulkInsert.Benchmark.csproj | 14 ++++++++++++-- .../Program.cs | 2 ++ ...enX.EntityFrameworkCore.BulkInsert.Tests.csproj | 8 ++++---- 9 files changed, 43 insertions(+), 8 deletions(-) create mode 100644 PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2b55a0c..56135ec 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -52,6 +52,9 @@ jobs: - name: Test net9.0 run: dotnet test --configuration Release --no-restore --no-build --verbosity normal --framework net9.0 + - name: Test net10.0 + run: dotnet test --configuration Release --no-restore --no-build --verbosity normal --framework net10.0 + - name: Pack nuget packages run: dotnet pack --configuration Release --no-restore --no-build --output nupkgs /p:PackageVersion=$VERSION diff --git a/Directory.Build.props b/Directory.Build.props index 8b89490..53ba4a5 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -29,5 +29,6 @@ true false + $(Constants);MYSQL_SUPPORTED diff --git a/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf b/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf new file mode 100644 index 0000000..213f679 --- /dev/null +++ b/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf @@ -0,0 +1,14 @@ +{ + "solution": { + "path": "PhenX.EntityFrameworkCore.BulkInsert.slnx", + "projects": [ + "src\\PhenX.EntityFrameworkCore.BulkInsert.Oracle\\PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj", + "src\\PhenX.EntityFrameworkCore.BulkInsert.PostgreSql\\PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj", + "src\\PhenX.EntityFrameworkCore.BulkInsert.Sqlite\\PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj", + "src\\PhenX.EntityFrameworkCore.BulkInsert.SqlServer\\PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj", + "src\\PhenX.EntityFrameworkCore.BulkInsert\\PhenX.EntityFrameworkCore.BulkInsert.csproj", + "tests\\PhenX.EntityFrameworkCore.BulkInsert.Benchmark\\PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj", + "tests\\PhenX.EntityFrameworkCore.BulkInsert.Tests\\PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj" + ] + } +} \ No newline at end of file diff --git a/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj b/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj index 04a8b01..bd38897 100644 --- a/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj +++ b/src/PhenX.EntityFrameworkCore.BulkInsert.MySql/PhenX.EntityFrameworkCore.BulkInsert.MySql.csproj @@ -1,8 +1,7 @@  + net8.0;net9.0 - - $(NoWarn);NU5104 diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.RawInsert.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.RawInsert.cs index 79d045e..3c87895 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.RawInsert.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.RawInsert.cs @@ -4,7 +4,9 @@ using Microsoft.Data.Sqlite; using Microsoft.EntityFrameworkCore; +#if MYSQL_SUPPORTED using MySqlConnector; +#endif using Npgsql; @@ -144,6 +146,7 @@ private void RawInsertSqlServer() } } +#if MYSQL_SUPPORTED private void RawInsertMySql() { var connection = (MySqlConnection)DbContext.Database.GetDbConnection(); @@ -196,6 +199,7 @@ private void RawInsertMySql() bulkCopy.WriteToServer(dataTable); } } +#endif private void RawInsertOracle() { diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs index ccc76a0..3d11126 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs @@ -85,11 +85,13 @@ public void RawInsert() // Use BeginBinaryImport for PostgreSQL RawInsertPostgreSql(); } +#if MYSQL_SUPPORTED else if (DbContext.Database.ProviderName!.Contains("MySql", StringComparison.InvariantCultureIgnoreCase)) { // Use MySqlBulkCopy for PostgreSQL RawInsertMySql(); } +#endif else if (DbContext.Database.ProviderName!.Contains("Oracle", StringComparison.InvariantCultureIgnoreCase)) { // Use OracleBulkCopy for Oracle diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj index 844aacb..c753e41 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj @@ -2,8 +2,8 @@ Exe - net9.0; false + false @@ -26,8 +26,18 @@ + + + + + + + + + + - + diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/Program.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/Program.cs index 625a58b..c178e81 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/Program.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/Program.cs @@ -19,7 +19,9 @@ public static void Main(string[] args) // Library comparison benchmarks var comparators = new[] { +#if MYSQL_SUPPORTED typeof(LibComparatorMySql), +#endif typeof(LibComparatorPostgreSql), typeof(LibComparatorSqlite), typeof(LibComparatorSqlServer), diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj index 27db913..76d709a 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj @@ -21,10 +21,6 @@ - - - - @@ -55,6 +51,10 @@ + + + + From 172a2afb09c04d7c48a6eabf7cb5d422034c9b01 Mon Sep 17 00:00:00 2001 From: "fabien.menager" Date: Sat, 7 Feb 2026 11:37:50 +0100 Subject: [PATCH 08/10] New net 10 solution file and adapt workflows --- .github/workflows/dotnet-test.yml | 4 ++-- .github/workflows/release.yml | 14 ++++--------- ....EntityFrameworkCore.BulkInsert.Net10.slnf | 14 ------------- ....EntityFrameworkCore.BulkInsert.Net10.slnx | 21 +++++++++++++++++++ 4 files changed, 27 insertions(+), 26 deletions(-) delete mode 100644 PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf create mode 100644 PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx diff --git a/.github/workflows/dotnet-test.yml b/.github/workflows/dotnet-test.yml index 2505128..f3d8206 100644 --- a/.github/workflows/dotnet-test.yml +++ b/.github/workflows/dotnet-test.yml @@ -36,7 +36,7 @@ jobs: run: dotnet restore - name: Build - run: dotnet build --no-restore --framework ${{ matrix.dotnet.tfm }} + run: dotnet build PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --no-restore --framework ${{ matrix.dotnet.tfm }} - name: Test - run: dotnet test --no-build --verbosity normal --framework ${{ matrix.dotnet.tfm }} + run: dotnet test PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --no-build --verbosity normal --framework ${{ matrix.dotnet.tfm }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 56135ec..0afc6e0 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,23 +40,17 @@ jobs: with: dotnet-version: 10.0.x - - name: Restore dependencies - run: dotnet restore - - - name: Build - run: dotnet build --configuration Release --no-restore /p:Version=$VERSION - - name: Test net8.0 - run: dotnet test --configuration Release --no-restore --no-build --verbosity normal --framework net8.0 + run: dotnet test PhenX.EntityFrameworkCore.BulkInsert.slnx --configuration Release --verbosity normal --framework net8.0 - name: Test net9.0 - run: dotnet test --configuration Release --no-restore --no-build --verbosity normal --framework net9.0 + run: dotnet test PhenX.EntityFrameworkCore.BulkInsert.slnx --configuration Release --verbosity normal --framework net9.0 - name: Test net10.0 - run: dotnet test --configuration Release --no-restore --no-build --verbosity normal --framework net10.0 + run: dotnet test PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --configuration Release --verbosity normal --framework net10.0 - name: Pack nuget packages - run: dotnet pack --configuration Release --no-restore --no-build --output nupkgs /p:PackageVersion=$VERSION + run: dotnet pack PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --configuration Release --no-build --output nupkgs /p:PackageVersion=$VERSION - name: Upload nuget package if: github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/v') diff --git a/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf b/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf deleted file mode 100644 index 213f679..0000000 --- a/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnf +++ /dev/null @@ -1,14 +0,0 @@ -{ - "solution": { - "path": "PhenX.EntityFrameworkCore.BulkInsert.slnx", - "projects": [ - "src\\PhenX.EntityFrameworkCore.BulkInsert.Oracle\\PhenX.EntityFrameworkCore.BulkInsert.Oracle.csproj", - "src\\PhenX.EntityFrameworkCore.BulkInsert.PostgreSql\\PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj", - "src\\PhenX.EntityFrameworkCore.BulkInsert.Sqlite\\PhenX.EntityFrameworkCore.BulkInsert.Sqlite.csproj", - "src\\PhenX.EntityFrameworkCore.BulkInsert.SqlServer\\PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj", - "src\\PhenX.EntityFrameworkCore.BulkInsert\\PhenX.EntityFrameworkCore.BulkInsert.csproj", - "tests\\PhenX.EntityFrameworkCore.BulkInsert.Benchmark\\PhenX.EntityFrameworkCore.BulkInsert.Benchmark.csproj", - "tests\\PhenX.EntityFrameworkCore.BulkInsert.Tests\\PhenX.EntityFrameworkCore.BulkInsert.Tests.csproj" - ] - } -} \ No newline at end of file diff --git a/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx b/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx new file mode 100644 index 0000000..b4f043f --- /dev/null +++ b/PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx @@ -0,0 +1,21 @@ + + + + + + + + + + + + + + + + + + + + + From cade6c4eec36efdedf5980669158f6b361b47ddf Mon Sep 17 00:00:00 2001 From: "fabien.menager" Date: Sat, 7 Feb 2026 11:39:27 +0100 Subject: [PATCH 09/10] Remove redundant restore step from dotnet-test.yml --- .github/workflows/dotnet-test.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/dotnet-test.yml b/.github/workflows/dotnet-test.yml index f3d8206..5566d1c 100644 --- a/.github/workflows/dotnet-test.yml +++ b/.github/workflows/dotnet-test.yml @@ -32,11 +32,8 @@ jobs: - name: Display dotnet version run: dotnet --version - - name: Restore dependencies - run: dotnet restore - - name: Build - run: dotnet build PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --no-restore --framework ${{ matrix.dotnet.tfm }} + run: dotnet build PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --framework ${{ matrix.dotnet.tfm }} - name: Test run: dotnet test PhenX.EntityFrameworkCore.BulkInsert.Net10.slnx --no-build --verbosity normal --framework ${{ matrix.dotnet.tfm }} From 022509837e1f2c4a8ef5eb114e4b047e43449b9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabien=20M=C3=A9nager?= Date: Sat, 7 Feb 2026 13:19:08 +0100 Subject: [PATCH 10/10] Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- Directory.Build.props | 2 +- src/Directory.Build.props | 2 +- .../LibComparator.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Directory.Build.props b/Directory.Build.props index 53ba4a5..bf41523 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -29,6 +29,6 @@ true false - $(Constants);MYSQL_SUPPORTED + $(DefineConstants);MYSQL_SUPPORTED diff --git a/src/Directory.Build.props b/src/Directory.Build.props index ccf09ed..fd6c253 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -1,7 +1,7 @@  - + diff --git a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs index 3d11126..178f3ea 100644 --- a/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs +++ b/tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs @@ -88,7 +88,7 @@ public void RawInsert() #if MYSQL_SUPPORTED else if (DbContext.Database.ProviderName!.Contains("MySql", StringComparison.InvariantCultureIgnoreCase)) { - // Use MySqlBulkCopy for PostgreSQL + // Use MySqlBulkCopy for MySQL RawInsertMySql(); } #endif