Fix.

Author: SebastianStehle

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs

@@ -22,7 +22,7 @@ public SqlServerBulkInsertProvider(ILogger<SqlServerBulkInsertProvider>? logger
 
     //language=sql
     /// <inheritdoc />
-    protected override string AddTableCopyBulkInsertId => $"ALTER TABLE {{0}} ADD {BulkInsertId} INT IDENTITY PRIMARY KEY;";
+    protected override string AddTableCopyBulkInsertId => $"ALTER TABLE {{0}} ADD {BulkInsertId} INT;";
 
     /// <inheritdoc />
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";
@@ -48,7 +48,7 @@ CancellationToken ctk
 
         foreach (var prop in properties)
         {
-            bulkCopy.ColumnMappings.Add(prop.Name, SqlDialect.Quote(prop.ColumnName));
+            bulkCopy.ColumnMappings.Add(prop.Name, prop.ColumnName);
         }
 
         if (sync)

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerDialectBuilder.cs

@@ -31,6 +31,11 @@ public override string BuildMoveDataSql<T>(DbContext context, string source,
 
         var q = new StringBuilder();
 
+        if (options.CopyGeneratedColumns)
+        {
+            q.AppendLine($"SET IDENTITY_INSERT {target} ON;");
+        }
+
         // Merge handling
         if (onConflict is OnConflictOptions<T> onConflictTyped && onConflictTyped.Match != null)
         {
@@ -79,6 +84,11 @@ public override string BuildMoveDataSql<T>(DbContext context, string source,
 
         q.AppendLine(";");
 
+        if (options.CopyGeneratedColumns)
+        {
+            q.AppendLine($"SET IDENTITY_INSERT {target} OFF;");
+        }
+
         return q.ToString();
     }
 

src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs

@@ -31,13 +31,14 @@ protected BulkInsertProviderBase(ILogger<BulkInsertProviderBase<TDialect>>? logg
     protected async Task<string> CreateTableCopyAsync<T>(
         bool sync,
         DbContext context,
+        BulkInsertOptions options,
         CancellationToken cancellationToken = default) where T : class
     {
         var tableInfo = GetTableInfo(context, typeof(T));
         var tableName = QuoteTableName(tableInfo.SchemaName, tableInfo.TableName);
         var tempTableName = QuoteTableName(null, GetTempTableName(tableInfo.TableName));
 
-        var keptColumns = string.Join(", ", GetQuotedColumns(context, typeof(T), false));
+        var keptColumns = string.Join(", ", GetQuotedColumns(context, typeof(T), options.CopyGeneratedColumns));
         var query = string.Format(CreateTableCopySql, tempTableName, tableName, keptColumns);
 
         await ExecuteAsync(sync, context, query, cancellationToken);
@@ -234,7 +235,7 @@ public async Task BulkInsert<T>(
         var (connection, wasClosed, transaction, wasBegan) = await context.GetConnection(sync, ctk);
 
         var tableName = tempTableRequired
-            ? await CreateTableCopyAsync<T>(sync, context, ctk)
+            ? await CreateTableCopyAsync<T>(sync, context, options, ctk)
             : GetQuotedTableName(context, typeof(T));
 
         var properties = context

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs

@@ -116,6 +116,7 @@ public void InsertsEntitiesAndReturn_Sync()
     public async Task InsertsEntities_MultipleTimes()
     {
         Skip.If(_context.Database.ProviderName!.Contains("Postgres", StringComparison.InvariantCultureIgnoreCase));
+        Skip.If(_context.Database.ProviderName!.Contains("SqlServer", StringComparison.InvariantCultureIgnoreCase));
 
         // Arrange
         var entities = new List<TestEntity>
@@ -149,6 +150,7 @@ await _context.ExecuteBulkInsertAsync(entities,
     public async Task InsertsEntities_MultipleTimes_With_Conflict_On_Id()
     {
         Skip.If(_context.Database.ProviderName!.Contains("Postgres", StringComparison.InvariantCultureIgnoreCase));
+        Skip.If(_context.Database.ProviderName!.Contains("SqlServer", StringComparison.InvariantCultureIgnoreCase));
 
         // Arrange
         var entities = new List<TestEntity>