Rename and code smell

Author: fabien.menager

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlDbContextOptionsExtensions.cs

@@ -11,7 +11,7 @@ public static class PostgreSqlDbContextOptionsExtensions
     /// <summary>
     /// Configures the DbContext to use the PostgreSQL bulk insert provider.
     /// </summary>
-    public static DbContextOptionsBuilder UseExecuteInsertPostgres(this DbContextOptionsBuilder optionsBuilder)
+    public static DbContextOptionsBuilder UseExecuteInsertPostgreSql(this DbContextOptionsBuilder optionsBuilder)
     {
         var extension = optionsBuilder.Options.FindExtension<ExecuteInsertOptionsExtension<PostgreSqlBulkInsertProvider>>() ?? new ExecuteInsertOptionsExtension<PostgreSqlBulkInsertProvider>();
 

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs

@@ -38,10 +38,10 @@ protected override async Task BulkInsert<T>(
         CancellationToken ctk
     )
     {
-        var connection = context.Database.GetDbConnection();
+        var connection = (SqlConnection) context.Database.GetDbConnection();
         var sqlTransaction = context.Database.CurrentTransaction!.GetDbTransaction() as SqlTransaction;
 
-        using var bulkCopy = new SqlBulkCopy(connection as SqlConnection, SqlBulkCopyOptions.TableLock, sqlTransaction);
+        using var bulkCopy = new SqlBulkCopy(connection, SqlBulkCopyOptions.TableLock, sqlTransaction);
         bulkCopy.DestinationTableName = tableName;
         bulkCopy.BatchSize = options.BatchSize ?? 50_000;
         bulkCopy.BulkCopyTimeout = 60;

tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparatorPostgreSql.cs

@@ -22,7 +22,7 @@ protected override void ConfigureDbContext()
 
         DbContext = new TestDbContext(p => p
             .UseNpgsql(connectionString)
-            .UseExecuteInsertPostgres()
+            .UseExecuteInsertPostgreSql()
         );
     }
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainer.cs

@@ -1,6 +1,4 @@
-using System.Threading.Tasks;
-
-using DotNet.Testcontainers.Containers;
+using DotNet.Testcontainers.Containers;
 
 using Microsoft.EntityFrameworkCore;
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainerPostgreSql.cs

@@ -25,6 +25,6 @@ protected override void Configure(DbContextOptionsBuilder optionsBuilder)
     {
         optionsBuilder
             .UseNpgsql()
-            .UseExecuteInsertPostgres();
+            .UseExecuteInsertPostgreSql();
     }
 }

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainerSqlite.cs

@@ -1,6 +1,4 @@
-using System;
-
-using DotNet.Testcontainers.Containers;
+using DotNet.Testcontainers.Containers;
 
 using Microsoft.EntityFrameworkCore;
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestDbContextBase.cs

@@ -1,6 +1,4 @@
-using System;
-
-using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore;
 
 namespace PhenX.EntityFrameworkCore.BulkInsert.Tests.DbContext;
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestEntity.cs

@@ -1,5 +1,4 @@
-using System;
-using System.ComponentModel.DataAnnotations;
+using System.ComponentModel.DataAnnotations;
 using System.ComponentModel.DataAnnotations.Schema;
 
 using Microsoft.EntityFrameworkCore;

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs

@@ -1,9 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Threading.Tasks;
-
-using PhenX.EntityFrameworkCore.BulkInsert.Extensions;
+using PhenX.EntityFrameworkCore.BulkInsert.Extensions;
 using PhenX.EntityFrameworkCore.BulkInsert.Options;
 using PhenX.EntityFrameworkCore.BulkInsert.Tests.DbContainer;
 using PhenX.EntityFrameworkCore.BulkInsert.Tests.DbContext;