Optimize navigation getters

Author: fabien.menager

src/PhenX.EntityFrameworkCore.BulkInsert/Graph/GraphEntityCollector.cs

@@ -94,13 +94,7 @@ private void CollectEntity(object? entity, int depth)
 
         foreach (var navigation in navigations)
         {
-            var propertyInfo = entityType.GetProperty(navigation.PropertyName, BindingFlags.Public | BindingFlags.Instance);
-            if (propertyInfo == null)
-            {
-                continue;
-            }
-
-            var value = propertyInfo.GetValue(entity);
+            var value = navigation.GetValue(entity);
             if (value == null)
             {
                 continue;

src/PhenX.EntityFrameworkCore.BulkInsert/Metadata/NavigationMetadata.cs

@@ -1,3 +1,5 @@
+using System.Reflection;
+
 using Microsoft.EntityFrameworkCore.Metadata;
 
 namespace PhenX.EntityFrameworkCore.BulkInsert.Metadata;
@@ -14,6 +16,14 @@ public NavigationMetadata(INavigationBase navigation)
         TargetType = navigation.TargetEntityType.ClrType;
         IsCollection = navigation.IsCollection;
 
+        // Build optimized getter for the navigation property
+        var propertyInfo = navigation.DeclaringEntityType.ClrType.GetProperty(
+            navigation.Name,
+            BindingFlags.Public | BindingFlags.Instance)
+            ?? throw new InvalidOperationException($"Property '{navigation.Name}' not found on type '{navigation.DeclaringEntityType.ClrType.Name}'");
+
+        _getter = PropertyAccessor.CreateGetter(propertyInfo);
+
         if (navigation is ISkipNavigation skipNavigation)
         {
             IsManyToMany = true;
@@ -29,6 +39,8 @@ public NavigationMetadata(INavigationBase navigation)
         }
     }
 
+    private readonly Func<object, object?> _getter;
+
     /// <summary>
     /// The underlying EF Core navigation.
     /// </summary>
@@ -75,30 +87,9 @@ public NavigationMetadata(INavigationBase navigation)
     public bool IsDependentToPrincipal { get; }
 
     /// <summary>
-    /// Gets the FK property names on the source entity (for dependent-to-principal navigations).
+    /// Gets the value of the navigation property from the entity using an optimized getter.
     /// </summary>
-    public IReadOnlyList<string> GetForeignKeyPropertyNames()
-    {
-        if (ForeignKey == null)
-        {
-            return [];
-        }
-
-        return ForeignKey.Properties.Select(p => p.Name).ToList();
-    }
-
-    /// <summary>
-    /// Gets the principal key property names.
-    /// </summary>
-    public IReadOnlyList<string> GetPrincipalKeyPropertyNames()
-    {
-        if (ForeignKey == null)
-        {
-            return [];
-        }
-
-        return ForeignKey.PrincipalKey.Properties.Select(p => p.Name).ToList();
-    }
+    public object? GetValue(object entity) => _getter.Invoke(entity);
 
     public override string ToString()
     {