Dispose transaction.

Author: SebastianStehle

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs

@@ -25,6 +25,18 @@ public MySqlBulkInsertProvider(ILogger<MySqlBulkInsertProvider>? logger = null)
     /// <inheritdoc />
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";
 
+    /// <inheritdoc />
+    public override Task<List<T>> BulkInsertReturnEntities<T>(
+        bool sync,
+        DbContext context,
+        IEnumerable<T> entities,
+        BulkInsertOptions options,
+        OnConflictOptions? onConflict = null,
+        CancellationToken ctk = default)
+    {
+        throw new NotSupportedException("Provider does not support returning entities.");
+    }
+
     /// <inheritdoc />
     protected override async Task BulkInsert<T>(
         bool sync,

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlDialectBuilder.cs

@@ -16,8 +16,6 @@ internal class MySqlServerDialectBuilder : SqlDialectBuilder
 
     protected override bool SupportsMoveRows => false;
 
-    public override bool SupportsReturning => false;
-
     protected override void AppendConflictCondition<T>(StringBuilder sql, OnConflictOptions<T> onConflictTyped)
     {
         throw new NotSupportedException("Conflict conditions are not supported in MYSQL");

src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs

@@ -112,11 +112,6 @@ private async Task<List<TResult>> CopyFromTempTableWithoutKeysAsync<T, TResult>(
         var movedProperties = context.GetProperties(typeof(T), options.CopyGeneratedColumns);
         var returnedProperties = returnData ? context.GetProperties(typeof(T)) : [];
 
-        if (returnData && !SqlDialect.SupportsReturning)
-        {
-            throw new NotSupportedException("Provider does not support returning entities.");
-        }
-
         var query = SqlDialect.BuildMoveDataSql<T>(context, tempTableName, quotedTableName, movedProperties, returnedProperties, options, onConflict);
 
         if (returnData)
@@ -144,7 +139,7 @@ static async Task<List<TResult>> QueryAsync(bool sync, DbContext context, string
         }
     }
 
-    public async Task<List<T>> BulkInsertReturnEntities<T>(
+    public virtual async Task<List<T>> BulkInsertReturnEntities<T>(
         bool sync,
         DbContext context,
         IEnumerable<T> entities,
@@ -173,10 +168,12 @@ private static async Task Finish(bool sync, DbConnection connection, bool wasClo
             {
                 // ReSharper disable once MethodHasAsyncOverloadWithCancellation
                 transaction.Commit();
+                transaction.Dispose();
             }
             else
             {
                 await transaction.CommitAsync(ctk);
+                await transaction.DisposeAsync();
             }
         }
 
@@ -194,7 +191,7 @@ private static async Task Finish(bool sync, DbConnection connection, bool wasClo
         }
     }
 
-    public async Task BulkInsert<T>(
+    public virtual async Task BulkInsert<T>(
         bool sync,
         DbContext context,
         IEnumerable<T> entities,

src/PhenX.EntityFrameworkCore.BulkInsert/Dialect/SqlDialectBuilder.cs

@@ -16,7 +16,6 @@ internal abstract class SqlDialectBuilder
 
     protected virtual string ConcatOperator => "||";
     protected virtual bool SupportsMoveRows => true;
-    public virtual bool SupportsReturning => true;
 
     /// <summary>
     /// Gets the name of the column for a property in a given entity type.

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainerMySql.cs

@@ -16,7 +16,7 @@ public class TestDbContainerMySql<TDbContext> : TestDbContainer<TDbContext>
     {
         return new MySqlBuilder()
             .WithReuse(true)
-            .WithCommand("--log-bin-trust-function-creators=1", "--local-infile=1")
+            .WithCommand("--log-bin-trust-function-creators=1", "--local-infile=1", "--innodb-print-all-deadlocks=ON")
             .Build();
     }