Rename methods to clarify purpose of default options creation

Author: fabien.menager

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs

@@ -27,7 +27,7 @@ public MySqlBulkInsertProvider(ILogger<MySqlBulkInsertProvider>? logger = null)
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";
 
     /// <inheritdoc />
-    protected override MySqlBulkInsertOptions GetDefaultOptions() => new();
+    protected override MySqlBulkInsertOptions CreateDefaultOptions() => new();
 
     /// <inheritdoc />
     public override Task<List<T>> BulkInsertReturnEntities<T>(

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlBulkInsertProvider.cs

@@ -33,7 +33,7 @@ private static string GetBinaryImportCommand(TableMetadata tableInfo, string tab
     }
 
     /// <inheritdoc />
-    protected override BulkInsertOptions GetDefaultOptions() => new()
+    protected override BulkInsertOptions CreateDefaultOptions() => new()
     {
         BatchSize = 50_000,
     };

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs

@@ -28,7 +28,7 @@ public SqlServerBulkInsertProvider(ILogger<SqlServerBulkInsertProvider>? logger
     /// <inheritdoc />
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";
 
-    protected override SqlServerBulkInsertOptions GetDefaultOptions() => new()
+    protected override SqlServerBulkInsertOptions CreateDefaultOptions() => new()
     {
         BatchSize = 50_000,
     };

src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteBulkInsertProvider.cs

@@ -30,7 +30,7 @@ public SqliteBulkInsertProvider(ILogger<SqliteBulkInsertProvider>? logger = null
     protected override string AddTableCopyBulkInsertId => "--"; // No need to add an ID column in SQLite
 
     /// <inheritdoc />
-    protected override BulkInsertOptions GetDefaultOptions() => new()
+    protected override BulkInsertOptions CreateDefaultOptions() => new()
     {
         BatchSize = 5,
     };

src/PhenX.EntityFrameworkCore.BulkInsert/Abstractions/IBulkInsertProvider.cs

@@ -42,5 +42,5 @@ internal Task BulkInsert<T>(
     /// <summary>
     /// Make the default options for the provider, can be a subclass of <see cref="BulkInsertOptions"/>.
     /// </summary>
-    internal BulkInsertOptions InternalGetDefaultOptions();
+    internal BulkInsertOptions InternalCreateDefaultOptions();
 }

src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs

@@ -259,9 +259,12 @@ public virtual async Task BulkInsert<T>(
         }
     }
 
-    public BulkInsertOptions InternalGetDefaultOptions() => GetDefaultOptions();
+    public BulkInsertOptions InternalCreateDefaultOptions() => CreateDefaultOptions();
 
-    protected abstract TOptions GetDefaultOptions();
+    /// <summary>
+    /// Create the default options for the provider, can be a subclass of <see cref="BulkInsertOptions"/>.
+    /// </summary>
+    protected abstract TOptions CreateDefaultOptions();
 
     private async Task<(string TableName, DbConnection Connection)> PerformBulkInsertAsync<T>(
         bool sync,

src/PhenX.EntityFrameworkCore.BulkInsert/Extensions/DbSetExtensions.cs

@@ -246,7 +246,7 @@ private static IBulkInsertProvider InitProvider<T, TOptions>(DbSet<T> dbSet, Act
         context = dbSet.GetDbContext();
         var provider = context.GetService<IBulkInsertProvider>();
 
-        var defaultOptions = provider.InternalGetDefaultOptions();
+        var defaultOptions = provider.InternalCreateDefaultOptions();
 
         if (defaultOptions is not TOptions castedOptions)
         {