Update bulk insert benchmarks and improve SQL Server transaction handling

Author: fabien.menager

EntityFrameworkCore.ExecuteInsert.Benchmark/Program.cs

@@ -6,7 +6,7 @@ public class Program
 {
     public static void Main(string[] args)
     {
-        BenchmarkRunner.Run<BulkInsertVsExecuteInsert>();
+        BenchmarkRunner.Run<BulkInsertVsExecuteInsertPostgreSql>();
         BenchmarkRunner.Run<BulkInsertVsExecuteInsertSqlServer>();
     }
 }

src/EntityFrameworkCore.ExecuteInsert.SqlServer/SqlServerBulkInsertProvider.cs

@@ -28,9 +28,11 @@ protected override string GetTempTableName<T>(string tableName) where T : class
     protected override async Task BulkImport<T>(DbContext context, DbConnection connection, IEnumerable<T> entities, string tableName,
         PropertyAccessor[] properties, CancellationToken ctk)
     {
-        using var bulkCopy = new SqlBulkCopy(connection as SqlConnection);
+        await using var t = (SqlTransaction) await connection.BeginTransactionAsync(ctk); // TODO option
+
+        using var bulkCopy = new SqlBulkCopy(connection as SqlConnection, SqlBulkCopyOptions.TableLock, t);
         bulkCopy.DestinationTableName = tableName;
-        bulkCopy.BatchSize = 10_000;
+        bulkCopy.BatchSize = 50_000; // TODO option
         bulkCopy.BulkCopyTimeout = 60;
 
         foreach (var prop in properties)
@@ -39,6 +41,8 @@ protected override async Task BulkImport<T>(DbContext context, DbConnection conn
         }
 
         await bulkCopy.WriteToServerAsync(new EnumerableDataReader<T>(entities, properties), ctk);
+
+        await t.CommitAsync(ctk);
     }
 
     protected override string BuildInsertSelectQuery(string tempTableName, string targetTableName,

tests/EntityFrameworkCore.ExecuteInsert.Tests/Tests/BulkInsertProviderTests.cs

@@ -80,7 +80,7 @@ public async Task DoesNothingWhenEntitiesAreEmpty()
     public async Task InsertsThousandsOfEntitiesSuccessfully()
     {
         // Arrange
-        const int count = 1_00_000;
+        const int count = 1_000_000;
         var entities = Enumerable.Range(1, count).Select(i => new TestEntity
         {
             Id = i,