Skip to content

Commit 5157d9d

Browse files
author
fabien.menager
committed
Refactor access modifiers to internal and add more documentation for public members
1 parent 8599fdd commit 5157d9d

29 files changed

Lines changed: 108 additions & 71 deletions

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ await dbContext.ExecuteInsertWithIdentityAsync(entities, options => {});
7474

7575
## Benchmarks
7676
Benchmark projects are available in the [`tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark`](tests/PhenX.EntityFrameworkCore.BulkInsert.Benchmark/LibComparator.cs) directory.
77-
Run them to compare performance with other libraries (https://github.com/videokojot/EFCore.BulkExtensions.MIT and https://entityframework-extensions.net/bulk-extensions),
77+
Run them to compare performance with other libraries (https://github.com/borisdj/EFCore.BulkExtensions and https://entityframework-extensions.net/bulk-extensions),
7878
using optimized configuration (local Docker is required).
7979

8080
There is no need to compare with basic EF Core SaveChangesAsync, as it is significantly slower.

src/Directory.Build.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<NeutralLanguage>en</NeutralLanguage>
99
<EnableNETAnalyzers>true</EnableNETAnalyzers>
1010
<!-- <AnalysisMode>AllEnabledByDefault</AnalysisMode>-->
11-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
11+
<TreatWarningsAsErrors Condition="$(Configuration) != 'Debug'">true</TreatWarningsAsErrors>
1212
</PropertyGroup>
1313

1414
<PropertyGroup>
@@ -32,7 +32,7 @@
3232
</ItemGroup>
3333

3434
<PropertyGroup Label="Build">
35-
<!-- <GenerateDocumentationFile>true</GenerateDocumentationFile>-->
35+
<GenerateDocumentationFile>true</GenerateDocumentationFile>
3636
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
3737
</PropertyGroup>
3838

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
</ItemGroup>
66

77
<ItemGroup>
8-
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Condition="'$(TargetFramework)' == 'net8.0'" Version="8.0.11" />
9-
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Condition="'$(TargetFramework)' == 'net9.0'" Version="9.0.4" />
8+
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Condition="'$(TargetFramework)' == 'net8.0'" Version="8.*" />
9+
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Condition="'$(TargetFramework)' == 'net9.0'" Version="9.*" />
1010
</ItemGroup>
1111

1212
</Project>

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlBulkInsertProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
namespace PhenX.EntityFrameworkCore.BulkInsert.PostgreSql;
1010

1111
[UsedImplicitly]
12-
public class PostgreSqlBulkInsertProvider : BulkInsertProviderBase<PostgreSqlDialectBuilder>
12+
internal class PostgreSqlBulkInsertProvider : BulkInsertProviderBase<PostgreSqlDialectBuilder>
1313
{
1414
//language=sql
1515
protected override string CreateTableCopySql => "CREATE TEMPORARY TABLE {0} AS TABLE {1} WITH NO DATA;";

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlDbContextOptionsExtensions.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,14 @@
33

44
namespace PhenX.EntityFrameworkCore.BulkInsert.PostgreSql;
55

6+
/// <summary>
7+
/// DbContext options extension for PostgreSQL.
8+
/// </summary>
69
public static class PostgreSqlDbContextOptionsExtensions
710
{
11+
/// <summary>
12+
/// Configures the DbContext to use the PostgreSQL bulk insert provider.
13+
/// </summary>
814
public static DbContextOptionsBuilder UseExecuteInsertPostgres(this DbContextOptionsBuilder optionsBuilder)
915
{
1016
var extension = optionsBuilder.Options.FindExtension<ExecuteInsertOptionsExtension<PostgreSqlBulkInsertProvider>>() ?? new ExecuteInsertOptionsExtension<PostgreSqlBulkInsertProvider>();

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlDialectBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace PhenX.EntityFrameworkCore.BulkInsert.PostgreSql;
44

5-
public class PostgreSqlDialectBuilder : SqlDialectBuilder
5+
internal class PostgreSqlDialectBuilder : SqlDialectBuilder
66
{
77
protected override string OpenDelimiter => "\"";
88
protected override string CloseDelimiter => "\"";

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/PhenX.EntityFrameworkCore.BulkInsert.SqlServer.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
</ItemGroup>
66

77
<ItemGroup>
8-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Condition="'$(TargetFramework)' == 'net8.0'" Version="8.0.15" />
9-
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Condition="'$(TargetFramework)' == 'net9.0'" Version="9.0.4" />
8+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Condition="'$(TargetFramework)' == 'net8.0'" Version="8.*" />
9+
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Condition="'$(TargetFramework)' == 'net9.0'" Version="9.*" />
1010
</ItemGroup>
1111

1212
</Project>

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
namespace PhenX.EntityFrameworkCore.BulkInsert.SqlServer;
99

1010
[UsedImplicitly]
11-
public class SqlServerBulkInsertProvider : BulkInsertProviderBase<SqlServerDialectBuilder>
11+
internal class SqlServerBulkInsertProvider : BulkInsertProviderBase<SqlServerDialectBuilder>
1212
{
1313
//language=sql
1414
protected override string CreateTableCopySql => "SELECT {2} INTO {0} FROM {1} WHERE 1 = 0;";

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerDbContextOptionsExtensions.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,14 @@
33

44
namespace PhenX.EntityFrameworkCore.BulkInsert.SqlServer;
55

6+
/// <summary>
7+
/// DbContext options extension for SQL Server.
8+
/// </summary>
69
public static class SqlServerDbContextOptionsExtensions
710
{
11+
/// <summary>
12+
/// Configures the DbContext to use the SQL Server bulk insert provider.
13+
/// </summary>
814
public static DbContextOptionsBuilder UseExecuteInsertSqlServer(this DbContextOptionsBuilder optionsBuilder)
915
{
1016
var extension = optionsBuilder.Options.FindExtension<ExecuteInsertOptionsExtension<SqlServerBulkInsertProvider>>() ?? new ExecuteInsertOptionsExtension<SqlServerBulkInsertProvider>();

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerDialectBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
namespace PhenX.EntityFrameworkCore.BulkInsert.SqlServer;
1111

12-
public class SqlServerDialectBuilder : SqlDialectBuilder
12+
internal class SqlServerDialectBuilder : SqlDialectBuilder
1313
{
1414
protected override string OpenDelimiter => "[";
1515
protected override string CloseDelimiter => "]";

0 commit comments

Comments
 (0)