Don't throw on null value for Uri (#57)

* Add null URI to existing converter test

* Don't invoke the type converter when the incoming complex type value is null

* Undo formatting change

Author: christiaanderidder

src/PhenX.EntityFrameworkCore.BulkInsert/Metadata/PropertyAccessor.cs

@@ -39,7 +39,18 @@ internal static class PropertyAccessor
                 converterInput = Expression.Convert(getterExpression, converterParamType);
             }
 
-            getterExpression = Expression.Invoke(converter, converterInput);
+            var invokeConverter = Expression.Invoke(converter, converterInput);
+
+            if (propertyType.IsClass)
+            {
+                var nullCondition = Expression.Equal(getterExpression, Expression.Constant(null, propertyType));
+                var nullResult = Expression.Constant(null, converter.ReturnType);
+                getterExpression = Expression.Condition(nullCondition, nullResult, invokeConverter);
+            }
+            else
+            {
+                getterExpression = invokeConverter;
+            }
 
             propertyType = getterExpression.Type;
         }

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContext/TestEntityWithConverters.cs

@@ -14,5 +14,8 @@ public class TestEntityWithConverters : TestEntityBase
 
     [Column("created_at")]
     public DateTime CreatedAt { get; set; }
+
+    [Column("uri")]
+    public Uri? Uri { get; set; }
 }
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/Tests/Basic/BasicTestsBase.cs

@@ -176,8 +176,8 @@ public async Task InsertEntities_AndReturn_WithEntityWithValueConverters(InsertS
 
         var entities = new List<TestEntityWithConverters>
         {
-            new TestEntityWithConverters() { Name = $"{_run}_Entity1", CreatedAt = now },
-            new TestEntityWithConverters() { Name = $"{_run}_Entity2", CreatedAt = now.AddDays(-1) }
+            new TestEntityWithConverters() { Name = $"{_run}_Entity1", CreatedAt = now, Uri = null },
+            new TestEntityWithConverters() { Name = $"{_run}_Entity2", CreatedAt = now.AddDays(-1), Uri = new Uri("http://example.com/test") }
         };
 
         // Act