Implement comments

Author: SebastianStehle

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs

@@ -58,7 +58,7 @@ CancellationToken ctk
 
         var bulkCopy = new MySqlBulkCopy(connection, mySqlTransaction);
         bulkCopy.DestinationTableName = tableName;
-        bulkCopy.BulkCopyTimeout = 60;
+        bulkCopy.BulkCopyTimeout = options.GetCopyTimeoutInSeconds();
 
         var sourceOrdinal = 0;
         foreach (var prop in properties)

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlDbContextOptionsExtensions.cs

@@ -4,7 +4,7 @@
 namespace PhenX.EntityFrameworkCore.BulkInsert.MySql;
 
 /// <summary>
-/// DbContext options extension for SQL Server.
+/// DbContext options extension for MySql.
 /// </summary>
 public static class MySqlDbContextOptionsExtensions
 {

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs

@@ -22,7 +22,7 @@ public SqlServerBulkInsertProvider(ILogger<SqlServerBulkInsertProvider>? logger
 
     //language=sql
     /// <inheritdoc />
-    protected override string AddTableCopyBulkInsertId => $"ALTER TABLE {{0}} ADD {BulkInsertId} INT;";
+    protected override string AddTableCopyBulkInsertId => $"ALTER TABLE {{0}} ADD {BulkInsertId} INT IDENTITY PRIMARY KEY;";
 
     /// <inheritdoc />
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainer.cs

@@ -19,8 +19,6 @@ protected TestDbContainer()
         DbContainer = GetDbContainer();
     }
 
-    protected string GetRandomContainerName() => "phenx-bulk-insert-test-" + Guid.NewGuid();
-
     protected abstract IDatabaseContainer? GetDbContainer();
 
     protected virtual string GetConnectionString()

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainerMySql.cs

@@ -15,9 +15,8 @@ public class TestDbContainerMySql<TDbContext> : TestDbContainer<TDbContext>
     protected override IDatabaseContainer? GetDbContainer()
     {
         return new MySqlBuilder()
-            .WithReuse(true)
             .WithCommand("--log-bin-trust-function-creators=1", "--local-infile=1", "--innodb-print-all-deadlocks=ON")
-            .WithName(GetRandomContainerName())
+            .WithReuse(true)
             .Build();
     }
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainerPostgreSql.cs

@@ -19,7 +19,6 @@ public class TestDbContainerPostgreSql<TDbContext> : TestDbContainer<TDbContext>
             .WithDatabase("testdb")
             .WithUsername("testuser")
             .WithPassword("testpassword")
-            .WithName(GetRandomContainerName())
             .Build();
     }
 

tests/PhenX.EntityFrameworkCore.BulkInsert.Tests/DbContainer/TestDbContainerSqlServer.cs

@@ -16,7 +16,6 @@ public class TestDbContainerSqlServer<TDbContext> : TestDbContainer<TDbContext>
     {
         return new MsSqlBuilder()
             .WithReuse(true)
-            .WithName(GetRandomContainerName())
             .Build();
     }