Skip to content

Commit 137d2fc

Browse files
authored
Actually use the async code paths for bulk insert (#93)
Since its introduction in 045033c, the `sync` argument passed to `BulkInsert()` has always been hardcoded to `false` instead of forwarding the `sync` parameter. As a result, the async code paths for bulk insert in all providers would never be used. This can be confirmed by running code coverage.
1 parent b091f08 commit 137d2fc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ private async Task<string> PerformBulkInsertAsync<T>(
144144
activity?.AddTag("tempTable", tempTableRequired);
145145
activity?.AddTag("synchronous", sync);
146146

147-
await BulkInsert(false, context, tableInfo, entities, tableName, columns, options, ctk);
147+
await BulkInsert(sync, context, tableInfo, entities, tableName, columns, options, ctk);
148148
return tableName;
149149
}
150150

0 commit comments

Comments
 (0)