Move stuff to dialect.

Author: SebastianStehle

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs

@@ -22,11 +22,6 @@ public MySqlBulkInsertProvider(ILogger<MySqlBulkInsertProvider>? logger = null)
     /// <inheritdoc />
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";
 
-    protected override string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
-    {
-        return $"CREATE TEMPORARY TABLE {tempNameName} SELECT * FROM {tableInfo.QuotedTableName} WHERE 1 = 0;";
-    }
-
     /// <inheritdoc />
     public override Task<List<T>> BulkInsertReturnEntities<T>(
         bool sync,

src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlDialectBuilder.cs

@@ -14,6 +14,11 @@ internal class MySqlServerDialectBuilder : SqlDialectBuilder
 
     protected override bool SupportsMoveRows => false;
 
+    public override string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
+    {
+        return $"CREATE TEMPORARY TABLE {tempNameName} SELECT * FROM {tableInfo.QuotedTableName} WHERE 1 = 0;";
+    }
+
     protected override void AppendConflictCondition<T>(StringBuilder sql, OnConflictOptions<T> onConflictTyped)
     {
         throw new NotSupportedException("Conflict conditions are not supported in MYSQL");

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlBulkInsertProvider.cs

@@ -23,12 +23,6 @@ public PostgreSqlBulkInsertProvider(ILogger<PostgreSqlBulkInsertProvider>? logge
     /// <inheritdoc />
     protected override string AddTableCopyBulkInsertId => $"ALTER TABLE {{0}} ADD COLUMN {BulkInsertId} SERIAL PRIMARY KEY;";
 
-    /// <inheritdoc />
-    protected override string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
-    {
-        return $"CREATE TEMPORARY TABLE {tempNameName} AS TABLE {tableInfo.QuotedTableName} WITH NO DATA;";
-    }
-
     private static string GetBinaryImportCommand(IReadOnlyList<PropertyMetadata> properties, string tableName)
     {
         var sql = new StringBuilder();

src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlDialectBuilder.cs

@@ -11,6 +11,11 @@ internal class PostgreSqlDialectBuilder : SqlDialectBuilder
     protected override string OpenDelimiter => "\"";
     protected override string CloseDelimiter => "\"";
 
+    public override string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
+    {
+        return $"CREATE TEMPORARY TABLE {tempNameName} AS TABLE {tableInfo.QuotedTableName} WITH NO DATA;";
+    }
+
     protected override void AppendConflictMatch<T>(StringBuilder sql, TableMetadata target, OnConflictOptions<T> conflict)
     {
         if (conflict.Match != null)

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs

@@ -26,27 +26,6 @@ public SqlServerBulkInsertProvider(ILogger<SqlServerBulkInsertProvider>? logger
     /// <inheritdoc />
     protected override string GetTempTableName(string tableName) => $"#_temp_bulk_insert_{tableName}";
 
-    protected override string CreateTableCopySql(string templNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
-    {
-        var sb = new StringBuilder();
-        sb.Append($"CREATE TABLE {templNameName}");
-        sb.AppendLine("(");
-
-        foreach (var column in columns)
-        {
-            sb.Append($"   {column.QuotedColumName} {column.StoreDefinition}");
-            if (column != columns[^1])
-            {
-                sb.Append(',');
-            }
-            sb.AppendLine();
-        }
-
-        sb.AppendLine(")");
-
-        return sb.ToString();
-    }
-
     /// <inheritdoc />
     protected override async Task BulkInsert<T>(
         bool sync,

src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerDialectBuilder.cs

@@ -14,6 +14,16 @@ internal class SqlServerDialectBuilder : SqlDialectBuilder
 
     protected override bool SupportsMoveRows => false;
 
+    public override string CreateTableCopySql(string templNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
+    {
+        var q = new StringBuilder();
+        q.Append("SELECT");
+        q.AppendColumns(columns);
+        q.Append($"INTO {templNameName} FROM {tableInfo.QuotedTableName} WHERE 1 = 0;");
+
+        return q.ToString();
+    }
+
     public override string BuildMoveDataSql<T>(
         TableMetadata target,
         string source,

src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteBulkInsertProvider.cs

@@ -27,12 +27,6 @@ public SqliteBulkInsertProvider(ILogger<SqliteBulkInsertProvider>? logger = null
     /// <inheritdoc />
     protected override string AddTableCopyBulkInsertId => "--"; // No need to add an ID column in SQLite
 
-    /// <inheritdoc />
-    protected override string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
-    {
-        return $"CREATE TEMP TABLE {tempNameName} AS SELECT * FROM {tableInfo.QuotedTableName} WHERE 0;";
-    }
-
     /// <inheritdoc />
     protected override Task AddBulkInsertIdColumn<T>(
         bool sync,

src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteDialectBuilder.cs

@@ -1,4 +1,5 @@
-using PhenX.EntityFrameworkCore.BulkInsert.Dialect;
+using PhenX.EntityFrameworkCore.BulkInsert.Dialect;
+using PhenX.EntityFrameworkCore.BulkInsert.Metadata;
 
 namespace PhenX.EntityFrameworkCore.BulkInsert.Sqlite;
 
@@ -8,4 +9,10 @@ internal class SqliteDialectBuilder : SqlDialectBuilder
     protected override string CloseDelimiter => "\"";
 
     protected override bool SupportsMoveRows => false;
+
+    /// <inheritdoc />
+    public override string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns)
+    {
+        return $"CREATE TEMP TABLE {tempNameName} AS SELECT * FROM {tableInfo.QuotedTableName} WHERE 0;";
+    }
 }

src/PhenX.EntityFrameworkCore.BulkInsert/BulkInsertProviderBase.cs

@@ -36,16 +36,14 @@ protected async Task<string> CreateTableCopyAsync<T>(
         var tempTableName = SqlDialect.QuoteTableName(null, GetTempTableName(tableInfo.TableName));
         var tempColumns = tableInfo.GetProperties(options.CopyGeneratedColumns);
 
-        var query = CreateTableCopySql(tempTableName, tableInfo, tempColumns);
+        var query = SqlDialect.CreateTableCopySql(tempTableName, tableInfo, tempColumns);
 
         await ExecuteAsync(sync, context, query, cancellationToken);
         await AddBulkInsertIdColumn<T>(sync, context, tempTableName, cancellationToken);
 
         return tempTableName;
     }
 
-    protected abstract string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns);
-
     protected virtual async Task AddBulkInsertIdColumn<T>(bool sync, DbContext context,
         string tempTableName, CancellationToken cancellationToken) where T : class
     {

src/PhenX.EntityFrameworkCore.BulkInsert/Dialect/SqlDialectBuilder.cs

@@ -14,6 +14,8 @@ internal abstract class SqlDialectBuilder
     protected virtual string ConcatOperator => "||";
     protected virtual bool SupportsMoveRows => true;
 
+    public abstract string CreateTableCopySql(string tempNameName, TableMetadata tableInfo, IReadOnlyList<PropertyMetadata> columns);
+
     /// <summary>
     /// Builds the SQL for moving data from one table to another.
     /// </summary>