From d3b1483de4fe8d43646e4a5a34f112623dea529b Mon Sep 17 00:00:00 2001 From: Jiayi Sun Date: Wed, 4 Nov 2026 23:14:39 -0500 Subject: [PATCH 1/3] Check override parameters in chunked imaging handler --- phangsPipeline/handlerImagingChunked.py | 76 ++++++++++++++++++++++--- 1 file changed, 68 insertions(+), 8 deletions(-) diff --git a/phangsPipeline/handlerImagingChunked.py b/phangsPipeline/handlerImagingChunked.py index 7899727a..ff70830b 100644 --- a/phangsPipeline/handlerImagingChunked.py +++ b/phangsPipeline/handlerImagingChunked.py @@ -57,6 +57,7 @@ def __init__( set_cell_imsize_on_init=True, force_square=False, oversamp=5, + check_overrides=True, make_temp_dir=True, temp_key=None, temp_path=None, @@ -89,6 +90,9 @@ def __init__( If True, force the image size to be square. Defaults to False. oversamp : int, optional The oversampling factor of pixels per beam FWHM. Defaults to 5. + check_overrides : bool, optional + If True, apply user-set 'cell', 'deltara' and 'deltadec' overrides + from the override key file, as in ImagingHandler. Defaults to True. make_temp_dir : bool, optional If True, make a temporary directory. Defaults to True. temp_key : str, optional @@ -171,7 +175,9 @@ def __init__( # TODO: this will fail if false as we need it for the base call. # Could just not give the option and force computing this on init if set_cell_imsize_on_init: - self.set_cube_cell_and_imsize(force_square=force_square, oversamp=oversamp) + self.set_cube_cell_and_imsize( + force_square=force_square, oversamp=oversamp, + check_overrides=check_overrides) # Find the number of channels in the MS to image # This defaults to using all (assuming it's a staged MS) @@ -638,9 +644,6 @@ def task_split_cube_to_chunks(self, imagename, overwrite=False, chunk_num=None, logger.info("Chunked vis for channels {} already exists. Skipping".format(key)) continue - if verbose: - print("On channel "+str(chan+1)+" of "+str(start+nchan)) - lower_corner = [0] * ndims upper_corner = copy(cube_shape) @@ -752,9 +755,13 @@ def task_initialize_clean_call( return (clean_call) - def set_cube_cell_and_imsize(self, force_square=False, oversamp=5): + def set_cube_cell_and_imsize(self, force_square=False, oversamp=5, check_overrides=True): ''' Set a single cell and imsize for all chunks. + + This calls casaImagingRoutines.estimate_cell_and_imsize() first, + then applies user-defined overrides (cell, deltara, deltadec; all in + arcsec) if they exist, following ImagingHandler.task_pick_cell_and_imsize(). ''' logger.info("") @@ -766,15 +773,68 @@ def set_cube_cell_and_imsize(self, force_square=False, oversamp=5): # Call the estimating routine if not self._dry_run: - self.cell, self.imsize = \ + cell, imsize = \ imr.estimate_cell_and_imsize(self.full_vis_file, oversamp, force_square=force_square) else: - self.cell, self.imsize = '0.1arcsec', [1000, 1000] + cell, imsize = '0.1arcsec', [1000, 1000] logger.info('DRY RUN skips calling imr.estimate_cell_and_imsize()') - logger.info('cell={0}; imsize={1}'.format(self.cell, self.imsize)) + imsize = [int(x) for x in imsize] + + logger.info('cell={0}; imsize={1}'.format(cell, imsize)) + + # Check user-defined overriding parameters: cell deltara deltadec + # (pixel size and width/height of the field of view in arcsec). + # Search order: target_config_product -> target_config -> target -> all + if check_overrides: + override_keys = [ + self.target + '_' + self.config + '_' + self.product, + self.target + '_' + self.config, + self.target, + 'all', + ] + override_cell = None + override_deltara = None + override_deltadec = None + for override_key in override_keys: + if override_cell is None: + override_cell = self._kh.get_overrides(override_key, 'cell') + if override_deltara is None: + override_deltara = self._kh.get_overrides(override_key, 'deltara') + if override_deltadec is None: + override_deltadec = self._kh.get_overrides(override_key, 'deltadec') + + orig_cell_arcsec = float(str(cell).replace('arcsec', '')) + if override_cell is not None: + logger.info('applying overriding cell ' + str(override_cell) + ' arcsec') + cell_arcsec = np.abs(float(override_cell)) + cell = str(cell_arcsec) + 'arcsec' + else: + cell_arcsec = orig_cell_arcsec + + # Recompute imsize so the field of view is preserved (or overridden), + # always using an even number of pixels + orig_imsize = list(imsize) + if override_deltara is not None: + logger.info('applying overriding deltara ' + str(override_deltara) + ' arcsec') + deltara = np.abs(float(override_deltara)) + else: + deltara = orig_imsize[0] * orig_cell_arcsec + imsize[0] = int(np.ceil(deltara / cell_arcsec / 2.0) * 2) + + if override_deltadec is not None: + logger.info('applying overriding deltadec ' + str(override_deltadec) + ' arcsec') + deltadec = np.abs(float(override_deltadec)) + else: + deltadec = orig_imsize[1] * orig_cell_arcsec + imsize[1] = int(np.ceil(deltadec / cell_arcsec / 2.0) * 2) + + if any(x is not None for x in [override_cell, override_deltara, override_deltadec]): + logger.info('cell={0}; imsize={1} (after overrides)'.format(cell, imsize)) + + self.cell, self.imsize = cell, imsize @CleanCallFunctionDecorator From 8ac80d8e922217b77c37d71f73603e583310d25e Mon Sep 17 00:00:00 2001 From: Jiayi Sun <10154364+astrojysun@users.noreply.github.com> Date: Thu, 5 Nov 2026 11:39:25 -0500 Subject: [PATCH 2/3] Adjust imsize calculations based on overrides Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- phangsPipeline/handlerImagingChunked.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/phangsPipeline/handlerImagingChunked.py b/phangsPipeline/handlerImagingChunked.py index ff70830b..b4b40e8d 100644 --- a/phangsPipeline/handlerImagingChunked.py +++ b/phangsPipeline/handlerImagingChunked.py @@ -822,14 +822,16 @@ def set_cube_cell_and_imsize(self, force_square=False, oversamp=5, check_overrid deltara = np.abs(float(override_deltara)) else: deltara = orig_imsize[0] * orig_cell_arcsec - imsize[0] = int(np.ceil(deltara / cell_arcsec / 2.0) * 2) + if override_deltara is not None or cell_arcsec != orig_cell_arcsec: + imsize[0] = int(np.ceil(deltara / cell_arcsec / 2.0) * 2) if override_deltadec is not None: logger.info('applying overriding deltadec ' + str(override_deltadec) + ' arcsec') deltadec = np.abs(float(override_deltadec)) else: deltadec = orig_imsize[1] * orig_cell_arcsec - imsize[1] = int(np.ceil(deltadec / cell_arcsec / 2.0) * 2) + if override_deltadec is not None or cell_arcsec != orig_cell_arcsec: + imsize[1] = int(np.ceil(deltadec / cell_arcsec / 2.0) * 2) if any(x is not None for x in [override_cell, override_deltara, override_deltadec]): logger.info('cell={0}; imsize={1} (after overrides)'.format(cell, imsize)) From 3a647031584d6aa30453c628df09891f633d2e43 Mon Sep 17 00:00:00 2001 From: Jiayi Sun Date: Tue, 10 Nov 2026 00:14:28 -0500 Subject: [PATCH 3/3] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 66bd5d38..27037e9f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add optional file string in derived for nonstandard workflows (#406). - Use SD pipeline weights in single-dish linear mosaicking (#397). - Expose ``min_pixperbeam`` for cube compression in ``loop_postprocess`` (#411). +- Allow override parameters in chunked imaging handler (#417). ### Changed