From e6b00751bdfb73b647125604b134e225c0df59f8 Mon Sep 17 00:00:00 2001 From: Daniel Schultz Date: Fri, 15 May 2026 12:33:15 -0400 Subject: [PATCH] Ignore location `displayName` The display name of a location was populated by the `name` returned by our location lookup. Some locations (e.g. landmarks) have names, which is where that came from. We don't actually save this information, which means users would see it at first but it would disappear on refresh. Rather than save it we're opting to remove the concept entirely. Issue #1024 Do not render the displayName of a location --- .../location-picker/location-picker.component.html | 4 ---- .../location-picker/location-picker.component.ts | 4 ---- src/app/models/locn-vo.ts | 1 - src/app/shared/pipes/pr-location.pipe.ts | 7 ------- 4 files changed, 16 deletions(-) diff --git a/src/app/file-browser/components/location-picker/location-picker.component.html b/src/app/file-browser/components/location-picker/location-picker.component.html index 704971e20..1a9a15b13 100644 --- a/src/app/file-browser/components/location-picker/location-picker.component.html +++ b/src/app/file-browser/components/location-picker/location-picker.component.html @@ -15,10 +15,6 @@ @if (currentLocation) {
- @if (currentLocationDisplay.displayName) { - {{ currentLocationDisplay.displayName }} -
- } {{ currentLocationDisplay.line1 }}
{{ currentLocationDisplay.line2 }} diff --git a/src/app/file-browser/components/location-picker/location-picker.component.ts b/src/app/file-browser/components/location-picker/location-picker.component.ts index 060b276d8..14cc1b15d 100644 --- a/src/app/file-browser/components/location-picker/location-picker.component.ts +++ b/src/app/file-browser/components/location-picker/location-picker.component.ts @@ -244,10 +244,6 @@ export class LocationPickerComponent implements OnInit, AfterViewInit { countryCode: getComponentName(addr, 'country', true), }; - if (!place.name.includes(locn.streetNumber)) { - locn.displayName = place.name; - } - return locn; function getComponentName( diff --git a/src/app/models/locn-vo.ts b/src/app/models/locn-vo.ts index 378de3ddf..409b9fa0e 100644 --- a/src/app/models/locn-vo.ts +++ b/src/app/models/locn-vo.ts @@ -4,7 +4,6 @@ export interface LocnVOData extends BaseVOData { locnId?: number; timeZoneId?: number; - displayName?: string; geoCodeLookup?: string; streetNumber?: string; streetName?: string; diff --git a/src/app/shared/pipes/pr-location.pipe.ts b/src/app/shared/pipes/pr-location.pipe.ts index c868be1b1..27d732043 100644 --- a/src/app/shared/pipes/pr-location.pipe.ts +++ b/src/app/shared/pipes/pr-location.pipe.ts @@ -5,7 +5,6 @@ export interface LocnPipeOutput { line1?: string; line2?: string; full?: string; - displayName?: string; } @Pipe({ @@ -53,12 +52,6 @@ export class PrLocationPipe implements PipeTransform { output.line2 = line2.length ? line2.join(', ') : 'Unknown Location'; output.full = output.line1 + ', ' + output.line2; - if (locnVO.displayName) { - if (locnVO.displayName.toLowerCase() !== output.line1.toLowerCase()) { - output.displayName = locnVO.displayName; - output.full = locnVO.displayName + ', ' + output.full; - } - } return output; } }