From 1e0e999221ac53bdad5787973a5fb0ed5fdc3eff Mon Sep 17 00:00:00 2001 From: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> Date: Thu, 20 Aug 2026 16:11:48 -0700 Subject: [PATCH] Revert "ci: bound tend job runtime with `timeout-minutes` (#6215)" This reverts commit 7f050f21df2c2829a0eb4d3be20762d3b33aaa95. --- .config/tend.yaml | 50 ----------------------- .github/workflows/tend-ci-fix.yaml | 1 - .github/workflows/tend-mention.yaml | 3 -- .github/workflows/tend-nightly.yaml | 1 - .github/workflows/tend-notifications.yaml | 1 - .github/workflows/tend-review-runs.yaml | 1 - .github/workflows/tend-review.yaml | 1 - .github/workflows/tend-triage.yaml | 1 - .github/workflows/tend-weekly.yaml | 1 - 9 files changed, 60 deletions(-) diff --git a/.config/tend.yaml b/.config/tend.yaml index a288a612522a..69751644747d 100644 --- a/.config/tend.yaml +++ b/.config/tend.yaml @@ -10,57 +10,7 @@ secrets: - DOCKERHUB_USERNAME setup: - uses: ./.github/actions/tend-setup -# Without these, every tend job is bounded only by GitHub's 360-minute default -# job cap. `tend-nightly` run 26438780303 hit exactly that on 2026-05-26 (07:32Z -# → 13:32Z, six hours, no `tend-outage` row filed). A hang in the setup steps is -# worse still: those run before the action is entered, so the harness supervisor -# never sees them and the job cap is the only bound that reaches them. -# -# The caps below are ~2x the slowest run observed over the last 100 completed -# runs of each workflow; see the PR that added them for the table. They sit below -# the supervisor's `timeout_seconds` (350m), so they are the operative session -# budget — deliberate, since under `cancel-in-progress: false` an unbounded -# review holds the PR's review queue behind it. workflows: ci-fix: watched_workflows: - tests - jobs: - fix-ci: - timeout-minutes: 60 - review: - jobs: - review: - timeout-minutes: 120 - mention: - jobs: - # `relay` and `verify` are one-step script jobs that have never exceeded - # 15s across the last 40 runs, but `handle` declares `needs: verify`, so a - # wedged `verify` holds a mention unanswered for the full six hours without - # ever reaching the capped job. - relay: - timeout-minutes: 10 - verify: - timeout-minutes: 10 - handle: - timeout-minutes: 120 - triage: - jobs: - triage: - timeout-minutes: 120 - review-runs: - jobs: - review-runs: - timeout-minutes: 120 - nightly: - jobs: - nightly: - timeout-minutes: 180 - weekly: - jobs: - weekly: - timeout-minutes: 60 - notifications: - jobs: - notifications: - timeout-minutes: 60 diff --git a/.github/workflows/tend-ci-fix.yaml b/.github/workflows/tend-ci-fix.yaml index 13dbd6e2e2b9..c80978496c52 100644 --- a/.github/workflows/tend-ci-fix.yaml +++ b/.github/workflows/tend-ci-fix.yaml @@ -46,4 +46,3 @@ jobs: - Run URL: ${{ github.event.workflow_run.html_url }} - Commit: ${{ github.event.workflow_run.head_sha }} - Commit message: ${{ github.event.workflow_run.head_commit.message }} - timeout-minutes: 60 diff --git a/.github/workflows/tend-mention.yaml b/.github/workflows/tend-mention.yaml index 2b03332fbc3d..f38c9eb073be 100644 --- a/.github/workflows/tend-mention.yaml +++ b/.github/workflows/tend-mention.yaml @@ -88,7 +88,6 @@ jobs: -f "client_payload[kind]=${{ github.event_name }}" \ -f "client_payload[pr]=${{ github.event.pull_request.number }}" \ -f "client_payload[id]=${{ github.event.review.id || github.event.comment.id }}" - timeout-minutes: 10 verify: # Skip comments on the issues tend files about its own health: the action @@ -341,7 +340,6 @@ jobs: PAYLOAD_KIND: ${{ github.event.client_payload.kind }} PAYLOAD_PR: ${{ github.event.client_payload.pr }} PAYLOAD_ID: ${{ github.event.client_payload.id }} - timeout-minutes: 10 handle: needs: verify @@ -479,4 +477,3 @@ jobs: || format('pulls/comments/{0}', github.event.comment.id || github.event.client_payload.id) }} BOT_NAME: prql-bot GITHUB_TOKEN: ${{ secrets.TEND_BOT_TOKEN }} - timeout-minutes: 120 diff --git a/.github/workflows/tend-nightly.yaml b/.github/workflows/tend-nightly.yaml index 803be0a2dd85..7c97bd10d986 100644 --- a/.github/workflows/tend-nightly.yaml +++ b/.github/workflows/tend-nightly.yaml @@ -43,4 +43,3 @@ jobs: model: opus prompt: | /tend-ci-runner:nightly - timeout-minutes: 180 diff --git a/.github/workflows/tend-notifications.yaml b/.github/workflows/tend-notifications.yaml index 5406852bbfca..4451a265ab0c 100644 --- a/.github/workflows/tend-notifications.yaml +++ b/.github/workflows/tend-notifications.yaml @@ -158,4 +158,3 @@ jobs: model: opus prompt: | /tend-ci-runner:notifications - timeout-minutes: 60 diff --git a/.github/workflows/tend-review-runs.yaml b/.github/workflows/tend-review-runs.yaml index efd2fa84c486..2a6ef405e5d6 100644 --- a/.github/workflows/tend-review-runs.yaml +++ b/.github/workflows/tend-review-runs.yaml @@ -43,4 +43,3 @@ jobs: model: opus prompt: | /tend-ci-runner:review-runs - timeout-minutes: 120 diff --git a/.github/workflows/tend-review.yaml b/.github/workflows/tend-review.yaml index 13ede268881a..49918c44b318 100644 --- a/.github/workflows/tend-review.yaml +++ b/.github/workflows/tend-review.yaml @@ -181,4 +181,3 @@ jobs: TARGET: issues/${{ github.event.pull_request.number }} BOT_NAME: prql-bot GITHUB_TOKEN: ${{ secrets.TEND_BOT_TOKEN }} - timeout-minutes: 120 diff --git a/.github/workflows/tend-triage.yaml b/.github/workflows/tend-triage.yaml index e41992acf96d..124e3bb4b364 100644 --- a/.github/workflows/tend-triage.yaml +++ b/.github/workflows/tend-triage.yaml @@ -71,4 +71,3 @@ jobs: TARGET: issues/${{ github.event.issue.number }} BOT_NAME: prql-bot GITHUB_TOKEN: ${{ secrets.TEND_BOT_TOKEN }} - timeout-minutes: 120 diff --git a/.github/workflows/tend-weekly.yaml b/.github/workflows/tend-weekly.yaml index 239a96cb9d7c..4a318276c6b5 100644 --- a/.github/workflows/tend-weekly.yaml +++ b/.github/workflows/tend-weekly.yaml @@ -43,4 +43,3 @@ jobs: model: opus prompt: | /tend-ci-runner:weekly - timeout-minutes: 60