Expose prefab instantiation to Lua#816
Merged
Merged
Conversation
adriengivry
requested changes
May 18, 2026
Member
adriengivry
left a comment
There was a problem hiding this comment.
Instantiate prefab should be a method in OvCore::SceneSystem::Scene, and Lua should expose it. Implementation should not live in Lua bindings.
Contributor
Author
While reviewing the runtime path, I found that prefab actors spawned during play mode could receive lifecycle callbacks before deserialization was complete. I fixed this by deferring startup until the instantiated hierarchy has been fully deserialized |
adriengivry
requested changes
May 19, 2026
adriengivry
requested changes
May 20, 2026
adriengivry
requested changes
May 20, 2026
adriengivry
approved these changes
May 21, 2026
Contributor
Author
My bad 🙇 |
adriengivry
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Scene:InstantiatePrefab(...)to Lua with optional local transform and parent.Related Issue(s)
Fixes #808
Review Guidance
Focus on Lua overloads, prefab path resolution, and prefab source normalization.
Screenshots/GIFs
N/A
AI Usage Disclosure
Refactored code / Debugging
Checklist