fix: show meaningful message when user already belonged to group (#57)

Signed-off-by: romanetar <roman_ag@hotmail.com>

Author: romanetar

app/libs/Auth/Models/User.php

@@ -713,10 +713,12 @@ public function belongToGroup(string $slug): bool
 
     /**
      * @param Group $group
+     * @throws ValidationException
      */
     public function addToGroup(Group $group)
     {
-        if ($this->groups->contains($group)) return;
+        if ($this->groups->contains($group))
+            throw new ValidationException("User is already assigned to this group.");
         $this->groups->add($group);
     }
 

public/assets/js/ajax.utils.js

@@ -4,8 +4,9 @@ function ajaxError(jqXHR, textStatus, errorThrown){
         response = $.parseJSON(jqXHR.responseText);
         if(HTTP_status == 412 ){
             var msg = '';
-            for(var property in response.messages) {
-                msg +='* '+ response.messages[property]+'\n';
+
+            for(const error of response.errors) {
+                msg +='* '+ error+'\n';
             }
             displayErrorMessage('Validation error', msg);
             return;