"Invalid supervisor, "start-stop-daemon", using start-stop-daemon"

[flexibeast]

If a service has the line:

supervisor=start-stop-daemon

then starting the service results in the rather confusing message Invalid supervisor, "start-stop-daemon", using start-stop-daemon.

This is a result of openrc-run.sh specifying:

default_start()
{
  local func=ssd_start
    case "$supervisor" in
      runit) func=runit_start ;;
      s6) func=s6_start ;;
      supervise-daemon) func=supervise_start ;;
      ?*)
        ewarn "Invalid supervisor, \"$supervisor\", using start-stop-daemon"
        ;;
    esac
    $func
}

and similarly for default_stop. The lack of a case for start-stop-daemon results in fallthrough to the catch-all final case.

Some suggested remedies:

• Add the case, e.g.

start-stop-daemon) true ;;

or perhaps

start-stop-daemon)
  ewarn "Remove 'supervisor=start-stop-daemon` from service file; start-stop-daemon will be used by default."
  ;;

• Wrap the ewarn in a conditional that checks whether $supervisor matches start-stop-daemon.