Skip to content

Commit d567c7d

Browse files
juhyun-kim-uclaHua-Zhou
authored andcommitted
fix fit_reml to return 6 values as before
1 parent 1cbf9b0 commit d567c7d

1 file changed

Lines changed: 8 additions & 10 deletions

File tree

test/two_variance_component_test.jl

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ vcmodelrot = TwoVarCompModelRotate(vcmodel)
4646
@inferred logpdf(vcmodelrot, vcdatarot)
4747
@test logpdf(vcmodel, vcdata) == logpdf(vcmodelrot, vcdatarot)
4848
@test (logpdf(vcmodelrot, [vcdatarot vcdatarot; vcdatarot vcdatarot]) -
49-
logpdf(vcmodel, [vcdata vcdata; vcdata vcdata])) 0.0
49+
logpdf(vcmodel, [vcdata vcdata; vcdata vcdata])) 0.0
5050

5151
# @info "Evaluate gradient"
5252
# ∇ = zeros(2d^2)
@@ -66,7 +66,7 @@ vcmodelrot = TwoVarCompModelRotate(vcmodel)
6666
@test norm(VarianceComponentModels.gradient(vcmodel, vcdata) - VarianceComponentModels.gradient(vcmodelrot, vcdatarot)) 0.0
6767
@test norm(VarianceComponentModels.gradient(vcmodel, vcdata) - VarianceComponentModels.gradient(vcmodel, vcdatarot)) 0.0
6868
@test norm(VarianceComponentModels.gradient(vcmodel, [vcdata vcdata]) -
69-
2.0VarianceComponentModels.gradient(vcmodel, vcdata)) 0.0
69+
2.0VarianceComponentModels.gradient(vcmodel, vcdata)) 0.0
7070
@test norm(VarianceComponentModels.gradient(vcmodel, [vcdata vcdata]) -
7171
VarianceComponentModels.gradient(vcmodelrot, [vcdatarot vcdatarot])) 0.0
7272

@@ -77,9 +77,9 @@ H = zeros(2d^2, 2d^2)
7777
@test norm(fisher_Σ(vcmodel, vcdata) - fisher_Σ(vcmodelrot, vcdatarot)) 0.0
7878
@test norm(fisher_Σ(vcmodel, vcdata) - fisher_Σ(vcmodel, vcdatarot)) 0.0
7979
@test norm(fisher_Σ(vcmodel, [vcdata vcdata]) -
80-
2fisher_Σ(vcmodel, vcdata)) 0.0
80+
2fisher_Σ(vcmodel, vcdata)) 0.0
8181
@test norm(fisher_Σ(vcmodel, [vcdata vcdata]) -
82-
fisher_Σ(vcmodelrot, [vcdatarot vcdatarot])) 0.0
82+
fisher_Σ(vcmodelrot, [vcdatarot vcdatarot])) 0.0
8383

8484

8585
@info "Evaluate Fisher information matrix of B"
@@ -89,9 +89,9 @@ H = zeros(p * d, p * d)
8989
@test norm(fisher_B(vcmodel, vcdata) - fisher_B(vcmodelrot, vcdatarot)) 0.0
9090
@test norm(fisher_B(vcmodel, vcdata) - fisher_B(vcmodel, vcdatarot)) 0.0
9191
@test norm(fisher_B(vcmodel, [vcdata vcdata]) -
92-
2.0fisher_B(vcmodel, vcdata)) 0.0
92+
2.0fisher_B(vcmodel, vcdata)) 0.0
9393
@test norm(fisher_B(vcmodel, [vcdata vcdata]) -
94-
fisher_B(vcmodelrot, [vcdatarot vcdatarot])) 0.0
94+
fisher_B(vcmodelrot, [vcdatarot vcdatarot])) 0.0
9595

9696
@info "Find MLE using Fisher scoring"
9797
vcmfs = deepcopy(vcmodel)
@@ -162,14 +162,12 @@ logl_mle, _, _, Σcov_mle, Bse_mle, = fit_mle!(vcmmle, vcdata; algo = :MM)
162162

163163
@info "test fit_reml (FS)"
164164
vcmreml = deepcopy(vcmodel)
165-
logl_reml, Σcov_reml, Bse_reml, = fit_reml!(vcmreml, vcdata; algo = :FS)
166-
# logl_reml, _, _, Σcov_reml, Bse_reml, = fit_reml!(vcmreml, vcdata; algo = :FS)
165+
logl_reml, _, _, Σcov_reml, Bse_reml, = fit_reml!(vcmreml, vcdata; algo = :FS)
167166
@show vcmreml.B, Bse_reml, B
168167

169168
@info "test fit_reml (MM)"
170169
vcmreml = deepcopy(vcmodel)
171-
#logl_reml, _, _, Σcov_reml, Bse_reml, = fit_reml!(vcmreml, vcdata; algo = :MM)
172-
logl_reml, _, Σcov_reml, Bse_reml, = fit_reml!(vcmreml, vcdata; algo = :MM)
170+
logl_reml, _, _, Σcov_reml, Bse_reml, = fit_reml!(vcmreml, vcdata; algo = :MM)
173171
@show vcmreml.B, Bse_reml, B
174172

175173
## NOTE:

0 commit comments

Comments
 (0)