From 1e2e5c6c465e1cb48a363a580a516380b0884370 Mon Sep 17 00:00:00 2001 From: Mohammed Zayer Alam Date: Sun, 2 Aug 2026 18:33:06 +0530 Subject: [PATCH 1/2] Add Load manufacturer names interface to PidStoreLoader Add method declaration for loading manufacturer names in PidStoreLoader for issue #1838 --- common/rdm/PidStoreLoader.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/rdm/PidStoreLoader.h b/common/rdm/PidStoreLoader.h index d6708d9b48..c7751901dc 100644 --- a/common/rdm/PidStoreLoader.h +++ b/common/rdm/PidStoreLoader.h @@ -72,8 +72,9 @@ class PidStoreLoader { * @returns A pointer to a new RootPidStore or NULL if loading failed. */ const RootPidStore *LoadFromStream(std::istream *data, - bool validate = true); - + +bool validate = true); +const RootPidStore *LoadManufacturerNames(const std::string &file); private: typedef std::map PidMap; typedef std::map ManufacturerMap; From e07f5351d33f35e61bac9b68d63c482e174e695c Mon Sep 17 00:00:00 2001 From: Mohammed Zayer Alam Date: Wed, 5 Aug 2026 18:54:30 +0530 Subject: [PATCH 2/2] Fix accidental newline in PidStoreLoader.h Removed extra newline to address review feedback. --- common/rdm/PidStoreLoader.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/common/rdm/PidStoreLoader.h b/common/rdm/PidStoreLoader.h index c7751901dc..d97ab4c95d 100644 --- a/common/rdm/PidStoreLoader.h +++ b/common/rdm/PidStoreLoader.h @@ -71,9 +71,7 @@ class PidStoreLoader { * contents. * @returns A pointer to a new RootPidStore or NULL if loading failed. */ - const RootPidStore *LoadFromStream(std::istream *data, - -bool validate = true); + const RootPidStore *LoadFromStream(std::istream *data, bool validate = true); const RootPidStore *LoadManufacturerNames(const std::string &file); private: typedef std::map PidMap;