Clamp sprite limit inputs to prevent OOB and exhaustion#124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
mSpritesMaxexternally controllable (CLI/INI/demo JSON) while many engine paths still assume at least 45 sprites, allowing out-of-bounds writes and memory-exhaustion via crafted inputs.\Description
MIN_SPRITES_MAX = 45andMAX_SPRITES_MAX = 100000constants tosFodderParametersinSource/Parameters.hppto centralize safe bounds.\CUSTOM_DEFAULT_MAX_SPRITESto the newMAX_SPRITES_MAXto keep custom-mode defaults consistent inSource/Parameters.cpp.\mSpritesMaxto the[MIN_SPRITES_MAX, MAX_SPRITES_MAX]range when loading from demo/save JSON insFodderParameters::FromJson.\mSpritesMaxafter parsing CLI (--max-sprite) insFodderParameters::ProcessCLIand after readingengine.maxspritefromopenfodder.iniinsFodderParameters::ProcessINIto cover all untrusted input paths.\Testing
rgto verify all input code paths (mSpritesMax,--max-sprite,Sprite_Clear_All,Map_Load_Sprites) are covered by the clamping changes and inspected diffs withgit diff, which succeeded.\Clamp max sprite parameter to safe range.Codex Task