Skip to content

Commit f282088

Browse files
committed
fix(release): electron-builder publish config + packaging artifact names for 0.1.1
Two packaging corrections discovered while validating the v0.1.0 release: - electron-builder.yml: the earlier `publish: null` fix handled the "Cannot read properties of null (reading 'channel')" crash on macOS + Linux, but NSIS on Windows hit a separate null-deref inside createUpdateInfoTasks (reading 'provider'). Declare a real publish target (`provider: github, owner: OpenCoworkAI, repo: open-codesign`); `--publish never` on the CLI keeps electron-builder from actually pushing anything, but now the update-info code has non-null fields to work with. - apps/desktop/package.json: add the `repository` field electron-builder warned about, so it stops synthesizing one from .git/config. - packaging/: Windows NSIS with `arch: [x64, arm64]` emits a single multi-arch installer named `open-codesign.Setup.<version>.exe` (not per-arch `-x64-setup.exe` / `-arm64-setup.exe`). Fix both manifests — winget installer.yaml now uses the same InstallerUrl for both architectures, Scoop collapses to a flat top-level url/hash. - update-shas.sh: one `WIN_EXE` variable + one `REPLACE_WITH_WIN_SHA256` placeholder instead of per-arch. - Bump remaining workspace package.json files to 0.1.1 to match apps/desktop + root. - Rename winget tree 0.1.0 → 0.1.1; update version fields in all three channel manifests.
1 parent abfe482 commit f282088

18 files changed

Lines changed: 64 additions & 75 deletions

File tree

apps/desktop/electron-builder.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
appId: ai.opencowork.codesign
22
productName: open-codesign
3-
# Auto-update metadata (latest.yml / latest-mac.yml) is intentionally
4-
# disabled for v0.1: no code-signing, no public update channel. An
5-
# explicit `publish: null` stops electron-builder from calling
6-
# `computeChannelNames` on a nonexistent publish config, which crashes
7-
# packaging with "Cannot read properties of null (reading 'channel')".
8-
publish: null
3+
# Declare the publish target explicitly so electron-builder's updater-info
4+
# machinery (channels, provider, latest.yml) has something non-null to hang
5+
# on — otherwise NSIS packaging crashes with "Cannot read properties of null
6+
# (reading 'provider')" even when we never intend to publish. CI invokes
7+
# electron-builder with `--publish never`, so nothing is actually uploaded.
8+
publish:
9+
- provider: github
10+
owner: OpenCoworkAI
11+
repo: open-codesign
912
directories:
1013
buildResources: resources
1114
output: release

packages/artifacts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/artifacts",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/core",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/exporters/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/exporters",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/i18n/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/i18n",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/providers/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/providers",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/runtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/runtime",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/shared/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/shared",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/templates/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/templates",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

packages/ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@open-codesign/ui",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"private": true,
55
"type": "module",
66
"main": "./src/index.ts",

0 commit comments

Comments
 (0)