Skip to content

Commit eb11a3f

Browse files
committed
Address review: disable_search consistency + document carryforward intent
- frontend.yml: add `disable_search: true` to the CT and Unit Codecov uploads so all three frontend uploads (including E2E) share the same 'don't auto-discover additional reports' behavior. - .codecov.yml: rewrite the stale comment above the `frontend` flag. It still described the deleted `codecov-notify.yml` lcov-merge path; it now explains that the flag is fed by multi-flag-tagged per-suite uploads and calls out that `carryforward: true` is what keeps the README badge stable on backend-only commits (when all three frontend producing workflows are path-filtered out).
1 parent 53de0b0 commit eb11a3f

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

.codecov.yml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,17 @@ flags:
4545
paths:
4646
- frontend/src/
4747
carryforward: true
48-
# Merged frontend flag uploaded by codecov-notify.yml after combining the
49-
# three per-suite lcovs (frontend-unit, frontend-component, frontend-e2e).
50-
# This is what the README badge reads so it reflects the union of all
51-
# frontend test suites, not just the Vitest slice. Intentionally does NOT
48+
# Merged frontend flag that the README badge reads. Populated by tagging
49+
# each per-suite upload (`frontend-unit`, `frontend-component`,
50+
# `frontend-e2e`) with `frontend` as an additional flag in its workflow,
51+
# so Codecov aggregates the union of the three uploads server-side.
52+
# `carryforward: true` is load-bearing — a backend-only commit path-filters
53+
# all three producing workflows out, so without carryforward the badge
54+
# would drop to "unknown" on those commits; with it, the flag reuses the
55+
# last known coverage from the parent commit. Intentionally does NOT
5256
# match the `frontend-.*` regex used by the component_management block
5357
# below, so the `frontend` component keeps aggregating only the three
54-
# per-suite flags and doesn't double-count this merged upload.
58+
# per-suite flags and doesn't double-count this merged flag.
5559
frontend:
5660
paths:
5761
- frontend/src/

.github/workflows/frontend.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ jobs:
9494
flags: frontend-component,frontend
9595
name: frontend-ct-coverage
9696
fail_ci_if_error: false
97+
disable_search: true
9798

9899
build:
99100
name: Build
@@ -148,6 +149,7 @@ jobs:
148149
flags: frontend-unit,frontend
149150
name: frontend-unit-coverage
150151
fail_ci_if_error: false
152+
disable_search: true
151153

152154
docker-build:
153155
name: Build Docker Image

0 commit comments

Comments
 (0)