Raise CT coverage for Corpus Chat & Agent components; fix SYNC_CONTENT loss

Adds 36 new Playwright component tests across the four lowest-coverage
components under frontend/src/components/corpuses/ toward the ≥60% target
set by issue #1276, and fixes a latent bug in CorpusChat's WebSocket
handler that dropped SYNC_CONTENT frames.

CorpusChat.tsx: SYNC_CONTENT now appends the message to the visible chat
list (mirroring ChatTray). Previously the handler only routed the content
to chatSourceState for citation storage, so synchronous, non-streaming
server replies rendered nothing. New regression test pins the behavior.

Test additions (all pass):
- CorpusChat.ct.tsx (+13): initialQuery auto-send, ASYNC_THOUGHT tool-call
  timeline, ASYNC_SOURCES, SYNC_CONTENT, ASYNC_RESUME, ask_document sub-tool
  approval name remapping, unknown-type default branch, back-to-list nav,
  server-message-with-sources, title-filter debounce.
- CreateCorpusActionModal.ct.tsx (+8): analyzer validation, inline-agent
  validations (empty name / empty instructions), existing-agent selection
  validation, inline-agent create happy path, backend error toast, edit
  analyzer pre-population, legacy trigger-casing fallback.
- CorpusAgentManagement.ct.tsx (+8): query loading, query error, multi-tool
  overflow badge, inactive-status badge, update-mutation happy path,
  create backend-error toast, tool deselection, edit-modal cancel.
- CorpusDescriptionEditor.ct.tsx (+7): save ok:false error, save network
  error, reapply missing-snapshot, twice-click collapse, Cancel Version
  Edit reset, fetch-md URL failure, version-count pluralization.

Closes #1276

Author: claude

CHANGELOG.md

@@ -9,6 +9,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- **`CorpusChat` dropped `SYNC_CONTENT` messages from the visible chat** (Issue #1276, `frontend/src/components/corpuses/CorpusChat.tsx:468-495`): The `SYNC_CONTENT` WebSocket frame is a standalone, non-streaming assistant reply used for synchronous server responses. `ChatTray` (document chat) appends these directly to its `chat` state; the corpus-level chat only forwarded the content to `handleCompleteMessage`, which stores sources in `ChatSourceAtom` but never pushes a message to the visible list. As a result, any `SYNC_CONTENT` the backend sent over the corpus socket rendered nothing. Fixed by mirroring the `ChatTray` pattern — push a new complete assistant message into `chat` before persisting sources/timeline. New regression test in `frontend/tests/CorpusChat.ct.tsx` ("SYNC_CONTENT renders a complete message immediately") pins the behavior.
+
+### Added
+
+- **Coverage: raise Corpus Chat & Agent Management component tests** (Issue #1276): added 36 new Playwright CT tests across the four lowest-ROI corpus components to drive coverage toward the ≥60% target. Breakdown:
+  - `frontend/tests/CorpusChat.ct.tsx` (+13 tests): `initialQuery` auto-send, tool-call timeline entries (ASYNC_THOUGHT), ASYNC_SOURCES merge, SYNC_CONTENT rendering, ASYNC_RESUME, ask_document sub-tool approval remapping, unknown-type default branch, back-to-list navigation, server-message-with-sources rendering, title-filter debounce, and additional navigation-header coverage. Extended the shared `StubSocket` in `beforeEach` with new query-triggered frame sequences.
+  - `frontend/tests/CreateCorpusActionModal.ct.tsx` (+8 tests): analyzer-path validation, inline-agent validation (empty name / empty instructions), existing-agent-selection validation, successful inline-agent mutation, backend error toast, analyzer edit-mode pre-population, and legacy trigger-casing normalization fallback.
+  - `frontend/tests/CorpusAgentManagement.ct.tsx` (+8 tests): query loading state, query error state, multi-tool badge overflow, inactive-status badge, update-mutation happy path, create-mutation backend-error toast, tool deselection, and edit-modal cancel.
+  - `frontend/tests/CorpusDescriptionEditor.ct.tsx` (+7 tests): save failure (`ok: false`), save network-error path, reapply of snapshot-less version, twice-click collapse, Cancel Version Edit reset, fetch-md URL failure, and version-count pluralization.
+
+### Fixed
+
 - **Frontend coverage badge reported ~31% despite months of added tests** (`README.md:12`, `.github/workflows/codecov-notify.yml`, `.codecov.yml`, `frontend/vite.config.ts:210-223`): The README's "Frontend coverage" badge was pointing at `flag=frontend-unit` — the Vitest slice only. The three frontend suites (Vitest unit, Playwright component via `vite-plugin-istanbul`, Playwright E2E via `vite-plugin-istanbul`) upload to separate Codecov flags (`frontend-unit`, `frontend-component`, `frontend-e2e`) and were never merged into a single lcov. Recent PRs almost exclusively added Playwright component and E2E tests, so their coverage landed in `frontend-component`/`frontend-e2e` while the badge stayed stuck reading the Vitest slice.
   - Added an `Upload {unit,CT,E2E} lcov artifact` step (using `actions/upload-artifact@v7`) to each producing job in `.github/workflows/frontend.yml` (`component-test` and `unit-test`) and `.github/workflows/frontend-e2e.yml` (`e2e`). The existing per-flag Codecov uploads are untouched, so per-suite drill-in still works.
   - Extended the existing cross-workflow coordinator at `.github/workflows/codecov-notify.yml` to download the three artifacts by run id (via `actions/download-artifact@v7` with `continue-on-error: true` to tolerate path-filtered skips and upload failures), merge them with `npx lcov-result-merger@5`, and upload the combined lcov to Codecov under a new `frontend` flag before calling `send-notifications`. The existing `listWorkflowRunsForRepo` check already discovers the producing runs by SHA — it now also emits `frontend_ci_run_id` and `frontend_e2e_run_id` outputs for the downloads to consume.

frontend/src/components/corpuses/CorpusChat.tsx

@@ -466,6 +466,20 @@ export const CorpusChat: React.FC<CorpusChatProps> = ({
             setIsProcessing(false);
             break;
           case "SYNC_CONTENT": {
+            // SYNC_CONTENT is a standalone, non-streaming assistant message.
+            // Append it to chat so it renders, then persist sources/timeline.
+            setChat((prev) => [
+              ...prev,
+              {
+                messageId: data?.message_id || `asst_${Date.now()}`,
+                user: "Assistant",
+                content,
+                timestamp: new Date().toLocaleString(),
+                isAssistant: true,
+                isComplete: true,
+              },
+            ]);
+
             const sourcesToPass =
               data?.sources && Array.isArray(data.sources)
                 ? data.sources

frontend/tests/CorpusAgentManagement.ct.tsx

@@ -6,6 +6,7 @@ import { GET_CORPUS_AGENTS, GET_AVAILABLE_TOOLS } from "../src/graphql/queries";
 import {
   CREATE_AGENT_CONFIGURATION,
   DELETE_AGENT_CONFIGURATION,
+  UPDATE_AGENT_CONFIGURATION,
 } from "../src/graphql/mutations";
 
 const TEST_CORPUS_ID = "corpus-aam-1";
@@ -438,4 +439,317 @@ test.describe("CorpusAgentManagement", () => {
 
     await component.unmount();
   });
+
+  test("renders loading state while agents query is in flight", async ({
+    mount,
+    page,
+  }) => {
+    // Delayed mock keeps the query in flight so the loader renders
+    const slowAgentsMock: MockedResponse = {
+      ...buildAgentsMock([]),
+      delay: 2000,
+    };
+
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[slowAgentsMock, toolsMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("Loading agents...")).toBeVisible({
+      timeout: 5000,
+    });
+
+    await component.unmount();
+  });
+
+  test("renders error state when agents query fails", async ({
+    mount,
+    page,
+  }) => {
+    const erroringMock: MockedResponse = {
+      request: {
+        query: GET_CORPUS_AGENTS,
+        variables: { corpusId: TEST_CORPUS_ID },
+      },
+      error: new Error("Cannot reach backend"),
+    };
+
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[erroringMock, toolsMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("Error loading agents")).toBeVisible({
+      timeout: 20000,
+    });
+
+    await component.unmount();
+  });
+
+  test("shows multi-tool badge row with overflow +N when >2 tools", async ({
+    mount,
+    page,
+  }) => {
+    const multiToolAgent = {
+      ...sampleAgent,
+      id: "agent-multi",
+      name: "Multi",
+      availableTools: ["read_doc", "write_doc", "search_corpus", "tool4"],
+    };
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[buildAgentsMock([multiToolAgent]), toolsMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("Multi", { exact: true })).toBeVisible({
+      timeout: 20000,
+    });
+
+    // Only the first 2 tool badges are rendered + a "+2" pill
+    await expect(page.getByText("+2", { exact: true })).toBeVisible();
+
+    await component.unmount();
+  });
+
+  test("inactive agent shows Inactive status badge", async ({
+    mount,
+    page,
+  }) => {
+    const inactive = { ...sampleAgent, id: "agent-inactive", isActive: false };
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[buildAgentsMock([inactive]), toolsMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("Inactive", { exact: true })).toBeVisible({
+      timeout: 20000,
+    });
+
+    await component.unmount();
+  });
+
+  test("update mutation persists agent edits", async ({ mount, page }) => {
+    const updateMock: MockedResponse = {
+      request: {
+        query: UPDATE_AGENT_CONFIGURATION,
+        variables: {
+          agentId: sampleAgent.id,
+          name: "Renamed Agent",
+          slug: sampleAgent.slug,
+          description: sampleAgent.description,
+          systemInstructions: sampleAgent.systemInstructions,
+          availableTools: sampleAgent.availableTools,
+          permissionRequiredTools: sampleAgent.permissionRequiredTools,
+          badgeConfig: sampleAgent.badgeConfig,
+          avatarUrl: null,
+          isActive: sampleAgent.isActive,
+          isPublic: sampleAgent.isPublic,
+        },
+      },
+      result: {
+        data: {
+          updateAgentConfiguration: {
+            ok: true,
+            message: "Updated",
+            agent: {
+              id: sampleAgent.id,
+              name: "Renamed Agent",
+              slug: sampleAgent.slug,
+              description: sampleAgent.description,
+              badgeConfig: sampleAgent.badgeConfig,
+              availableTools: sampleAgent.availableTools,
+              permissionRequiredTools: sampleAgent.permissionRequiredTools,
+              isActive: sampleAgent.isActive,
+              isPublic: sampleAgent.isPublic,
+            },
+          },
+        },
+      },
+    };
+
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[
+          buildAgentsMock([sampleAgent]),
+          toolsMock,
+          updateMock,
+          buildAgentsMock([{ ...sampleAgent, name: "Renamed Agent" }]),
+        ]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("Summarizer", { exact: true })).toBeVisible({
+      timeout: 20000,
+    });
+
+    await page.getByLabel("Edit agent").click();
+
+    await expect(
+      page.getByText(`Edit Agent Configuration: ${sampleAgent.name}`, {
+        exact: true,
+      })
+    ).toBeVisible({ timeout: 5000 });
+
+    // Rename the agent
+    await page.locator('input[placeholder="Agent name"]').fill("Renamed Agent");
+
+    // Click Save Changes (modal footer button)
+    await page
+      .locator(".oc-modal button:has-text('Save Changes')")
+      .last()
+      .click();
+
+    await expect(page.getByText("Agent updated successfully")).toBeVisible({
+      timeout: 10000,
+    });
+
+    await component.unmount();
+  });
+
+  test("create mutation backend-error surfaces toast.error", async ({
+    mount,
+    page,
+  }) => {
+    const erroringCreateMock: MockedResponse = {
+      request: {
+        query: CREATE_AGENT_CONFIGURATION,
+        variables: {
+          name: "Buggy Agent",
+          slug: null,
+          description: "Desc",
+          systemInstructions: "Instr",
+          availableTools: null,
+          permissionRequiredTools: null,
+          badgeConfig: { icon: "bot", color: "#8b5cf6", label: "AI" },
+          avatarUrl: null,
+          scope: "CORPUS",
+          corpusId: TEST_CORPUS_ID,
+          isPublic: false,
+        },
+      },
+      result: {
+        data: {
+          createAgentConfiguration: {
+            ok: false,
+            message: "Slug collision detected",
+            agent: null,
+          },
+        },
+      },
+    };
+
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[buildAgentsMock([]), toolsMock, erroringCreateMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("No Agent Configurations")).toBeVisible({
+      timeout: 20000,
+    });
+
+    await page.locator("button:has-text('Create Agent')").first().click();
+    await expect(
+      page.getByText("Create Agent Configuration", { exact: true })
+    ).toBeVisible({ timeout: 5000 });
+
+    await page.locator('input[placeholder="Agent name"]').fill("Buggy Agent");
+    const textareas = page.locator("textarea");
+    await textareas.nth(0).fill("Desc");
+    await textareas.nth(1).fill("Instr");
+
+    await page
+      .locator(".oc-modal button:has-text('Create Agent')")
+      .last()
+      .click();
+
+    await expect(page.getByText("Slug collision detected")).toBeVisible({
+      timeout: 10000,
+    });
+
+    await component.unmount();
+  });
+
+  test("toggling a selected tool removes it from the Available Tools list", async ({
+    mount,
+    page,
+  }) => {
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[buildAgentsMock([]), toolsMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("No Agent Configurations")).toBeVisible({
+      timeout: 20000,
+    });
+    await page.locator("button:has-text('Create Agent')").first().click();
+    await expect(
+      page.getByText("Create Agent Configuration", { exact: true })
+    ).toBeVisible({ timeout: 5000 });
+
+    // Select read_doc
+    await page.locator(".oc-modal").getByText("read_doc").first().click();
+
+    // Selected pill is visible at the bottom
+    await expect(
+      page.locator(".oc-modal").getByText("read_doc").nth(1)
+    ).toBeVisible();
+
+    // Deselect by clicking again
+    await page.locator(".oc-modal").getByText("read_doc").first().click();
+
+    await expect(
+      page.getByText(
+        "Select available tools first to configure permission requirements."
+      )
+    ).toBeVisible();
+
+    await component.unmount();
+  });
+
+  test("close without saving from edit modal resets state", async ({
+    mount,
+    page,
+  }) => {
+    const component = await mount(
+      <CorpusAgentManagementTestWrapper
+        mocks={[buildAgentsMock([sampleAgent]), toolsMock]}
+        corpusId={TEST_CORPUS_ID}
+      />
+    );
+
+    await expect(page.getByText("Summarizer", { exact: true })).toBeVisible({
+      timeout: 20000,
+    });
+
+    await page.getByLabel("Edit agent").click();
+    await expect(
+      page.getByText(`Edit Agent Configuration: ${sampleAgent.name}`, {
+        exact: true,
+      })
+    ).toBeVisible({ timeout: 5000 });
+
+    // Click Cancel in the modal footer
+    await page.locator(".oc-modal button:has-text('Cancel')").last().click();
+
+    await expect(
+      page.getByText(`Edit Agent Configuration: ${sampleAgent.name}`, {
+        exact: true,
+      })
+    ).not.toBeVisible({ timeout: 5000 });
+
+    await component.unmount();
+  });
 });