Address review: move DEFAULT_MODERATOR_INSTRUCTIONS to constants, harden URL-failure test

Author: JSv4

frontend/src/assets/configurations/constants.ts

@@ -530,3 +530,12 @@ export const TRIGGER_LABELS: Record<string, string> = {
   new_thread: "On Thread",
   new_message: "On Message",
 } as const;
+
+// Default agent task instructions used when creating a thread-moderation
+// CorpusAction (rendered as the placeholder/initial value in the modal).
+export const DEFAULT_MODERATOR_INSTRUCTIONS = `You are a thread moderator for this corpus. Your role is to:
+1. Monitor discussion threads and messages for policy compliance
+2. Take appropriate moderation actions when needed
+3. Respond helpfully to user questions when appropriate
+
+You have access to thread context, messages, and moderation tools. Use them judiciously.`;

frontend/src/components/corpuses/CreateCorpusActionModal.tsx

@@ -20,6 +20,7 @@ import { StyledTextArea } from "../widgets/modals/styled";
 import { toast } from "react-toastify";
 import _ from "lodash";
 import { OS_LEGAL_COLORS } from "../../assets/configurations/osLegalStyles";
+import { DEFAULT_MODERATOR_INSTRUCTIONS } from "../../assets/configurations/constants";
 import { InlineBadge } from "../agents/AgentBadges";
 import { FormField } from "../widgets/form/FormField";
 
@@ -71,13 +72,6 @@ const DEFAULT_MODERATION_TOOLS = [
   { name: "unpin_thread", description: "Unpin a pinned thread" },
 ] as const;
 
-export const DEFAULT_MODERATOR_INSTRUCTIONS = `You are a thread moderator for this corpus. Your role is to:
-1. Monitor discussion threads and messages for policy compliance
-2. Take appropriate moderation actions when needed
-3. Respond helpfully to user questions when appropriate
-
-You have access to thread context, messages, and moderation tools. Use them judiciously.`;
-
 const DEFAULT_DOCUMENT_AGENT_INSTRUCTIONS =
   "You are a document processing agent for this corpus.";
 

frontend/tests/CorpusDescriptionEditor.ct.tsx

@@ -743,12 +743,10 @@ test.describe("CorpusDescriptionEditor", () => {
     mount,
     page,
   }) => {
-    // Intercept the markdown URL with a 500 error so the fetch().then() throws
+    // Abort the network request so the fetch promise rejects and the
+    // component's .catch() branch (setCurrentContent("")) runs.
     await page.route("**/test-md/**", async (route: any) => {
-      await route.fulfill({
-        status: 500,
-        body: "boom",
-      });
+      await route.abort("failed");
     });
 
     const component = await mount(
@@ -762,12 +760,12 @@ test.describe("CorpusDescriptionEditor", () => {
       timeout: 20000,
     });
 
-    // Editor remains mounted but body may contain text (the fetch itself
-    // succeeds — 500 body). The important thing is the component didn't crash.
     const textarea = page.locator(
       'textarea[placeholder="Write your corpus description in Markdown..."]'
     );
     await expect(textarea).toBeVisible({ timeout: 5000 });
+    // The catch branch resets content to empty string; pin that contract.
+    await expect(textarea).toHaveValue("", { timeout: 5000 });
 
     await component.unmount();
   });

frontend/tests/CreateCorpusActionModal.ct.tsx

@@ -13,7 +13,7 @@ import {
   CREATE_CORPUS_ACTION,
   UPDATE_CORPUS_ACTION,
 } from "../src/graphql/mutations";
-import { DEFAULT_MODERATOR_INSTRUCTIONS } from "../src/components/corpuses/CreateCorpusActionModal";
+import { DEFAULT_MODERATOR_INSTRUCTIONS } from "../src/assets/configurations/constants";
 import { docScreenshot } from "./utils/docScreenshot";
 
 const TEST_CORPUS_ID = "corpus-123";