Skip to content

Commit 9ed3adb

Browse files
committed
Address PR #1369 review: pre-commit fixes + filter naming + resolve_me type
- Apply pyupgrade/black/isort fixes (Optional → | None) and drop the resulting unused 'Optional'/'Union' imports. - Rename 'info: str' → 'name: str' on django-filters method signatures in filters.py. The parameter receives the filter field name; the 'info' name was misleading copy-paste from GraphQL resolver signatures (where 'info' is graphene.ResolveInfo). - Widen UserQueryMixin.resolve_me return type from User to User | AnonymousUser. The query has no @login_required, so info.context.user can be AnonymousUser at runtime.
1 parent 360194b commit 9ed3adb

7 files changed

Lines changed: 90 additions & 113 deletions

File tree

config/graphql/document_queries.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from __future__ import annotations
66

77
import logging
8-
from typing import Any, Optional
8+
from typing import Any
99

1010
import graphene
1111
from django.conf import settings
@@ -61,7 +61,7 @@ def resolve_documents(
6161

6262
def resolve_document(
6363
self, info: graphene.ResolveInfo, **kwargs: Any
64-
) -> Optional[Document]:
64+
) -> Document | None:
6565
document_id = kwargs.get("id")
6666
if not document_id:
6767
return None
@@ -331,7 +331,7 @@ def resolve_ingestion_sources(
331331
@graphql_ratelimit_dynamic(get_rate=get_user_tier_rate("READ_LIGHT"))
332332
def resolve_ingestion_source(
333333
self, info: graphene.ResolveInfo, id: str, **kwargs: Any
334-
) -> Optional[IngestionSource]:
334+
) -> IngestionSource | None:
335335
try:
336336
type_name, pk = from_global_id(id)
337337
if not pk or type_name != INGESTION_SOURCE_GLOBAL_ID_TYPE:

0 commit comments

Comments
 (0)