Skip to content

Commit 97713df

Browse files
authored
Merge pull request #1371 from Open-Source-Legal/claude/fix-issue-1359-KAz9F
Fix RemoveLabelsFromLabelsetMutation silently swallowing AttributeError (#1359)
2 parents 95d95ee + bcee7ff commit 97713df

115 files changed

Lines changed: 202 additions & 3 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions

config/graphql/label_mutations.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,12 @@ def mutate(root, info, label_ids, labelset_id):
293293
Q(pk=from_global_id(labelset_id)[1])
294294
& (Q(creator=user) | Q(is_public=True))
295295
)
296-
labelset_labels = labelset.documents.filter(pk__in=label_pks)
297-
labelset.annotation_labels.remove(*labelset_labels)
296+
labelset.annotation_labels.remove(*label_pks)
298297
ok = True
299298
message = "Success"
300299

301300
except Exception as e:
301+
logger.exception("RemoveLabelsFromLabelsetMutation failed")
302302
message = f"Error removing label(s) from labelset: {e}"
303303

304304
return RemoveLabelsFromLabelsetMutation(message=message, ok=ok)
-70 Bytes
-153 Bytes
-1.81 KB
265 Bytes
-171 Bytes
826 Bytes
-203 Bytes
-95 Bytes

0 commit comments

Comments
 (0)