Apply latest PR review feedback

Author: elleryli

components/Activity/Hackathon/HackathonActionHub.tsx

@@ -1,4 +1,4 @@
-import { FC, type PropsWithChildren } from 'react';
+import type { FC, PropsWithChildren } from 'react';
 import { Col, Container, Row } from 'react-bootstrap';
 
 import { HackathonHeroAction } from './HackathonHero';

components/Activity/Hackathon/HackathonAwards.tsx

@@ -5,9 +5,10 @@ import { Container } from 'react-bootstrap';
 import { LarkImage } from '../../LarkImage';
 import styles from './HackathonAwards.module.less';
 
-export type HackathonAwardsMeta<Value = string> = Record<'label', string> & {
+export interface HackathonAwardsMeta<Value = string> {
+  label: string;
   value: Value;
-};
+}
 
 export interface HackathonPrizeItem {
   description: string;

pages/api/Lark/document/copy/[...slug].ts

@@ -11,21 +11,14 @@ const router = createKoaRouter(import.meta.url);
 
 router.post('/:type/:id', safeAPI, verifyJWT, async (context: Context) => {
   const { type, id } = context.params,
-    { name, parentToken, ownerType, ownerId } = Reflect.get(
-      context.request,
-      'body',
-    );
+    { name, parentToken, ownerType, ownerId } = Reflect.get(context.request, 'body');
 
   const copiedFile =
     type === 'wiki'
       ? await lark.copyFile(`${type as 'wiki'}/${id}`, name, parentToken)
-      : await lark.copyFile(
-          `${type as LarkDocumentPathType}/${id}`,
-          name,
-          parentToken,
-        );
+      : await lark.copyFile(`${type as LarkDocumentPathType}/${id}`, name, parentToken);
 
-  const newId = copiedFile.token;
+  const newId = 'token' in copiedFile ? copiedFile.token : copiedFile.node_token;
 
   if (ownerType && ownerId)
     try {

pages/hackathon/[id].tsx

@@ -173,35 +173,26 @@ export const getServerSideProps = compose<{ id: string }>(
   errorLogger,
   async ({ params }) => {
     const activity = await new ActivityModel().getOne(params!.id);
-    const { appId, tableIdMap } = (activity.databaseSchema ||
-      {}) as BiTableSchema;
+    const schema = activity.databaseSchema as Partial<BiTableSchema> | undefined;
+    const tableIdMap = schema?.tableIdMap as Partial<Record<RequiredTableKey, string>> | undefined;
 
-    if (!appId || !tableIdMap) return { notFound: true, props: {} };
+    if (!schema?.appId || !tableIdMap) return { notFound: true, props: {} };
 
-    for (const key of RequiredTableKeys)
-      if (!tableIdMap[key]) return { notFound: true, props: {} };
+    for (const key of RequiredTableKeys) if (!tableIdMap[key]) return { notFound: true, props: {} };
 
-    const [people, organizations, agenda, prizes, templates, projects] =
-      await Promise.all([
-        new PersonModel(appId, tableIdMap.Person).getAll(),
-        new OrganizationModel(appId, tableIdMap.Organization).getAll(),
-        new AgendaModel(appId, tableIdMap.Agenda).getAll(),
-        new PrizeModel(appId, tableIdMap.Prize).getAll(),
-        new TemplateModel(appId, tableIdMap.Template).getAll(),
-        new ProjectModel(appId, tableIdMap.Project).getAll(),
-      ]);
+    const [people, organizations, agenda, prizes, templates, projects] = await Promise.all([
+      new PersonModel(schema.appId, tableIdMap.Person).getAll(),
+      new OrganizationModel(schema.appId, tableIdMap.Organization).getAll(),
+      new AgendaModel(schema.appId, tableIdMap.Agenda).getAll(),
+      new PrizeModel(schema.appId, tableIdMap.Prize).getAll(),
+      new TemplateModel(schema.appId, tableIdMap.Template).getAll(),
+      new ProjectModel(schema.appId, tableIdMap.Project).getAll(),
+    ]);
 
     return {
       props: {
         activity,
-        hackathon: {
-          people,
-          organizations,
-          agenda,
-          prizes,
-          templates,
-          projects,
-        },
+        hackathon: { people, organizations, agenda, prizes, templates, projects },
       },
     };
   },