fix: stabilize native release CI

Author: CjLogic

.github/workflows/ci.yml

@@ -26,6 +26,14 @@ jobs:
       # the binary on first require. Parallel vitest workers racing that download
       # corrupt the extract on macOS (EEXIST on the Electron Framework symlink),
       # so do it once, serially, up front. Idempotent - exits early if present.
-      - run: npm run install-electron
+      - name: Install Electron binary
+        shell: bash
+        run: |
+          for attempt in 1 2 3; do
+            npm run install-electron && exit 0
+            if [ "$attempt" -eq 3 ]; then exit 1; fi
+            echo "Electron download failed (attempt $attempt/3); retrying in 10 seconds..."
+            sleep 10
+          done
       - run: npm run typecheck
       - run: npm test

.github/workflows/release.yml

@@ -49,20 +49,29 @@ jobs:
       # corrupt the extract on macOS (EEXIST on the Electron Framework symlink),
       # so do it once, serially, up front. Idempotent - exits early if present.
       - name: Install Electron binary
-        run: npm run install-electron
-
-      # package.json sets npmRebuild:false, so node-pty is NOT rebuilt for
-      # Electron's ABI automatically. Without this the packaged app dies on
-      # first terminal spawn.
-      - name: Rebuild native modules for Electron
-        run: npm run rebuild
+        shell: bash
+        run: |
+          for attempt in 1 2 3; do
+            npm run install-electron && exit 0
+            if [ "$attempt" -eq 3 ]; then exit 1; fi
+            echo "Electron download failed (attempt $attempt/3); retrying in 10 seconds..."
+            sleep 10
+          done
 
       - name: Typecheck
         run: npm run typecheck
 
+      # Tests load node-pty under Node.js, so they must run before the native
+      # addon is rebuilt for Electron's different ABI.
       - name: Test
         run: npm test
 
+      # package.json sets npmRebuild:false, so node-pty is NOT rebuilt for
+      # Electron's ABI automatically. Rebuild only after Node-based tests pass;
+      # otherwise macOS tests load the Electron-ABI addon and PTY output stalls.
+      - name: Rebuild native modules for Electron
+        run: npm run rebuild
+
       # A tag like v0.2.0-nightly.1 must land as a GitHub *prerelease*, because
       # that is exactly what the app's nightly channel filters on
       # (autoUpdater.allowPrerelease). A stable tag must not be flagged.

src/main/remote-access-server.test.ts

@@ -96,13 +96,16 @@ describe('remote access server', () => {
         }
       })
     })
-    // /bin/sh does not exist on Windows. node is the one interpreter guaranteed
-    // to be present wherever this suite runs.
-    // Keep the process alive briefly after the write completes. A zero-lived
-    // process can exit before macOS's native PTY dispatches its final data event.
-    const script = 'process.stdout.write("remote-pty-ok", () => setTimeout(() => process.exit(0), 50))'
+    // /bin/sh does not exist on Windows. Node is the one interpreter guaranteed
+    // to be present wherever this suite runs. Keep it alive until input arrives
+    // so native PTY startup and immediate process exit cannot race on macOS.
+    const script = 'process.stdin.once("data", () => process.stdout.write("remote-pty-ok"))'
     const create = await rpc('pty', 'pty.create', { paneId: 'web-test', cwd: root, shell: process.execPath, argv: ['-e', script] })
     expect(create.status).toBe(200)
+    const createBody = await create.json() as { ok: boolean; result?: { ok?: boolean; error?: string } }
+    expect(createBody).toMatchObject({ ok: true, result: { ok: true } })
+    const write = await rpc('pty-write', 'pty.write', { paneId: 'web-test', data: 'go\n' })
+    expect(write.status).toBe(200)
     await expect(output).resolves.toContain('remote-pty-ok')
     socket.close()
   })