From f701d7f06f92e08d5b856d1ee6074795809a1ce9 Mon Sep 17 00:00:00 2001 From: RKS Date: Fri, 25 Sep 2026 15:56:44 -0400 Subject: [PATCH 1/2] fix(build): make clean reactor test compilation work Create the core multi-release JAR during process-classes so downstream JPMS adapter modules can resolve owasp.encoder during pre-package reactor phases. Add a clean test-compile CI check. Fixes #140 --- .github/workflows/build.yaml | 2 ++ core/pom.xml | 28 ++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 3ad9797..dc4a42c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -32,6 +32,8 @@ jobs: exit 1 fi echo "jakarta-test tests encoder-jakarta-jsp $tested from this build" + - name: Test clean reactor compilation + run: mvn -B -ntp clean test-compile - name: Run build run: mvn -B -ntp install -PtestJakarta diff --git a/core/pom.xml b/core/pom.xml index b271030..c869122 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -72,6 +72,34 @@ + + + org.apache.maven.plugins + maven-jar-plugin + + true + + + + reactor-jar + process-classes + + jar + + + false + + + + + default-jar + none + + jar + + + + org.apache.maven.plugins maven-surefire-plugin From 3b84438f09ad68cbfebd34994985888e86fe80a1 Mon Sep 17 00:00:00 2001 From: Jim Manico Date: Fri, 25 Sep 2026 19:33:05 -0700 Subject: [PATCH 2/2] fix(build): remove unsupported jar skip parameters --- core/pom.xml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/core/pom.xml b/core/pom.xml index b5324dc..59340f0 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -76,9 +76,6 @@ org.apache.maven.plugins maven-jar-plugin - - true - reactor-jar @@ -86,9 +83,6 @@ jar - - false -