Dap4 serialization patch#354
Conversation
jgallagher59701
left a comment
jgallagher59701
left a comment
There was a problem hiding this comment.
I think you should try the change we talked about . I added a comment about where and how you could do this.
| if (xmlTextWriterWriteAttribute(xml.get_writer(), (const xmlChar *)"dmrVersion", | ||
| (const xmlChar *)dmr_version().c_str()) < 0) | ||
| throw InternalErr(__FILE__, __LINE__, "Could not write attribute for dapVersion"); | ||
| throw InternalErr(__FILE__, __LINE__, "Could not write attribute for dmrVersion"); |
There was a problem hiding this comment.
I agree with your idea to make the 'serialization = ...' XML attribute a function of the response - and resetting the 'dmrVersion' XML attribute to 1.0. This would mean that a DMR response does not have the 'serialization' attribute and uses 'dmrVersion = 1.0'. Then for the DAP response, the "DMR Part" does have the 'serialization' attribute and has the 'dmrVersion = 1.0'.
If you're going to do that, this would nominally be the place and and you could do that by adding a third parameter. You could keep this existing method by making the two parameter version call the new three parameter version (thus maintaining ABI of this class).
…e DMR. I have elided any state regarding in the DMR, DDS, and D4ParserSax2 because there is no point ti holding the state. The code always performs the DAP4 seialization the correct way, and never the old way. The flag is only for consuming clients.
|
2 participants
No description provided.