Skip to content

Code Audit: GCP Helper Functions #248

Description

@coatet

Perform a code audit of the rdsa_utils.gcp.helpers module. Look at the code with these questions in mind:

  • What does the code do and what is it for?
  • Can we find anyone who currently uses this code?
  • Is this code within the scope of rdsa-utils?
  • Why would someone use this over using inbuilt Python functionality or custom code?
  • Does this code introduce extra complexity for users?
  • Is this code doing its task in a Pythonic way?
  • Is there a better/more efficient/simpler/more Pythonic way for the code to do this task?
  • Does this fit in with our established ways of doing things in RDSA?
  • Is this code in the right location and is it obvious why it's there?
  • How would people find this code? How do they know this is here and useful to them?

These don't need direct answers, they're just for helping you evaluate code critically.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions